Todo List

CoreAPI

access_get_status_threshold()

• p_project_id is unused

ajax_click_to_edit()

• function documentation

auth_generate_random_password()

• Review use of $p_email within mantis

auth_prepare_password()

• when we rewrite authentication api for plugins, this should be merged with prepare_username and return some object

auth_prepare_username()

• when we rewrite authentication api for plugins, this should be merged with prepare_password and return some object

bug_copy()

• Not managed FTP file upload

bug_get_extended_row()

• include reporter name and handler name, the problem is that handler can be 0, in this case no corresponding name will be found. Use equivalent of (+) in Oracle.

custom_field_get_value()

• return values are unclear... should we error when access is denied and provide an api to check whether it will be?

date_finish_calendar()

• (thraxisp) this may want a browser check ( MS IE >= 5.0, Mozilla >= 1.0, Safari >=1.2, ...)

date_print_calendar()

• (thraxisp) this may want a browser check ( MS IE >= 5.0, Mozilla >= 1.0, Safari >=1.2, ...)

db_date()

• review date handling

db_error()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_error_msg()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_error_num()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_helper_compare_days()

• Check if there is a way to do that using ADODB rather than implementing it here.

db_now()

• add param bool $p_gmt whether to use GMT or current timezone (default false)

db_prepare_binary_string()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_prepare_bool()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_prepare_double()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_prepare_int()

• Use/Behaviour of this function should be reviewed before 1.2.0 final

db_timestamp()

• review date handling

db_unixtimestamp()

• review date handling

filter_ensure_valid_filter()

• function needs to be abstracted

filter_field_is_none()

• is a check for these necessary? if ( ( $t_filter_value === 'none' ) || ( $t_filter_value === '[none]' ) )

filter_get_bug_rows()

• Had to make all these parameters required because we can't use call-time pass by reference anymore. I really preferred not having to pass all the params in if you didn't want to, but I wanted to get rid of the errors for now. If we can think of a better way later (maybe return an object) that would be great.

print_filter_do_filter_by_date()

• Javascript should be removed and added dynamically via external script

string_custom_field_value()

• This probably belongs in the string_api.php

MantisBT

$g_default_email_on_priority

• Unused

$g_default_email_on_priority_minimum_severity

• Unused

$g_default_email_on_status

• Unused

$g_notify_flags

• (though I'm not sure they need to be turned off anymore
  • there just won't be anyone in those categories)
  I guess it serves as an example and a placeholder for this config option

$g_password_confirm_hash_magic_string

• randomize + admin check

$g_view_handler_threshold

• yarick123: now it is implemented for notification email only

$g_view_history_threshold

• yarick123: now it is implemented for notification email only

MANTIS_INSTALLER

• put this somewhere

STDIN

• This is a hack to detect php-cgi, there must be a better way.

system_utils.php

• FIXME: Looks like "From", "to", and "Copy" need i18n. Possibly more in this file.

write_bug_rows()

• (thraxisp) this may want a browser check ( MS IE >= 5.0, Mozilla >= 1.0, Safari >=1.2, ...)