| ../irclogs/#mantishelp.2009-04-07.log | ||
| --- scribe started --- | 00:00 | |
| mantisbot | New bug: Bug 10296 - nobswolf - open - new | 05:36 |
|---|---|---|
| mantisbot | New bug: single project is not selected - http://www.mantisbt.org/bugs/view.php?id=10296 | 05:36 |
| mantisbot | New bug: Bug 10297 - nobswolf - open - new | 08:37 |
| mantisbot | New bug: allow a reference from a custom column - http://www.mantisbt.org/bugs/view.php?id=10297 | 08:37 |
| mantisbot | New bug: Bug 10298 - jan jindra - open - new | 10:27 |
| mantisbot | New bug: erewre - http://www.mantisbt.org/bugs/view.php?id=10298 | 10:27 |
| CIA-18 | Mantisbt: paul * r7a111a586dc5 /core/ (error_api.php gpc_api.php lang_api.php obsolete.php): PHPDoc updates | 10:40 |
| CIA-18 | Mantisbt: paul * r96cb7ba31225 /graphs/ (8 files): db_get_table should be used to retrieve table names | 10:40 |
| paulr | hi kirill | 10:57 |
| [KK]Kirill | paulr: Hi | 11:09 |
| [KK]Kirill | My stupid work take more time... | 11:10 |
| [KK]Kirill | I see John work with source-integrator, and append new events in mantisbt | 11:10 |
| [KK]Kirill | but my wish not append | 11:10 |
| paulr | hmm? | 11:12 |
| [KK]Kirill | I want add event to work with uploaded files | 11:13 |
| [KK]Kirill | for example compress file to zip and put in issue archived files, not original | 11:14 |
| [KK]Kirill | or secont example - change filename from national character to latin | 11:15 |
| [KK]Kirill | did you understand what I want? | 11:15 |
| paulr | hmm | 11:15 |
| paulr | as plugin events? | 11:16 |
| [KK]Kirill | yes | 11:16 |
| [KK]Kirill | I want plugin event for work with attached files | 11:16 |
| [KK]Kirill | before they attached | 11:16 |
| [KK]Kirill | or/and after attached | 11:17 |
| paulr | sounds nasty | 11:17 |
| paulr | i.e. I can see that breaking stuff | 11:17 |
| [KK]Kirill | paulr: sorry, I don't understand | 11:19 |
| paulr | [12:14:32] <[KK]Kirill> for example compress file to zip and put in issue archived files, not original | 11:19 |
| [KK]Kirill | yes | 11:19 |
| [KK]Kirill | example from real life | 11:20 |
| [KK]Kirill | I have mantis for my company to support other it-personal | 11:20 |
| [KK]Kirill | they upload files in national characters | 11:21 |
| [KK]Kirill | inissue they show nice | 11:21 |
| [KK]Kirill | correctly | 11:21 |
| [KK]Kirill | but when I try download in different browser I take break filename | 11:22 |
| [KK]Kirill | in unicode-codes | 11:22 |
| paulr | is that a bug in filedownload though? | 11:22 |
| [KK]Kirill | may be. | 11:23 |
| [KK]Kirill | I can understand why | 11:23 |
| [KK]Kirill | may be in web-server misconfig | 11:23 |
| [KK]Kirill | may be browser or mantisbt | 11:23 |
| paulr | adding a plugin to zip files could be interesting ( although I *think* it would probably result in hassle) | 11:23 |
| [KK]Kirill | :) | 11:24 |
| [KK]Kirill | ok. it's will be nice to work with files | 11:24 |
| paulr | adding a plugin to change filename's strikes me as something that will probably cause some level of grief | 11:24 |
| [KK]Kirill | paulr: change name to unique filenames | 11:25 |
| paulr | i.e. if someone attaches a file atm in chinese, i'd expect them to get the file back with a chinese filename | 11:25 |
| [KK]Kirill | I want store original filename in plugin-table | 11:25 |
| paulr | dont we already store the original filename in the file_table? | 11:26 |
| [KK]Kirill | in mantis_file_table store changed filenames, in plugin file table store original. In all issues show original file names | 11:29 |
| [KK]Kirill | but when download plugin put changed filename | 11:29 |
| [KK]Kirill | sorry, not put - give | 11:30 |
| [KK]Kirill | and downloaded filename with changed filename | 11:30 |
| paulr | lo daryn | 13:20 |
| daryn | mornin | 13:20 |
| daryn | er...afternoon i guess | 13:21 |
| paulr | daryn: i'm so bored | 13:44 |
| [KK]Kirill | who? | 13:45 |
| [KK]Kirill | I? | 13:45 |
| paulr | << | 13:46 |
| [KK]Kirill | :) | 13:46 |
| paulr | nuclear_eclipse: ./ | 13:49 |
| paulr | daryn: wherd you get to with cddef classes? | 14:51 |
| daryn | mmm | 15:00 |
| daryn | been awhile | 15:00 |
| * paulr is playing with cc | 15:00 | |
| daryn | i think the def classes near working order but i was trying to figure out how to do the cf types | 15:01 |
| paulr | check out http://www.mantisforge.org:8080/cruisecontrol/buildresults/mantisbt | 15:01 |
| daryn | sweet | 15:01 |
| paulr | it's kinda broken atm though | 15:02 |
| daryn | we use hudson in house | 15:02 |
| daryn | not for mantis though | 15:02 |
| paulr | hudson? | 15:02 |
| daryn | another automated build system | 15:02 |
| daryn | continuous integration | 15:03 |
| * paulr is currently working on php codesnifer rules | 15:03 | |
| paulr | so nows a good time to tell me if we dont like anything | 15:04 |
| daryn | i split the cf classes, api changes, and page changes into separate branches. was trying to make sure existing functionality stays the same | 15:05 |
| paulr | 2977 | ERROR | Functions must not contain multiple empty lines in a row; found | 15:06 |
| paulr | | | 2 empty lines | 15:06 |
| * paulr slaps daryn ;p | 15:06 | |
| daryn | basically i'm implementing the api's into classes while mostly leaving the custom_field_api file alone. | 15:06 |
| daryn | :P | 15:06 |
| daryn | it's not done | 15:06 |
| daryn | so...leave me alone | 15:06 |
| paulr | that was in filter api | 15:06 |
| paulr | ;p | 15:06 |
| daryn | that's not done either | 15:07 |
| daryn | rebooting...back momentarily | 15:08 |
| nuclear_eclipse | paulr: hi | 15:18 |
| paulr | lo | 15:18 |
| paulr | ?> | 15:21 |
| daryn | paulr: I thought we weren't supposed to use closing php tag anymore... | 15:22 |
| nuclear_eclipse | daryn: you're correct | 15:23 |
| paulr | really?! | 15:23 |
| nuclear_eclipse | right, the whole point of leaving off the closing tags is to prevent unintentional whitespace output | 15:24 |
| paulr | that's quite interesting you mention this | 15:24 |
| paulr | :( | 15:25 |
| CIA-18 | Mantisbt: paul * rb4cf7972d817 / (28 files in 3 dirs): Remove remaining closing tags | 15:26 |
| CIA-18 | Mantisbt: paul * r5cf7970fb208 / (197 files in 8 dirs): Consistency update | 15:26 |
| daryn | heh...i was just trying to be funny | 15:28 |
| daryn | [10:21] <paulr> ?> | 15:28 |
| paulr | oh so you didn't mean to do it? ;p | 15:32 |
| daryn | no, but it's fine by me. | 15:35 |
| nuclear_eclipse | paulr: bug 9856! | 15:39 |
| mantisbot | Bug 9856 - jreese - open - assigned | 15:39 |
| mantisbot | Implement method for tracking changes to Description, Steps to Reproduce, and Additional Info - http://www.mantisbt.org/bugs/view.php?id=9856 | 15:39 |
| paulr | aye | 15:39 |
| * paulr needs a break soon so will look then :) | 15:40 | |
| paulr | john: is 9856 sync'd with trunk ? | 15:42 |
| nuclear_eclipse | check git.mantisforge.org/w/mantisbt/jreese.git - that one is | 15:42 |
| paulr | looks to be out of date ;p | 15:43 |
| paulr | 45 hours agoPaul Richards | 15:43 |
| * paulr grins | 15:43 | |
| paulr | right lets see | 15:43 |
| paulr | changes for this are only in 12 files? | 15:44 |
| paulr | aka, I can just review http://git.mantisforge.org/w/mantisbt/jreese.git?a=treediff;h=refs/heads/revisions;hp=631dd84ba59f2159dc3f1ec7b6c08e380b01ce99;hb=revisions;hpb=631dd84ba59f2159dc3f1ec7b6c08e380b01ce99 ? | 15:44 |
| nuclear_eclipse | that's a diff from master to the revisions branch, correct? | 15:45 |
| paulr | yes | 15:46 |
| paulr | how do you undelete a file in git | 15:50 |
| paulr | nm | 15:52 |
| paulr | reset ;/ | 15:52 |
| paulr | is it FALSE or false ? | 15:55 |
| nuclear_eclipse | is what? | 15:56 |
| paulr | false :) | 15:56 |
| daryn | i prefer FALSE | 15:56 |
| nuclear_eclipse | it seems that Mantis tends to use null/false/true for most of the codebase... | 15:56 |
| paulr | http://pear.php.net/package/PHP_CodeSniffer/docs/latest/PHP_CodeSniffer/Generic_Sniffs_PHP_LowerCaseConstantSniff.html | 15:57 |
| paulr | Generic_Sniffs_PHP_LowerCaseConstantSniff. | 15:57 |
| paulr | Checks that all uses of true, false and null are lowerrcase. | 15:57 |
| paulr | to run | 15:57 |
| paulr | or not to run | 15:57 |
| nuclear_eclipse | I generally wouldn't really consider that a "code smell" though.... | 15:57 |
| paulr | Generic_Sniffs_PHP_UpperCaseConstantSniff. | 15:58 |
| paulr | Checks that all uses of TRUE, FALSE and NULL are uppercase | 15:58 |
| paulr | heh | 15:58 |
| * paulr tempted to run lowercse so it's consistent | 15:58 | |
| paulr | elseif or else if | 16:03 |
| nuclear_eclipse | else if | 16:06 |
| daryn | elseif | 16:07 |
| daryn | just to be contrary | 16:07 |
| nuclear_eclipse | 'else if' is easier to read | 16:09 |
| paulr | nuclear_eclipse: where's $p_event in formatting functions? | 16:10 |
| paulr | it's unused? | 16:10 |
| paulr | nuclear_eclipse: do we really want to use ERROR_GENERIC? | 16:14 |
| paulr | (at least, without specifying error_parsm | 16:15 |
| paulr | + switch( $t_revision['type'] ) { | 16:15 |
| paulr | + case REV_DESCRIPTION: | 16:15 |
| paulr | and dont we indent that by one | 16:15 |
| paulr | +html_page_top1( bug_format_summary( $t_bug_id, SUMMARY_CAPTION ) ); | 16:17 |
| paulr | +html_page_top2(); | 16:17 |
| paulr | should just call html_page_top now | 16:17 |
| nuclear_eclipse | $p_event should still be the first parameter to any hooked function | 16:17 |
| paulr | just it's not normally used? | 16:18 |
| nuclear_eclipse | paulr: if there's an ERROR_GENERIC, I'll fix that | 16:18 |
| paulr | $g_bug_revision_drop_threshold = MANAGER; | 16:18 |
| paulr | is/should there be a threshold to view previous revisions | 16:18 |
| nuclear_eclipse | don't think there should be, considering it was privy to anyone with access to see the bug in the first place... | 16:19 |
| paulr | you create a revision in bug_create - if so: | 16:19 |
| paulr | should we not create the first revision when editing for the first time | 16:19 |
| nuclear_eclipse | it does | 16:19 |
| paulr | i.e. atm, do you duplicate description on every insert? | 16:19 |
| nuclear_eclipse | basically "yes", although it's only a "duplicate" of the current description | 16:20 |
| paulr | so for the 'normal case' | 16:21 |
| paulr | i.e. user submits bug, doesn't edit it and we deal with bugnotes | 16:21 |
| paulr | do we store the bug data twice? | 16:21 |
| paulr | similarly, looking at update | 16:22 |
| paulr | + if ( bug_revision_count( $p_bug_id, REV_DESCRIPTION ) < 1 ) { | 16:22 |
| paulr | + $t_revision_id = bug_revision_add( $p_bug_id, $t_current_user, REV_DESCRIPTION, $t_old_data->description ); | 16:22 |
| paulr | + } | 16:22 |
| paulr | + if ( bug_revision_count( $p_bug_id, REV_DESCRIPTION ) < 1 ) { | 16:22 |
| paulr | + $t_revision_id = bug_revision_add( $p_bug_id, $t_current_user, REV_DESCRIPTION, $t_old_data->description ); | 16:22 |
| paulr | + } | 16:22 |
| paulr | that looks like you double up code? | 16:22 |
| * paulr is looking at diff at http://git.mantisforge.org/w/mantisbt/jreese.git?a=treediff;h=refs/heads/revisions;hp=631dd84ba59f2159dc3f1ec7b6c08e380b01ce99;hb=revisions;hpb=631dd84ba59f2159dc3f1ec7b6c08e380b01ce99 | 16:22 | |
| paulr | and thinking the bug_create stuff was supposed to have been deleted? | 16:23 |
| nuclear_eclipse | that code stores takes care of "grandfathering" in bugs that were created before the revision system was put in place | 16:23 |
| paulr | the update code? | 16:24 |
| paulr | (can't we always use that and not store a revision in bug_create? | 16:24 |
| paulr | bug_revision_drop is broken for multiple revisions | 16:26 |
| paulr | if ( REV_ANY < $p_type ) { | 16:27 |
| paulr | part of me thinks we could be using !== so when we end up adding another revision type later | 16:27 |
| nuclear_eclipse | man, it's really been a long time since I put this together... | 16:28 |
| paulr | aye | 16:28 |
| nuclear_eclipse | i'm having trouble remembering why I did certain things the way I did... | 16:28 |
| paulr | i've been using @return null for functions that dont return anything | 16:28 |
| paulr | + if ( $p_bugnote_id > 0 ) { | 16:29 |
| paulr | + $t_query .= ' AND bugnote_id=' . db_param(); | 16:29 |
| paulr | + $t_params[] = $p_bugnote_id; | 16:29 |
| paulr | + } else { | 16:29 |
| paulr | + $t_query .= ' AND bugnote_id=0'; | 16:29 |
| paulr | + } | 16:29 |
| paulr | looks fairly pointless | 16:29 |
| * paulr wonders what your actually trying to do for bugnote=0 | 16:29 | |
| paulr | should bug_revision_last return null or array() if empty? | 16:29 |
| paulr | you ad $t_raw = true; to history_localize_item - I *Thought* we had a seperate function to return *Raw* data, or by raw tdo you more mean 'nolinkified' | 16:34 |
| * paulr reaches end of file | 16:34 | |
| paulr | all i've not done is run it | 16:34 |
| nuclear_eclipse | paulr: raw = nolinks | 16:40 |
| nuclear_eclipse | bugnote=0 is for revision types not tied to a bugnote (summary, etc) | 16:43 |
| paulr | sure, but that code is the same | 16:44 |
| paulr | if (id > 0) { AND bugnote_id=id } else AND bugnote_id =0 | 16:44 |
| nuclear_eclipse | agreed it looks silly, it's just a habit trying to handle getting passed bugnote=-1 or some such | 16:45 |
| paulr | ahh ok | 16:45 |
| paulr | id=0+id | 16:45 |
| paulr | hm, no | 16:45 |
| paulr | right whatever; / | 16:45 |
| CIA-18 | Mantisbt: paul * r9aacdc6443ff / (34 files in 4 dirs): elseif -> else if | 16:46 |
| CIA-18 | Mantisbt: paul * r96a1579bcf7e / (23 files in 4 dirs): sizeof->count | 16:46 |
| * paulr pokes nuclear_eclipse for signs of life | 17:34 | |
| disrupt0wz | anyone knows how to make an issue to be automatic daily scheduled? | 17:43 |
| [KK]Kirill | paulr: ? | 18:13 |
| [KK]Kirill | one question: why need remove last tag http://git.mantisforge.org/w/mantisbt.git?a=commitdiff;h=b4cf7972d817fbcb7d45d038854b7b33dc90f076 | 18:13 |
| [KK]Kirill | Remove remaining closing tags | 18:13 |
| nuclear_eclipse | [KK]Kirill: the point of leaving off the closing tags is to prevent unintentional whitespace output | 18:14 |
| [KK]Kirill | thanks, John, I understand | 18:14 |
| paulr | nuclear_eclipse: http://www.mantisforge.org:8080/cruisecontrol/buildresults/mantisbt?tab=metrics | 18:17 |
| nuclear_eclipse | fancy | 18:17 |
| paulr | where'd we get to with 9856 ? | 18:17 |
| daryn | nice paulr | 18:19 |
| Roa | hi x) | 18:21 |
| Enisseo | hi everyone! | 19:09 |
| Enisseo | I've just finished some work on the graphic design of mantisbt | 19:10 |
| Enisseo | I thought the default design did not help understand and using it | 19:12 |
| Enisseo | so, if you are interested in what I've done, feel free to contact me ;) | 19:13 |
| paulr | oh?# | 19:17 |
| * daryn_away is away: Gone away for now | 19:24 | |
| Enisseo | [you can see it on: http://enisseo.net/mantisbt , login: test, password: test, does not work correctly on IE yet, hoping this message will not be seen as spam] | 19:28 |
| Enisseo | [tried to do so without altering too much html code - a few lines modified on the 1.1.6, only by editing the css file] | 19:30 |
| paulr | is that css ? | 19:32 |
| Enisseo | yes | 19:33 |
| paulr | any non-css changes? | 19:33 |
| Enisseo | no, minor changes to the html code | 19:33 |
| Enisseo | like... 5 .php files, 20 lines | 19:34 |
| Enisseo | mainly css classes added (example: <table class="width100"> => <table class="menu width100">) | 19:34 |
| Enisseo | and some "bugs" fixed (wrong colspan number, for example) | 19:35 |
| Enisseo | i'm not sure all pages work fine | 19:35 |
| nuclear_eclipse | Enisseo: problems like incorrect colspans should be reported as a bug on our official tracker please | 19:36 |
| Enisseo | i will ;) | 19:36 |
| paulr | nuclear_eclipse: 9856? :( | 19:37 |
| nuclear_eclipse | otherwise, I find a lot of your design visually distracting compared to the simplicity of the default theme | 19:37 |
| nuclear_eclipse | paulr: what about it? | 19:37 |
| paulr | well what we doing about it? | 19:37 |
| paulr | shall I fix? | 19:37 |
| Enisseo | nuclear_eclipse: any suggestion? | 19:37 |
| paulr | or what :) | 19:37 |
| nuclear_eclipse | last I heard from you, there was no definitive summary of what you thought needed to be changed | 19:37 |
| paulr | 1) we should only store a revision on the first change imo | 19:38 |
| Enisseo | [i have to be registered in order to post new issues?] | 19:38 |
| paulr | [yes] | 19:38 |
| paulr | I suspect that should be as simple as just removing 3 lines from bug_create and letting the legacy handler handle it | 19:39 |
| nuclear_eclipse | Enisseo: more subtlety; less contrast; since the arrows don't do anything, they are confusing; the text fields have no top border, so it's difficult to see where they "end" | 19:39 |
| paulr | nuclear_eclipse: you want to ban T_CLOSE_TAG T_INLINE_HTML T_OPEN_TAG sequences right? | 19:39 |
| paulr | (where trim T_INLINE_HTML = '') | 19:39 |
| nuclear_eclipse | basically, preg_replace_all( '/?>[\s\n]*<?php/', '' ) | 19:40 |
| nuclear_eclipse | paulr: other than deferring revisions from bug_create to only on bug_update, any other changes? | 19:41 |
| paulr | minor whitespace stuff i think | 19:41 |
| paulr | i'd need to run it | 19:41 |
| paulr | the other thing | 19:41 |
| paulr | localisation/history | 19:41 |
| paulr | iirc, you modified history in one place | 19:41 |
| paulr | I thought there was 2 loops history went into | 19:41 |
| paulr | aka a 'get raw data' | 19:42 |
| paulr | and 'get formatted data' | 19:42 |
| paulr | need to check it's just one | 19:42 |
| nuclear_eclipse | yeah, I handled that appropriately | 19:42 |
| paulr | ok | 19:42 |
| nuclear_eclipse | so just the bug_create issue? | 19:44 |
| paulr | that was the main thing that came out to me whilst looking at the diff | 19:44 |
| nuclear_eclipse | ok | 19:44 |
| paulr | if you've got a demo of it running | 19:44 |
| paulr | that could be nice | 19:44 |
| nuclear_eclipse | sorry, not off hand | 19:44 |
| nuclear_eclipse | I really should set up a public test installation on my server.... | 19:45 |
| paulr | (i'm assuming you've been sensible, so more looked at... | 19:45 |
| nuclear_eclipse | paulr: I just pushed a commit to my pub branch | 19:46 |
| nuclear_eclipse | I gotta run to class - if you can take the time to test the feature or post more feedback as a note on the bug, that'd be excellent, and I'd greatly appreciate it | 19:47 |
| paulr | (i'm right about that aren't i?) | 19:47 |
| nuclear_eclipse | cheers | 19:47 |
| paulr | cya | 19:47 |
| Enisseo | nuclear_eclipse: thank you, I do the modifications :) nice suggestions | 19:50 |
| mantisbot | New bug: Bug 10299 - enisseo - open - new | 20:15 |
| mantisbot | New bug: Invalid HTML - http://www.mantisbt.org/bugs/view.php?id=10299 | 20:15 |
| * daryn is back. | 20:30 | |
| Enisseo_ | is there a documentation about the status of an issue? | 20:35 |
| Enisseo_ | the "feedback" status, more precisely | 20:36 |
| paulr | yay | 20:57 |
| Enisseo_ | Can I change the $g_status_enum_string config variable without any risk? | 21:03 |
| paulr | in theory you should be able to | 21:03 |
| Enisseo_ | what does this variable mean, by the way? | 21:04 |
| Enisseo_ | '10:new,20:feedback,30:acknowledged,40:confirmed,50:assigned,80:resolved,90:closed' | 21:04 |
| Enisseo | enum values, I guess | 21:07 |
| Roa | :> | 21:22 |
| Roa | hey :) salut/hola/hello/ | 21:23 |
| Roa | i need help about mantis x:) | 21:23 |
| nuclear_eclipse | "Just Ask!" | 21:23 |
| * nuclear_eclipse points to /topic | 21:23 | |
| Roa | haha | 21:24 |
| Roa | ok ok | 21:24 |
| Roa | well i have problem whit mantis, when configure my smtps (my smtp server) in mantis | 21:25 |
| Roa | ##Send Email | 21:25 |
| Roa | $g_phpMailer_method = 2; | 21:25 |
| Roa | $g_SMTPAuth = true; | 21:25 |
| Roa | $g_smtp_host = 'mail.myhost.mx:465'; | 21:25 |
| Roa | $g_smtp_username = 'roa@myhost.com.mx'; | 21:25 |
| Roa | $g_smtp_password = 'qwerty1982'; | 21:26 |
| Roa | $g_smtp_connection_mode = 'ssl'; | 21:26 |
| Roa | [B... | 21:26 |
| Roa | the logs in my mail server is. | 21:26 |
| Roa | setting up TLS connection from unknown[189.149.186.60] | 21:27 |
| Roa | Apr 7 13:06:04 159395-web1 postfix/smtpd[99433]: SSL_accept error from unknown[189.149.186.60]: -1 | 21:27 |
| Roa | .. | 21:27 |
| nuclear_eclipse | the port number should not be be included in the host address | 21:27 |
| nuclear_eclipse | see $g_smtp_port | 21:28 |
| Roa | ok | 21:29 |
| Roa | im triying | 21:30 |
| paulr | nuclear_eclipse: wrote a test for ?><>? | 21:31 |
| Enisseo | how can I define a new milestone? | 21:31 |
| nuclear_eclipse | Enisseo: they're versions, and have to be defined when managing a project | 21:32 |
| Roa | mm nothing | 21:32 |
| Roa | :S | 21:32 |
| Roa | well they re proble whith phpmailer? | 21:33 |
| nuclear_eclipse | Roa: what version of Mantis are you using? | 21:33 |
| Roa | mantis]# pkg_info | grep mantis | 21:33 |
| Roa | mantis-1.1.6 A bug tracking system written in PHP. | 21:33 |
| Enisseo | nuclear_eclipse: I've defined a Version (manage/projects/myproject/versions/add version, but it does not appear in the roadmap section :S | 21:33 |
| slestak | anyone using soap + mantis + lighttpd? | 21:34 |
| nuclear_eclipse | hmm, I just realized that I was thinking of 1.2.x; 1.1.x doesn't yet have $g_smtp_port, and works with a much older version of phpmailer.... | 21:34 |
| nuclear_eclipse | Enisseo: you need to update bugs to set their target version before anything ever shows up on the roadmap | 21:34 |
| Roa | :> | 21:34 |
| Roa | well.. :S | 21:35 |
| nuclear_eclipse | Roa: also try downloading and installing Mantis directly from us | 21:35 |
| Roa | d'accord | 21:35 |
| Enisseo | nuclear_eclipse: yes, thanks :) | 21:36 |
| nuclear_eclipse | paulr: poke | 21:36 |
| Roa | the last version nuclear_eclipse ? | 21:36 |
| Roa | Download MantisBT 1.2.0a3 | 21:36 |
| nuclear_eclipse | 1.1.6 is the latest official, stable release | 21:37 |
| paulr | nuclear_eclipse: *SIGH* | 21:37 |
| nuclear_eclipse | hi paulr | 21:37 |
| paulr | lo | 21:37 |
| nuclear_eclipse | what you sighing about now? | 21:37 |
| nuclear_eclipse | and have you been able to test revisions yet? | 21:38 |
| paulr | <?php print_manage_user_sort_link( 'manage_user_page.php', lang_get( 'username' ), 'username', $c_dir, $c_sort, $c_hide, $c_filter ) ?> | 21:38 |
| paulr | <?php print_sort_icon( $c_dir, $c_sort, 'username' ) ?> | 21:38 |
| paulr | no | 21:38 |
| paulr | i've not | 21:38 |
| paulr | went to play wc3 | 21:38 |
| paulr | and only just came back | 21:38 |
| nuclear_eclipse | wc3 == warcraft III ? | 21:39 |
| paulr | yes | 21:42 |
| nuclear_eclipse | you play WoW at all? | 21:43 |
| paulr | nope | 21:43 |
| * nuclear_eclipse plays WoW on a private server w/ no monthly fee | 21:43 | |
| paulr | mm | 21:49 |
| paulr | server seems to have stopped logging errors :) | 21:49 |
| Roa | negative :>.. | 21:49 |
| Roa | nuclear_eclipse: | 21:49 |
| Roa | setting up TLS connection from unknown[189.149.186.60] | 21:50 |
| Roa | Apr 7 16:47:14 159395-web1 postfix/smtpd[5194]: SSL_accept error from unknown[189.149.186.60]: -1 | 21:50 |
| nuclear_eclipse | Roa: I guess my only other suggestion is to try the 1.2.x development releases, which use a newer version of PHPMailer... =\ | 21:50 |
| Roa | ok | 21:52 |
| paulr | nuclear_eclipse: what other rules do we want to enforce? | 21:53 |
| paulr | shall I just work my way through coding standards doc on mantsibt.org | 21:53 |
| nuclear_eclipse | paulr: after you test 9856 ;) | 21:54 |
| paulr | can i merge it into my thingie? | 21:55 |
| paulr | then just sign it off | 21:55 |
| nuclear_eclipse | what do you mean? | 21:55 |
| nuclear_eclipse | eg, you want to push 9856 yourself? | 21:55 |
| paulr | or more | 21:55 |
| paulr | I cba to reconfigure IIS ;p | 21:56 |
| Enisseo | bye, thanks for your help | 21:56 |
| paulr | so if i could import a patchset | 21:56 |
| paulr | in hg you can send changesets about | 21:56 |
| paulr | (did I mention hg before I forget) | 21:56 |
| nuclear_eclipse | oh, use `git format-patch master revisions` iirc to generate patch sets, and then use git-am to import them to a diff repo | 21:57 |
| paulr | could you generate the file from yours then? | 21:57 |
| paulr | that should keep history + ownership information right? | 21:57 |
| nuclear_eclipse | yeah | 21:57 |
| nuclear_eclipse | just a sec | 21:57 |
| nuclear_eclipse | paulr: http://mantis.pastebin.com/m32590715 | 21:59 |
| nuclear_eclipse | save that as a file, then do `git-am <file>` | 21:59 |
| paulr | still there john? | 22:16 |
| nuclear_eclipse | yep | 22:16 |
| paulr | lets see if this works then | 22:17 |
| paulr | ;0 | 22:17 |
| CIA-18 | Mantisbt: paul * rfbae2c2ea58a / (31 files in 2 dirs): Empty ?> <?php block can be removed. | 22:17 |
| paulr | $ git-am m32590715.txt | 22:17 |
| paulr | sh.exe": git-am: command not found | 22:17 |
| paulr | $ git am m32590715.txt | 22:18 |
| paulr | cat: c:/mantis/git/mantisbt/.git/rebase-apply/next: No such file or directory | 22:18 |
| paulr | previous rebase directory c:/mantis/git/mantisbt/.git/rebase-apply still exists | 22:18 |
| paulr | but mbox given. | 22:18 |
| nuclear_eclipse | ?! | 22:18 |
| nuclear_eclipse | `git version` | 22:18 |
| Roa | nuclear_eclipse: i think the bug is in the phpmailer | 22:18 |
| Roa | xD | 22:18 |
| paulr | 1.6.2.msysgit | 22:18 |
| nuclear_eclipse | hmm | 22:18 |
| nuclear_eclipse | paulr: try doing `git am --abort` or `git rebase --abort` | 22:19 |
| paulr | fatal: git apply: bad git-diff - expected /dev/null on line 35 | 22:21 |
| paulr | Patch failed at 0001 Base API and schema changes for tracking revisions to bug t | 22:21 |
| paulr | extarea fields. | 22:21 |
| paulr | hmm | 22:21 |
| nuclear_eclipse | I think your repo is borked? | 22:23 |
| paulr | nah | 22:23 |
| paulr | windows | 22:24 |
| nuclear_eclipse | set up a vhost on your mantisforge.org server | 22:24 |
| mantisbot | New bug: Bug 10300 - junior - open - new | 22:25 |
| mantisbot | New bug: Error in config_defaults_inc.php - http://www.mantisbt.org/bugs/view.php?id=10300 | 22:25 |
| paulr | wait, can't i just pull the changes from the reivsions head thing | 22:27 |
| nuclear_eclipse | should be able to | 22:27 |
| paulr | Applying: Base API and schema changes for tracking revisions to bug textarea fi | 22:31 |
| paulr | lds. | 22:31 |
| paulr | there we go | 22:31 |
| paulr | the timestamps are wrong | 22:38 |
| paulr | should you be able to delete all revisions? | 22:45 |
| nuclear_eclipse | yes, you should be able to delete, but how are the timestamps wrong? | 22:49 |
| nuclear_eclipse | paulr: *that's* why I was adding revisions in bug_create, so that they had the timestamp when the bug was created, not the timestamp of its first edit | 22:51 |
| paulr | should bug_revision_last | 22:53 |
| paulr | return | 22:53 |
| paulr | null | 22:53 |
| paulr | or | 22:53 |
| paulr | array() | 22:53 |
| paulr | when empty | 22:53 |
| nuclear_eclipse | I don't remember | 22:53 |
| paulr | i know what you do i mean | 22:54 |
| nuclear_eclipse | null means there was no last revision | 22:54 |
| paulr | does it make more sense to always return an array | 22:54 |
| paulr | and distinguish no revision with array() | 22:54 |
| paulr | or to return two different types | 22:54 |
| nuclear_eclipse | since the only thing being returned is a row, an empty array would be non-sensical IMO | 22:54 |
| paulr | nuclear_eclipse: http://mantis.pastebin.com/m4ab14a2 are my patches | 22:58 |
| nuclear_eclipse | what's the change to filtor_api for? | 23:06 |
| paulr | fix what i broke with my previous commit ;p | 23:11 |
| nuclear_eclipse | paulr: also, what's the point of putting teh parameter name in the phpdocs? | 23:11 |
| paulr | I thought you needed to | 23:11 |
| paulr | we do elsewhere | 23:12 |
| nuclear_eclipse | *you* do elsewhere ;) | 23:12 |
| paulr | hmm | 23:12 |
| nuclear_eclipse | I could be wrong, but I don't think you need it; the order of the @params should just match the order of the function arguments | 23:12 |
| paulr | http://manual.phpdoc.org/HTMLframesConverter/default/phpDocumentor/tutorial_sample2.pkg.html | 23:12 |
| paulr | the example there does | 23:12 |
| paulr | @param datatype $paramname description | 23:13 |
| paulr | @param datatype1|datatype2 $paramname description | 23:13 |
| nuclear_eclipse | hmm, well I think that's really stupid and redundant.... =\ | 23:13 |
| * paulr nods | 23:13 | |
| paulr | it's fucking annoying | 23:13 |
| nuclear_eclipse | have you tried generating phpdocs without the param names there? | 23:14 |
| paulr | iirc, yes | 23:14 |
| paulr | anyway, I added a (optional)timestamp to revision add | 23:14 |
| paulr | which I guess could deal with the problem of reivisons | 23:15 |
| paulr | having the wrong time | 23:15 |
| * paulr pokes nuclear_eclipse | 23:19 | |
| nuclear_eclipse | yeah | 23:20 |
| paulr | shall i commit my changes (timestamp+phpdoc) and push to trunk ? | 23:20 |
| nuclear_eclipse | I kind of prefer just inserting them directly at bug_create though... | 23:20 |
| nuclear_eclipse | so I assume you didn't find any problems with it in testing? | 23:22 |
| paulr | only my comment of shouly you be able to delete last revision | 23:25 |
| paulr | or the currently active reivision etc | 23:25 |
| nuclear_eclipse | hmm | 23:25 |
| paulr | [00:20:29] <nuclear_eclipse> I kind of prefer just inserting them directly at bug_create though... | 23:25 |
| paulr | my point is well | 23:25 |
| paulr | it's a hack ;p | 23:25 |
| nuclear_eclipse | why's that? | 23:25 |
| paulr | if you insert into 'current text table' + 'history table' every bug | 23:25 |
| paulr | we effectively double the size | 23:26 |
| nuclear_eclipse | disk space is cheap ;) | 23:26 |
| paulr | my expectation is v. few bugs change history | 23:26 |
| nuclear_eclipse | true | 23:26 |
| paulr | and you've been running this stuff at work haven't you for 6 month? | 23:27 |
| nuclear_eclipse | yep | 23:27 |
| nuclear_eclipse | granted, we don't yet officially use Mantis as our primary tracker, but it's been on our test installation | 23:27 |
| paulr | bug 9856 | 23:28 |
| mantisbot | Bug 9856 - jreese - open - assigned | 23:28 |
| mantisbot | Implement method for tracking changes to Description, Steps to Reproduce, and Additional Info - http://www.mantisbt.org/bugs/view.php?id=9856 | 23:28 |
| nuclear_eclipse | paulr: I'm going to push with your patch to phpdoc/API | 23:37 |
| paulr | ok - will it rebase fine at this end / | 23:38 |
| nuclear_eclipse | dunno | 23:38 |
| paulr | heh | 23:38 |
| paulr | atm. I have master, base api -john, then my filter api commit | 23:38 |
| paulr | :) | 23:38 |
| nuclear_eclipse | if anything, you can always cherry-pick the filter api commit onto the new master | 23:39 |
| paulr | there's still some stuff in 9856 we probably need to go through | 23:39 |
| paulr | -html_page_bottom1( __FILE__ ); | 23:39 |
| paulr | - | 23:39 |
| paulr | +html_page_bottom( __FILE__ ); | 23:39 |
| paulr | -html_page_top1( bug_format_summary( $t_bug_id, SUMMARY_CAPTION ) ); | 23:39 |
| paulr | -html_page_top2(); | 23:39 |
| paulr | +html_page_top( bug_format_summary( $t_bug_id, SUMMARY_CAPTION ) ); | 23:39 |
| paulr | did you also do thse? | 23:40 |
| nuclear_eclipse | right, should I wait to push then? | 23:40 |
| paulr | i'd say no | 23:40 |
| paulr | what i mean is | 23:40 |
| paulr | if you look through | 23:40 |
| nuclear_eclipse | I took everything in the patch you pasted, except for the filter_api changes | 23:40 |
| paulr | the html_page stuff wasn't in the stuff i pasted :) | 23:40 |
| nuclear_eclipse | then I don't have that | 23:40 |
| paulr | 6. Not directly related to this change, but the format of the issue note number used for added/edited is different from the one used in Make Private/Public in the Issue History box. | 23:41 |
| paulr | from victor | 23:41 |
| paulr | erm | 23:41 |
| Roa | hey nuclear_eclipse is a bug | 23:41 |
| Roa | of phpmailer | 23:41 |
| Roa | http://webomania.wordpress.com/2007/06/12/getting-phpmailer-to-connect-to-gmails-smtp-server/ | 23:41 |
| nuclear_eclipse | Roa: ok | 23:41 |
| Roa | $g_phpMailer_method = 2; | 23:42 |
| Roa | $g_SMTPAuth = true; | 23:42 |
| Roa | $g_smtp_host = 'ssl://mail.myhost.com:465'; | 23:42 |
| Roa | $g_smtp_username = 'roa@myhost.com'; | 23:42 |
| Roa | $g_smtp_password = 'qwerty'; | 23:42 |
| Roa | x) | 23:42 |
| paulr | nuclear_eclipse: but unless someone'sreally saying no | 23:42 |
| paulr | i'd say push | 23:42 |
| nuclear_eclipse | ok | 23:42 |
| paulr | personally, think it makes some sense | 23:42 |
| paulr | we should store changes for reasons you say (malicious) | 23:42 |
| paulr | bug_text/history aren't in the format for that | 23:43 |
| nuclear_eclipse | ok, so I'm go for pushing what I have? | 23:44 |
| nuclear_eclipse | I can always let you sort out the nitpicks afterwards, eh? :) | 23:45 |
| paulr | I guess | 23:45 |
| paulr | it's victor/glenn that raised points | 23:45 |
| paulr | but most of them seemed to be regarding bug_Text<>revision<>history | 23:45 |
| nuclear_eclipse | I meant your nits about page_top|bottom etc | 23:45 |
| paulr | and we are never going to sort *that* mess out | 23:45 |
| paulr | ;) | 23:45 |
| paulr | I mean, I wouldn't really want to tell users to run an upgrade script that moved all data out of bug_text into new_bug_text | 23:46 |
| nuclear_eclipse | yeah | 23:46 |
| paulr | we'd have to do something like | 23:47 |
| paulr | do one item at a time | 23:47 |
| nuclear_eclipse | *cough* categories! *cough* | 23:47 |
| nuclear_eclipse | :) | 23:47 |
| paulr | add to new table, | 23:47 |
| paulr | fetch from new table | 23:47 |
| paulr | wipe from old table | 23:47 |
| paulr | repeat for each of 3 columsn | 23:47 |
| paulr | for 10,000 bugs | 23:47 |
| nuclear_eclipse | yeah | 23:47 |
| paulr | and probably make a user click the mouse every 500 bugs to refresh the page so it does't time out | 23:48 |
| paulr | :) | 23:48 |
| nuclear_eclipse | hehe | 23:48 |
| nuclear_eclipse | ok, pushing | 23:48 |
| nuclear_eclipse | wait | 23:49 |
| nuclear_eclipse | gonna do a rebase to add #9856 to the commit messages | 23:49 |
| nuclear_eclipse | I just squashed all the commits together in the end :P | 23:53 |
| CIA-18 | Mantisbt: jreese * r678d8a168136 / (12 files in 4 dirs): Issue #9856: Implemented revision history for long textfields and bugnotes. | 23:53 |
| nuclear_eclipse | it's nice having CIA back in the loop :) | 23:55 |
| paulr | nn | 23:57 |
| paulr | think this just broke my repo though ;/ | 23:57 |
| nuclear_eclipse | paulr: that's why you're supposed to work in disposable branches ;) | 23:59 |
| paulr | nn | 23:59 |
| nuclear_eclipse | good night | 23:59 |
Generated by irclog2html.py