| ../irclogs/#mantishelp.2009-04-10.log | ||
| --- scribe started --- | 00:00 | |
| nuclear_eclipse | paulr: what file is that diff for? | 00:03 |
|---|---|---|
| nuclear_eclipse | and what does it do, other than the obvious? | 00:04 |
| paulr | the obvious | 00:14 |
| paulr | :) | 00:14 |
| nuclear_eclipse | hmm, I'm not sure I even understand the point of the obvious.... | 00:17 |
| paulr | I think i've done conversion | 00:20 |
| paulr | in mysql at least | 00:20 |
| paulr | $upgrade[] = Array( 'AddColumnSQL', Array( db_get_table( 'mantis_bug_table' ), " | 00:20 |
| paulr | date_submitted_intI UNSIGNED NOTNULL DEFAULT '1' " ) ); | 00:20 |
| paulr | $upgrade[] = Array( 'UpdateFunction', "date_migrate", array( 'mantis_bug_table', 'id', 'date_submitted', 'date_submitted_int' ) ); | 00:20 |
| paulr | $upgrade[] = Array( 'DropColumnSQL', Array( db_get_table( 'mantis_bug_table' ), "date_submitted" ) ); | 00:20 |
| paulr | $upgrade[] = Array( 'RenameColumnSQL', Array( db_get_table( 'mantis_bug_table' ), "date_submitted_int", "date_submitted", "date_submitted_intI UNSIGNED NOTNULL DEFAULT '1' " ) ); | 00:20 |
| nuclear_eclipse | that's a lot of schema changes to convert a column type | 00:21 |
| nuclear_eclipse | what happens if you 'ALTER COLUMN date_submitted INT UNSIGNED NOTNULL' ? | 00:22 |
| paulr | :) | 00:22 |
| paulr | dunno, works in mysql ;p | 00:22 |
| paulr | oh | 00:22 |
| paulr | how would that work ?:) | 00:23 |
| paulr | i'm pretty usre you can't just do that across all | 00:23 |
| nuclear_eclipse | well, I assume that most databases would store datetimes as some sort of INT type anyways, so I hoped maybe they'd be smart enough to be able to convert datetime->int | 00:23 |
| paulr | mysql> ALTER TABLE mantis_bug_table ALTER COLUMN due_date INTEGER; | 00:24 |
| paulr | ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that | 00:24 |
| paulr | corresponds to your MySQL server version for the right syntax to use near 'INTEG | 00:24 |
| paulr | ER' at line 1 | 00:24 |
| paulr | wrong syntax? | 00:24 |
| nuclear_eclipse | I don't remember what the alter column syntax is =\ | 00:25 |
| paulr | Msg 5074, Level 16, State 1, Line 1 | 00:26 |
| paulr | The object 'DF__mantis_bu__due_d__7C1A6C5A' is dependent on column 'due_date'. | 00:26 |
| paulr | Msg 4922, Level 16, State 9, Line 1 | 00:26 |
| paulr | ALTER TABLE ALTER COLUMN due_date failed because one or more objects access this column. | 00:26 |
| paulr | I just assumed/figured that datetime->int would generate whinging from adodb | 00:26 |
| nuclear_eclipse | sounds like a problem with an index perhaps? | 00:27 |
| nuclear_eclipse | but I could be wrong | 00:27 |
| nuclear_eclipse | I was just hoping for "simple" solution... =\ | 00:27 |
| bartik | sorry to intrude isn't it just simpler to do a SELECt UNIX_TIMESTAMP('due_date') FROM ... in PHP than to convert the whole datetime fields to int ? Most probably I have overlooked something then just ignore me. | 00:31 |
| paulr | mysql> ALTER TABLE mantis_bug_table CHANGE COLUMN due_date due_date INT; | 00:31 |
| paulr | ERROR 1265 (01000): Data truncated for column 'due_date' at row 1 | 00:31 |
| paulr | bartik: we support >mysql | 00:31 |
| paulr | mysql> ALTER TABLE mantis_bug_table MODIFY due_date INT; | 00:32 |
| paulr | ERROR 1265 (01000): Data truncated for column 'due_date' at row 1 | 00:32 |
| paulr | mysql> ALTER TABLE mantis_bug_table MODIFY due_date BIGINT; | 00:32 |
| paulr | ERROR 1265 (01000): Data truncated for column 'due_date' at row 1 | 00:32 |
| paulr | mysql> ALTER TABLE mantis_bug_table MODIFY due_date VARCHAR(80); | 00:32 |
| paulr | Query OK, 3725 rows affected (0.16 sec) | 00:32 |
| paulr | Records: 3725 Duplicates: 0 Warnings: 0 | 00:32 |
| paulr | nuclear_eclipse: and i'll guarantee one thing | 00:32 |
| paulr | if mysql whinges | 00:32 |
| paulr | pgsql/mssql will have a tantrum | 00:33 |
| paulr | oh | 00:33 |
| paulr | and you are right | 00:33 |
| paulr | [01:21:33] <nuclear_eclipse> that's a lot of schema changes to convert a column type | 00:33 |
| paulr | we probably need to drop index + create index too ;p | 00:33 |
| paulr | bb | 00:35 |
| paulr | nn | 00:35 |
| paulr | feel free to ocmment + mail ifyou have any better ideas ;0 | 00:36 |
| nuclear_eclipse | ok, goodnight | 00:36 |
| bartik | I suppose other databases support something like that too. Just a matter of a wrapper ? | 00:37 |
| nuclear_eclipse | bartik: it's more a matter of finding the simplest/best method within the constraits of Mantis+ADOdb method of schema versioning/upgrading | 00:39 |
| bartik | Yes I understand the difference between "Just works" and "Done right" :-) | 00:45 |
| dhx_m | nuclear_eclipse: I'm here now | 00:53 |
| nuclear_eclipse | dhx_m: you had ideas/questions about my Timecard plugin? | 01:36 |
| dhx_m | ah yes | 01:36 |
| dhx_m | basically what I'm looking for is a time tracking plugin which allows team members to keep track of how many hours of work they've contributed | 01:37 |
| dhx_m | with the following requirements: | 01:37 |
| dhx_m | * no forced time estimation (time tracking and time estimation are different) | 01:37 |
| nuclear_eclipse | right, that's one reason that a) it's not enforced, and b) it can be disabled altogether | 01:38 |
| dhx_m | * track time per developer per issue | 01:38 |
| dhx_m | * allow developers to modify the start/end time of each stint of work they perform on an issue | 01:39 |
| dhx_m | * generate reports (weekly time sheets, total time spent within a single project/category within a month, etc) | 01:39 |
| dhx_m | </ul> :) | 01:40 |
| nuclear_eclipse | well, 2 and 4 are doable simply by aggegrating the existing data | 01:41 |
| nuclear_eclipse | I'm not quite sure what you mean by 3... | 01:41 |
| dhx_m | 3 is meant to indicate that work is recorded as having a start and end time | 01:41 |
| dhx_m | and the user can modify that (ie. don't assume that when they add time to the mantis ticket, that the work has just been completed) | 01:42 |
| nuclear_eclipse | ah | 01:42 |
| dhx_m | maybe it was completed a week ago, for example, and they have forgotten to track their time | 01:42 |
| dhx_m | more importantly though I'm confused about the architecture of Timecard | 01:43 |
| dhx_m | do you track time against a "Timecard" | 01:43 |
| nuclear_eclipse | well, I gotta run out to the store, can we continue this topic tomorrow? | 01:43 |
| dhx_m | where a Timecard might be shared by multiple tickets? | 01:43 |
| dhx_m | sure | 01:43 |
| nuclear_eclipse | ok, cheers | 01:43 |
| dhx_m | thanks | 01:43 |
| dhx_m | cya | 01:44 |
| mantisbot | New bug: Bug 10317 - eunice - open - new | 05:19 |
| mantisbot | New bug: I just used mantis1.1.6, I found if update issue, will need 15sec, how can I improve it? - http://www.mantisbt.org/bugs/view.php?id=10317 | 05:19 |
| mantisbot | New bug: Bug 10318 - cigamit - open - new | 05:39 |
| mantisbot | New bug: Allow for forcing of complex passwords - http://www.mantisbt.org/bugs/view.php?id=10318 | 05:39 |
| dhx_m | 10318 sounds like a dupe | 05:53 |
| vb123 | hi dhx_m | 06:23 |
| vb123 | do you have the dupe issue id? If so, add a note. | 06:23 |
| dhx_m | ah sorry, I must have heard about it on IRC | 06:25 |
| dhx_m | I just remember reading somewhere a few days ago a request for that feature | 06:25 |
| dhx_m | I find it amusing that the DHS policy has forced password expiry | 06:27 |
| dhx_m | that is often considered bad security, because it forces people to use easier to remember passwords | 06:28 |
| mantisbot | New bug: Bug 10319 - prabhurangan - open - new | 08:55 |
| mantisbot | New bug: Revamp SVN integration with mantis 1.2.0a3? - http://www.mantisbt.org/bugs/view.php?id=10319 | 08:55 |
| [KK]Kirill | paulr: Hi | 10:18 |
| paulr | lo | 10:30 |
| [KK]Kirill | I forgot what I want :) | 10:42 |
| [KK]Kirill | I | 10:42 |
| [KK]Kirill | O | 10:42 |
| [KK]Kirill | Did MantisBT have rss for new issue? | 10:43 |
| [KK]Kirill | for examples mantisbot post new issue | 10:44 |
| [KK]Kirill | where they take this news? | 10:44 |
| paulr | there is some rss feed | 11:08 |
| paulr | i think mantisbot might use the soap api though | 11:08 |
| paulr | hi milliams | 11:08 |
| milliams | Hey paulr | 11:08 |
| paulr | whilst your tihnking of templates - have a look at 'quickskin' by the phpmailer guys | 11:09 |
| paulr | i've probably made your life slightly harder by having 2 weeks off | 11:09 |
| * paulr works @ uk school | 11:09 | |
| milliams | quickskin looks a lot like the way Smarty dos it | 11:11 |
| paulr | milliams: i've started playing with: http://www.mantisforge.org:8080/cruisecontrol/buildresults/mantisbt | 11:12 |
| milliams | Ahh, cruisecontrol. We used that when I was interning at Barclays Capital | 11:13 |
| mantisbot | New bug: Bug 10320 - prabhurangan - open - new | 11:45 |
| mantisbot | New bug: Add Progress Bar to roadmap for mantis 1.2.0a3? - http://www.mantisbt.org/bugs/view.php?id=10320 | 11:45 |
| paulr | milliams: so, how come you started looking at mantis? | 11:48 |
| milliams | paulr: Well I was looking around for a decent bug tracker for a project I'm involved with (http://thermite3d.org) and it seemed like every single bugtracker out there is lacking in some way | 11:49 |
| milliams | e.g. Trac can't have multiple projects, Nugzilla is _just_ bugtracking (no roadmap etc.) | 11:49 |
| milliams | *Bugzilla :) | 11:49 |
| milliams | But Mantis seemed to cover everyhing in a very simple but thorough way | 11:50 |
| milliams | Then I looked at the code and was pleasantly surprised at how easy to read it was in most places (despite not having done much PHP in a while) | 11:50 |
| milliams | And so I started 'scratching my itch' :) | 11:52 |
| * paulr nods | 11:57 | |
| paulr | you just chose an intersting area to start playing with | 11:57 |
| paulr | (personally, i dont really get the 'template' thing - /me wants email templates though | 11:58 |
| milliams | Heh, I guess I did | 12:01 |
| paulr | i'm trying to fix date handling atm ;/ | 12:03 |
| paulr | are you into 'testing' ? | 12:14 |
| nuclear_eclipse | "prabhurangan" makes me wish I could stab people through the internet..... | 12:43 |
| nuclear_eclipse | Summary 0010320: Add Progress Bar to roadmap for mantis 1.2.0a3? | 12:44 |
| paulr | nuclear_eclipse: review patch later? | 12:44 |
| paulr | :) | 12:44 |
| nuclear_eclipse | wtf? there already *is* a progress bar on the damn roadmap! | 12:44 |
| nuclear_eclipse | yeah, as soon as I get some time to eat breakfast... | 12:44 |
| * nuclear_eclipse is off today for Good Fridap | 12:45 | |
| nuclear_eclipse | Friday* | 12:45 |
| paulr | :) | 12:46 |
| paulr | i'm rapidly converting dates | 12:46 |
| paulr | :) | 12:46 |
| * paulr wonders what to do with db_helper_compare_days | 12:55 | |
| * nuclear_eclipse is done eating | 13:19 | |
| * paulr eats daryn | 14:02 | |
| paulr | nuclear_eclipse: how do you see it working | 14:09 |
| paulr | users choose their timezone? | 14:09 |
| nuclear_eclipse | I'd think the site admin selects a "default" timezone for the server, and users automatically inherit that, but can select a different timezone in their account prefs page | 14:11 |
| paulr | do you have a test instance there with some data in ? | 14:12 |
| paulr | can you try hitting /bug_graph_bystatus.php?show_table=true | 14:12 |
| nuclear_eclipse | I'm hitting max execution time on that.... | 14:15 |
| paulr | cool so it's not just me | 14:40 |
| paulr | :) | 14:40 |
| daryn | no...i think it's just you. I don't know what 'it' is but i'm sure it's just you. | 14:41 |
| paulr | shutup and plan time in an hour to review patch | 14:41 |
| daryn | hehe | 14:41 |
| daryn | after that comment? I'll review it all right | 14:41 |
| paulr | cool | 14:41 |
| mantisbot | New bug: Bug 10321 - diathesis - open - new | 14:41 |
| mantisbot | New bug: Real Name Validation Is Lame - http://www.mantisbt.org/bugs/view.php?id=10321 | 14:41 |
| paulr | daryn: then you can play with john's new friend | 14:42 |
| nuclear_eclipse | 10:10 < paulr> do you have a test instance there with some data in ? | 14:42 |
| nuclear_eclipse | 10:10 < paulr> can you try hitting /bug_graph_bystatus.php?show_table=true | 14:42 |
| nuclear_eclipse | 10:14 < nuclear_eclipse> I'm hitting max execution time on that.... | 14:42 |
| nuclear_eclipse | 10:18 - - daryn [n=daryn@76.79.4.2] has joined #mantishelp | 14:42 |
| nuclear_eclipse | 10:39 < paulr> cool so it's not just me | 14:42 |
| daryn | neato | 14:44 |
| daryn | pretty white page | 14:44 |
| paulr | do you have jpgraph installed? | 14:45 |
| nuclear_eclipse | well, that depends on how you have PHP configured :P | 14:45 |
| nuclear_eclipse | with it set to show errors, and with XDebug installed, it's a lot of error information :D | 14:45 |
| daryn | i don't think so | 14:45 |
| nuclear_eclipse | I know I don't.... | 14:46 |
| paulr | WOW | 14:47 |
| daryn | 10321 - nice bug | 14:47 |
| nuclear_eclipse | lol, I'd have to agree with it though... | 14:47 |
| nuclear_eclipse | that's one thing that's bugged me ever since I started working on Mantis... | 14:48 |
| daryn | no, it's just early implentation of a new global government tracking rule. Everyone has to have a unique name | 14:48 |
| dhx_m | lol @ 10321 | 14:49 |
| nuclear_eclipse | tell that to my local phonebook.... | 14:49 |
| paulr | $t_end = $t_interval->get_end_timestamp(); | 14:49 |
| paulr | $t_start = $t_interval->get_start_timestamp(); | 14:49 |
| nuclear_eclipse | there are 10+ John Reese entries in Cincinnati Ohio, and 3 in Rochester, NY | 14:49 |
| dhx_m | what do you need to test? | 14:49 |
| nuclear_eclipse | hi dhx_m | 14:49 |
| dhx_m | hey | 14:50 |
| paulr | for ($t_now = time() - $t_incr; $t_now >= $t_start; $t_now -= $t_incr) { | 14:50 |
| paulr | it loops | 14:50 |
| nuclear_eclipse | dhx_m: I'm available to chat about the plugin whenever you have the time | 14:50 |
| dhx_m | :) | 14:50 |
| dhx_m | I think we left last time on my question of "what is a time card" | 14:51 |
| paulr | for ( time() - 7*86400 >= false; -- | 14:51 |
| paulr | that's gonna be a billion loops right? | 14:51 |
| paulr | or well enough | 14:51 |
| nuclear_eclipse | dhx_m: I guess a good place to start is that Timecard is a combination of the needs of my employer, my personal needs for tracking time, and a superset of the existing time tracking capabilities already contained in Mantis | 14:53 |
| daryn | nuclear_eclipse...do you migrate existing timetracking to the plugin? | 14:53 |
| nuclear_eclipse | no, it currently makes the assumption that you're starting from scratch, but it should be capable of an import/migration process if time was taken to implement that | 14:54 |
| * paulr finds sledgehammer | 14:54 | |
| dhx_m | nuclear_eclipse: is the "time card" field (I notice it is optional) designed so that time can be tracked according to a project "cost code" or something of that nature? | 14:54 |
| nuclear_eclipse | right, so where I work (or I would assume a lot of places), depending on the task you're working on, there are different time card numbers that you can assign your time to, in order to charge your time to various departments or projects | 14:56 |
| dhx_m | ah hah :) | 14:56 |
| dhx_m | ok | 14:56 |
| paulr | do we require php5.1+ ? | 14:56 |
| nuclear_eclipse | so that field is just meant to track that value for each bug, with the ability to have a default value based on the project the bug is openen in | 14:57 |
| nuclear_eclipse | paulr: yes | 14:57 |
| dhx_m | in that case, wouldn't it be better to have an orthogonal field? | 14:57 |
| dhx_m | ie. drop down list? | 14:57 |
| nuclear_eclipse | well, in our case that dropdown would have about 5000 entries in it.... :P | 14:57 |
| dhx_m | oh, I see ;) | 14:58 |
| dhx_m | is there a reason why it is possible to anonymously track time with a ticket? | 14:58 |
| nuclear_eclipse | and also in our case, it's there more as a reference in certain cases, and isn't always used | 14:58 |
| dhx_m | ie. no author attached | 14:58 |
| paulr | nuclear_eclipse: how did you break timetracking :( | 14:58 |
| dhx_m | paulr: it still works fine, this is the Timecard plugin we're talking about | 14:59 |
| paulr | nah, "Get Time TRacking information" button comes up with an error :) | 14:59 |
| nuclear_eclipse | paulr: likely wasn't me ;) | 14:59 |
| paulr | A required parameter to this page (id) was not found. ;/ | 14:59 |
| paulr | i'm assuming it's something to do with forms stuff ;p | 15:00 |
| dhx_m | hmmm are you using the plugin paulr? | 15:00 |
| nuclear_eclipse | dhx_m: the only reason that it's "possible" to anonymously track time is because I have all the thresholds configurable | 15:00 |
| nuclear_eclipse | if you visit the plugin's configuration page via Manage Plugins, then you can set a bunch of options and thresholds | 15:00 |
| dhx_m | yep | 15:00 |
| paulr | dhx_m: no | 15:04 |
| dhx_m | I just realised the graph pages don't work with lots of categories | 15:04 |
| dhx_m | paulr: where is this button you speak of... I can't see it? | 15:06 |
| dhx_m | oh | 15:06 |
| nuclear_eclipse | dhx_m: you have to enable the core time tracking system | 15:06 |
| dhx_m | Billing | 15:06 |
| dhx_m | I have | 15:06 |
| dhx_m | the button works fine for me | 15:06 |
| dhx_m | well I think I get the hand of Timecard now | 15:15 |
| dhx_m | my only suggestion at the moment is to have an on/off toggle for the use of time cards | 15:16 |
| dhx_m | in addition to the threshold | 15:16 |
| nuclear_eclipse | there is, iirc | 15:16 |
| paulr | nuclear_eclipse: :( | 15:16 |
| paulr | this is turning into more hassle then I wanted ;/ | 15:16 |
| dhx_m | function update_bug_form( $p_event, $p_bug_id, $p_advanced ) { | 15:17 |
| dhx_m | if ( !access_has_bug_level( plugin_config_get( 'estimate_threshold' ), $p_bug_id ) ) { | 15:17 |
| dhx_m | isn't it only checking the threshold, and not the value of 'use_timecard'? | 15:17 |
| dhx_m | doh | 15:17 |
| dhx_m | forget that | 15:18 |
| dhx_m | I am mistaken | 15:18 |
| dhx_m | I was trying to talk about estimation, not time cards | 15:18 |
| dhx_m | there is an estimation threshold, but not an on/off | 15:18 |
| nuclear_eclipse | hmm | 15:18 |
| dhx_m | use_updates and use_timecard are the only on/off settings | 15:19 |
| nuclear_eclipse | ah | 15:19 |
| paulr | Revision 2009-04-10 16:14 by administrator | 15:19 |
| dhx_m | in my project, we tend to only track time per project/category | 15:19 |
| paulr | is it supposed to show time there? | 15:19 |
| nuclear_eclipse | ok, so implement an on/off switch and I'll merge it in :) | 15:19 |
| dhx_m | ok | 15:19 |
| dhx_m | also, are there plans for a page that creates time tracking reports/exports? | 15:20 |
| dhx_m | or is that also free game to try out? | 15:20 |
| nuclear_eclipse | eventually, but it's low-priority for me at the moment, so if you want to help out with that too, go right ahead :) | 15:20 |
| nuclear_eclipse | dhx_m: basically, most of what I get to work on is for my employer, so they tend to be the one's setting priorities, and atm, the priorities are on implementing features in other plugins that are important for our impending migration to Mantis | 15:22 |
| dhx_m | nuclear_eclipse: yep, I don't want to sound like I'm pressuring you :) | 15:23 |
| dhx_m | nuclear_eclipse: basically I just want to ensure I'm not going to duplicate anything that is already in development | 15:23 |
| nuclear_eclipse | then no, I probably wouldn't be getting to that for a month or two | 15:23 |
| dhx_m | ok | 15:25 |
| dhx_m | I'll see what I can do | 15:25 |
| dhx_m | gtg for now, thanks for your help :) | 15:25 |
| nuclear_eclipse | dhx_m: real fast | 15:25 |
| nuclear_eclipse | if you want a place to track your progress, feature requests, etc for my plugins, sign up at http://leetcode.net/mantis - that's where I'm tracking most of the stuff I'm working on beyond the scope of work | 15:26 |
| dhx_m | great, thanks :) | 15:28 |
| dhx_m | I was wondering where tickets for plugins were meant to be posted | 15:28 |
| dhx_m | (I know this is just for your plugins btw) | 15:28 |
| nuclear_eclipse | I really should put together some readmes saying where to post bugs, but takes effort :P | 15:29 |
| dhx_m | yep :) | 15:30 |
| paulr | right | 15:30 |
| paulr | I think | 15:30 |
| paulr | how do I push a brnahcn again | 15:31 |
| daryn | a new branch to mantisforge? | 15:31 |
| paulr | git push ssh://paul@git.mantisforge.org/mantisbt/paul.git dates:dates ? | 15:31 |
| daryn | don't you have paul set up as a remote repo? | 15:32 |
| nuclear_eclipse | that, or you could create a named remote first, eg `git remote add pub ssh://paul@git.mantisforge.org/mantisbt/paul.git` and then do `git push pub dates:dates` | 15:32 |
| paulr | http://git.mantisforge.org/w/mantisbt/paul.git?a=shortlog;h=refs/heads/dates | 15:34 |
| paulr | feedback on patch pls guys ;) | 15:34 |
| daryn | it's big | 15:36 |
| paulr | not really | 15:36 |
| paulr | I need to test the conversion on mssql/pgsql | 15:36 |
| paulr | before doing anything else | 15:37 |
| paulr | daryn: thanks for volunteering to review this one though, it's really appreciated. | 15:37 |
| daryn | good lord... | 15:38 |
| paulr | [15:41:51] <daryn> after that comment? I'll review it all right | 15:38 |
| daryn | could we perhaps do a function that dumps the data to a temp table, alter the necessary fields and then load the data back in? those table changes are ugly! | 15:39 |
| paulr | who wants to bet the db scripts fail in mssql and pgsql | 15:39 |
| paulr | daryn: more likely to break i'd have thought | 15:40 |
| daryn | how? seems simpler to me | 15:40 |
| paulr | I doubt adodb does temp tables | 15:40 |
| paulr | I suspect different db's handle temp tables in different ways | 15:41 |
| paulr | we'd need to do a select into type thing (which we might be able to do already) | 15:41 |
| paulr | and we need to convert from datetime string to a int | 15:41 |
| daryn | you're doing that anway | 15:42 |
| paulr | yes, but what i mean is | 15:42 |
| paulr | the syntax to case datetime -> int will be different in different db's | 15:42 |
| daryn | i'm talking about a php function not a stored procedure | 15:43 |
| daryn | wait...i'm too tired | 15:44 |
| daryn | i forget the temp tables are only accessible during the sql session | 15:44 |
| paulr | BAD | 15:44 |
| paulr | ALTER TABLE mantis_bug_table DROP CONSTRAINT | 15:44 |
| paulr | [Microsoft][SQL Server Native Client 10.0][SQL Server]The object 'DF__mantis_bu__date___29572725' is dependent on column 'date_submitted'. | 15:44 |
| * paulr sighs | 15:44 | |
| daryn | do we not have a better error than ERROR_GENERIC? | 15:51 |
| nuclear_eclipse | daryn: for what? | 15:51 |
| daryn | paulr's patch...an invalid date error | 15:51 |
| paulr | daryn: that should never get hit :) | 15:52 |
| paulr | if that's in bug_update | 15:52 |
| paulr | erm, set_field | 15:53 |
| daryn | famous last words | 15:55 |
| daryn | why are we using 86400 throughout? should it be a constant? at least one place is 864000 | 15:57 |
| daryn | and why do we have a function that does nothing except return 1? | 15:58 |
| nuclear_eclipse | because who knows when the value of 1 might change? | 15:59 |
| daryn | right... | 16:00 |
| daryn | paulr? | 16:02 |
| paulr | never | 16:14 |
| paulr | :) | 16:15 |
| daryn | so...<daryn> why are we using 86400 throughout? should it be a constant? at least one place is 864000 | 16:16 |
| daryn | <daryn> and why do we have a function that does nothing except return 1? | 16:16 |
| paulr | I edited old function | 16:16 |
| paulr | i've not yet review due_Date | 16:16 |
| paulr | and yes, we probably should have a constant | 16:16 |
| daryn | ok | 16:16 |
| paulr | any suggestions on constant name? | 16:18 |
| daryn | A_DAY_IN_SECONDS | 16:18 |
| paulr | DAYSSECONDS | 16:50 |
| nuclear_eclipse | ONE_DAY > *SECONDS* | 16:51 |
| * daryn_away is away: Gone away for now | 17:22 | |
| * daryn is back. | 17:23 | |
| paulr | so ONE_DAY / | 17:38 |
| * paulr sighs loudly | 17:42 | |
| * paulr hates mssql | 17:42 | |
| * paulr hates mssql more | 17:42 | |
| * paulr hates adodb more | 17:42 | |
| paulr | daryn: any other review comments | 17:46 |
| paulr | did I break anything? | 17:47 |
| paulr | BAD | 17:47 |
| paulr | ALTER TABLE mantis_bug_revision_table DROP CONSTRAINT DF__mantis_bu__times__39237A9A | 17:47 |
| paulr | [Microsoft][SQL Server Native Client 10.0][SQL Server]The index 'idx_bug_rev_id_time' is dependent on column 'timestamp'. | 17:47 |
| paulr | oh ffs | 17:47 |
| * paulr slaps john | 17:47 | |
| paulr | oh hmm | 17:50 |
| daryn | nuclear_eclipse, paulr got time for a short patch check? | 18:54 |
| daryn | 5 | 19:04 |
| daryn | 4 | 19:04 |
| daryn | 3 | 19:04 |
| daryn | 2 | 19:05 |
| daryn | last chance... | 19:05 |
| daryn | 1 | 19:05 |
| CIA-11 | Mantisbt: daryn * ra0ff52e3a11f / (3 files in 3 dirs): =Implement bug 4723, display issues I've added notes to in a my view box | 19:11 |
| mantisbot | Bug 4723 - kgrubbs - open - assigned | 19:11 |
| mantisbot | Add new capability to "My View".... "Issues I've added Notes To" - http://www.mantisbt.org/bugs/view.php?id=4723 | 19:11 |
| paulr | daryn: sure | 19:19 |
| daryn | too late | 19:19 |
| paulr | how you getting on with my patch? | 19:20 |
| daryn | it was small anyway | 19:20 |
| paulr | can i push ? | 19:20 |
| daryn | i think i made all the comments I need to. | 19:20 |
| * paulr doesn't think daryn with thourough | 19:20 | |
| paulr | :P | 19:20 |
| daryn | why, did you want me to spend hours on it? | 19:21 |
| paulr | no | 19:21 |
| paulr | wanted you to test it properly though :P | 19:21 |
| daryn | :P | 19:21 |
| daryn | you didn't say test it | 19:22 |
| daryn | you said look at the patch | 19:22 |
| daryn | hang on...i'll run it | 19:24 |
| paulr | wait | 19:25 |
| paulr | WAIT | 19:25 |
| paulr | WAIT | 19:25 |
| paulr | WAIT | 19:25 |
| paulr | WAIT | 19:25 |
| daryn | k... | 19:26 |
| paulr | mssql works | 19:27 |
| paulr | let me test pgsql | 19:27 |
| daryn | do you have an updated version? mantisforge doesn't show using constant | 19:27 |
| paulr | right, schema updates I think i've not fixed | 19:28 |
| paulr | let me push | 19:28 |
| paulr | [17:18:59] <daryn> A_DAY_IN_SECONDS | 19:28 |
| paulr | [17:50:46] <paulr> DAYSSECONDS | 19:28 |
| paulr | [17:51:06] <nuclear_eclipse> ONE_DAY > *SECONDS* | 19:28 |
| paulr | did we conclude a name? | 19:29 |
| daryn | i was just being silly | 19:29 |
| daryn | name it whatever makes sense | 19:29 |
| daryn | btw... i noticed you also have 86399 in the code too... | 19:29 |
| daryn | what's up with that | 19:29 |
| paulr | 23:59:59 | 19:30 |
| daryn | so...what are you going to name that? ONE_SECOND_LESS_THAN_A_DAY? | 19:32 |
| daryn | MIDNIGHT_MINUS_ONE | 19:32 |
| daryn | hm...i just realized you're going to break my local customizations with this | 19:33 |
| paulr | doubt it | 19:33 |
| daryn | nope | 19:33 |
| daryn | i do a bunch of reports and stuff with dates | 19:33 |
| paulr | it's easy thoughto fix | 19:34 |
| daryn | so i'll have to account for the new field data | 19:34 |
| daryn | sure. it's just one more thing | 19:34 |
| paulr | wtf does view_all_Set do | 19:34 |
| paulr | $t_one_day = 86399; | 19:34 |
| paulr | and then: | 19:34 |
| paulr | case CUSTOM_FIELD_DATE_BETWEEN: | 19:34 |
| paulr | $t_start = $t_start_date; | 19:34 |
| paulr | $t_end = $t_end_date + $t_one_day - 1; | 19:34 |
| daryn | it is the post page for view_all_bugs_page | 19:35 |
| paulr | $t_one_day = day - 1 | 19:35 |
| paulr | then when we use it | 19:35 |
| paulr | we take 1 off too | 19:35 |
| paulr | ? | 19:35 |
| daryn | sets up the filter params and queries | 19:35 |
| daryn | seems odd | 19:35 |
| paulr | so it's SECONDS_PER_DAY-2 | 19:35 |
| daryn | no...start and end are set to 1 | 19:36 |
| daryn | not zero | 19:36 |
| daryn | weird | 19:36 |
| daryn | so, there's your two seconds | 19:36 |
| paulr | right, pushed dates | 19:37 |
| paulr | again | 19:37 |
| daryn | do i have rights to your repo? | 19:38 |
| paulr | ? | 19:38 |
| paulr | you should be able to pull no? | 19:38 |
| daryn | prolly | 19:38 |
| paulr | or do you need rights to pull | 19:38 |
| daryn | just been awhile since i set up a remote | 19:38 |
| paulr | i'm tempted to make /admin/install.php go to /admin/check.php | 19:40 |
| nuclear_eclipse | all the mantisforge repos are available to anyone as read-only via git:// URL | 19:40 |
| paulr | nuclear_eclipse: can you have a look at my dates branch | 19:40 |
| nuclear_eclipse | in a short bit | 19:40 |
| * nuclear_eclipse just got back home | 19:40 | |
| daryn | heh | 19:44 |
| daryn | Fatal error: Allowed memory size of 67108864 bytes exhausted | 19:44 |
| daryn | how much memory does that need? | 19:44 |
| daryn | 128MB is not enough... | 19:47 |
| daryn | 256MB is not enough... | 19:52 |
| bartik | what is the minimum php version supported by mantis ? | 20:08 |
| daryn | http://www.mantisbt.org/requirements.php | 20:14 |
| bartik | daryn: thanks. as a reward have a look at a curious code snippet in file_api.php there you can see a clever way how to reimplement "pathinfo($p_filename, PATHINFO_EXTENSION)" in the function file_get_extension. | 20:18 |
| daryn | where? | 20:20 |
| daryn | hm...paulr is the one who messes with phpmailer regularly | 20:24 |
| daryn | bartik you have to remember...some of this code is ancient :) | 20:35 |
| bartik | I work on it a bit. | 20:48 |
| daryn | nuclear_eclipse there? | 20:50 |
| nuclear_eclipse | somewhat | 20:50 |
| daryn | could you take a quick look at the patch on 7205 and see if that seems an appropriate use of _SESSION? | 20:51 |
| daryn | it's short | 20:51 |
| nuclear_eclipse | no, it should use the new session_api if it's trying to do something like that | 20:53 |
| daryn | ok. i knew you would have an opinion on it :) | 20:53 |
| nuclear_eclipse | and the use of 'ON' and 'OFF' instead of ON and OFF is annoying, as is the one-line if else block | 20:54 |
| daryn | right, i would change both of those | 20:54 |
| nuclear_eclipse | beyond that, I'm not quite sure that's the best method of achieving that sort of behavior, but I could be misunderstanding the problem | 20:55 |
| daryn | yeah...i'm not sure either. it's just been sitting there for awhile and I havent had time to look into it more | 20:56 |
| paulr | [20:44:30] <daryn> Fatal error: Allowed memory size of 67108864 bytes exhausted | 20:59 |
| paulr | [20:45:00] <daryn> how much memory does that need? | 20:59 |
| paulr | [20:47:43] <daryn> 128MB is not enough... | 20:59 |
| paulr | [20:52:28] <daryn> 256MB is not enough... | 20:59 |
| paulr | hmm? | 20:59 |
| daryn | trying to run the db upgrade...haven't made it through yet | 20:59 |
| paulr | oh do i leak ram? | 20:59 |
| daryn | it's running out of memory | 20:59 |
| daryn | it's going somewhere | 21:00 |
| paulr | out of intreest | 21:00 |
| paulr | how many bugs you have? | 21:00 |
| daryn | 29000+ | 21:01 |
| paulr | hmm | 21:01 |
| nuclear_eclipse | lol | 21:02 |
| paulr | ? | 21:02 |
| paulr | right, fine, will do it another way | 21:02 |
| paulr | hmm :) | 21:02 |
| paulr | daryn: is that a test db ? | 21:03 |
| daryn | ya | 21:03 |
| daryn | sort of | 21:03 |
| daryn | it's a copy of live...why? | 21:03 |
| paulr | let me do it a different way | 21:05 |
| daryn | ok | 21:05 |
| paulr | I just can't test as my db's are too small | 21:05 |
| daryn | i should install xdebug...maybe that would help | 21:05 |
| paulr | no | 21:05 |
| paulr | give me 30 mintues or so | 21:11 |
| daryn | k | 21:11 |
| daryn | paulr i'm out probably for the evening if not the whole weekend | 21:58 |
Generated by irclog2html.py