| ../irclogs/#mantishelp.2009-05-17.log | ||
| --- scribe started --- | 00:00 | |
| mantisbot | New bug: Bug 10492 - Exa_Ankur - open - new | 07:06 |
|---|---|---|
| mantisbot | New bug: Specific description makes bug view page slow and displays without showing the description - http://www.mantisbt.org/bugs/view.php?id=10492 | 07:06 |
| dhx_m | paulr: I'll try out dates3 now :) | 08:42 |
| dhx_m | upgrade was fine | 09:03 |
| dhx_m | just some minor points so far: | 09:03 |
| dhx_m | 1) in user prefs (account_prefs_page) the string is "TimeZone"... it'd be better to make this "Time Zone" with a space | 09:04 |
| dhx_m | 2) the list of possible timezones for Australia (I haven't really checked others) contains some options that seem incorrect (NSW, LHI, South, West, North) and I'm not entirely sure all of those cities are required either | 09:05 |
| giallu | dhx_m, hi. where's this branch? | 09:08 |
| dhx_m | further on (2): what source are you using? is it possible to force/strongly suggest the user install the PECL timezonedb extension at http://pecl.php.net/package/timezonedb for more accurate/up-to-date timezone information? | 09:10 |
| dhx_m | giallu: I'm testing the latest snapshot from http://git.mantisforge.org/w/mantisbt/paul.git?a=shortlog;h=refs/heads/dates3 | 09:10 |
| dhx_m | paulr: actually maybe don't force the PECL timezonedb, but include prominently in installation documentation that if they don't upgrade their PHP version frequently (most don't), daylight savings changes won't be propagated to their Mantis install | 09:12 |
| dhx_m | it'd be better to use the version bundled with PHP (assuming they keep it up to date of course) rather than use the PECL timezonedb extension | 09:12 |
| dhx_m | paulr: see http://en.wikipedia.org/wiki/List_of_zoneinfo_time_zones for a list of timezones I was expecting to see in the list | 09:13 |
| giallu | dhx_m, or maybe this http://unicode.org/cldr/data/diff/supplemental/territory_containment_un_m_49.html ? | 09:21 |
| dhx_m | same thing I think... but the zoneinfo source is much better than coding it yourself :) | 09:26 |
| dhx_m | it is used in most software... so I guess it is the standard | 09:27 |
| giallu | dhx_m, sure | 09:28 |
| giallu | I'm not really volunteering for duplicating someone's else work :) | 09:28 |
| dhx_m | :) | 09:30 |
| dhx_m | nuclear_eclipse: mantis_plugin_Source_changeset_table.timestamp and mantis_plugin_Timecard_update_table.timestamp would need to be upgraded | 09:33 |
| dhx_m | paulr: 3) mantis_sponsorship_table.date_submitted and mantis_sponsorship_table.last_updated are stillusing datetime for me | 09:34 |
| * giallu leaving | 09:34 | |
| CIA-31 | Mantisbt: giallu * r9c10272bf0a0 /core/email_api.php: Bring back explicit phpmailer require | 09:35 |
| CIA-31 | Mantisbt: giallu * r0d2e41faf00d / (core.php core/email_api.php tests/TestConfig.php): Add php_include path initialization code | 09:36 |
| CIA-31 | Mantisbt: giallu * r0a936c603b21 /core/email_api.php: Now PHPMAILER_PATH is not needed anymore | 09:36 |
| CIA-31 | Mantisbt: giallu * ra7f7616ef7c8 / (8 files in 2 dirs): Move disposable to library | 09:36 |
| CIA-31 | Mantisbt: giallu * r847c3522bb91 / (120 files in 12 dirs): Move phpmailer to library/ | 09:36 |
| CIA-31 | Mantisbt: giallu * r18acbd014f14 /core/email_api.php: And add back the require for disposable.php | 09:36 |
| CIA-31 | Mantisbt: giallu * r0ebee35f36b0 / (28 files in 4 dirs): Move rssbuilder to library/ | 09:36 |
| CIA-31 | Mantisbt: giallu * r5cc93855e6d5 / (core.php issues_rss.php news_rss.php): Adapt stuff using RSSBuilder to new library location | 09:36 |
| giallu | but before, ket's break something... | 09:36 |
| CIA-31 | Mantisbt: giallu * r820c5736010a /library/README.libs: Add README for 3rd party libs tracking purposes | 09:36 |
| dhx_m | lol | 09:36 |
| giallu | I will try to come back later and hear the complaints | 09:36 |
| giallu | cheers | 09:36 |
| dhx_m | haha cya :) | 09:37 |
| dhx_m | paulr: 4) use of time zone abbreviation seems inconsistent... example> manage_proj_edit_page has the timezone abbreviation for the timestamp of each version, these abbreviations don't appear on manage_user_page however | 09:41 |
| dhx_m | also on 4) maybe it is best to drop all mention of the timezone abbreviation except for the current time shown at the top of each page, and emails? (note that comments within emails also don't show an abbreviation... but I don't think they should anyway) | 09:42 |
| dhx_m | paulr: 5) date filters seem to be broken for me? (it shows nothing when I set a date filter within "All projects" to yesterday (16th) - tomorrow (18th) | 09:43 |
| dhx_m | on 5) I have created a ticket today (on the 17th) and it doesn't show with any filter setting I've tried (and all the other filter settings are set to "any", so there is no reason the filter shouldn't be returning the bug I created today) | 09:44 |
| dhx_m | otherwise I can't seem to find any other problems at the moment | 09:53 |
| dhx_m | :) | 09:55 |
| paulr | cool | 09:58 |
| paulr | re 2 | 10:04 |
| paulr | i'm using the stuff in php like http://uk2.php.net/manual/en/function.timezone-identifiers-list.php | 10:05 |
| paulr | http://uk2.php.net/manual/en/timezones.php | 10:05 |
| paulr | Australia | 10:05 |
| paulr | Australia/ACTAustralia/AdelaideAustralia/BrisbaneAustralia/Broken_HillAustralia/Canberra | 10:05 |
| paulr | Australia/CurrieAustralia/DarwinAustralia/EuclaAustralia/HobartAustralia/LHI | 10:05 |
| paulr | Australia/LindemanAustralia/Lord_HoweAustralia/MelbourneAustralia/NorthAustralia/NSW | 10:05 |
| paulr | Australia/PerthAustralia/QueenslandAustralia/SouthAustralia/SydneyAustralia/Tasmania | 10:05 |
| paulr | Australia/VictoriaAustralia/WestAustralia/Yancowinna | 10:05 |
| paulr | I believe i've ignored the ones that php say not to use | 10:07 |
| paulr | aka http://uk2.php.net/manual/en/timezones.others.php | 10:07 |
| dhx_m | hmmm that's odd, do you get Australia/South and Australia/NSW showing in the list on your local install? | 10:08 |
| paulr | I'd expect so as it's listed at http://uk2.php.net/manual/en/timezones.australia.php | 10:09 |
| dhx_m | oh | 10:09 |
| dhx_m | seems that is PHP's crap timezone data then :) | 10:09 |
| paulr | 3 - your probably right | 10:12 |
| paulr | 4 - need to look at | 10:13 |
| paulr | 4b - probably need to look at ;p | 10:13 |
| paulr | 5 - will check out | 10:13 |
| devnet | I have a workflor/group question... | 15:22 |
| devnet | If I wanted to add a state that an issue can enter after closure | 15:23 |
| devnet | say.. "documentation state" | 15:23 |
| devnet | where after you close the issue, it kicks over into "document" and is auto assigned to a documenation group | 15:23 |
| devnet | how would I go about adding that workflow/custom state/group? | 15:23 |
| nuclear_eclipse | devnet: either a custom function, or a plugin hooking the bug_update event | 15:37 |
| devnet | nuclear_eclipse: cool, I'll research :D | 15:38 |
| paulr | lo nuclear_eclipse | 18:59 |
| paulr | dhx_m: lurking? | 22:03 |
| paulr | dhx_m: re 4b, isn't that what we already do???? | 22:23 |
| paulr | right | 22:47 |
| paulr | I guess I should go to bed and wait complaints :) | 22:47 |
| paulr | nn! | 22:47 |
| CIA-31 | Mantisbt: paul * r51051c75143a / (41 files in 5 dirs): Convert DateTimes in database to integer types. | 22:47 |
| CIA-31 | Mantisbt: paul * r756deda9f990 /admin/schema.php: recreate index, and fix installer for removal of db_now | 22:47 |
| CIA-31 | Mantisbt: paul * re2b4feeffed9 /admin/install_functions.php: Disable query logging (if enabled) during potentially long processes to avoid out of memory errors (due to constructing large arrays in database_api of queries) | 22:47 |
| CIA-31 | Mantisbt: paul * rfcf225e15071 / (8 files in 2 dirs): Add Seconds_per_day constant | 22:47 |
| CIA-31 | Mantisbt: paul * rc5e4a3afe052 /core/adodb/datadict/datadict-mssql.inc.php: Fix adodb for mssql again | 22:47 |
| CIA-31 | Mantisbt: paul * rd26d7cf6e8d7 /core/config_api.php: Fix bug in config_set_global - we need to clear the cache else config changes by this function do not take affect. | 22:47 |
| CIA-31 | Mantisbt: paul * ra058e7596193 / (9 files in 4 dirs): Add initial timezone selection functionality | 22:47 |
| CIA-31 | Mantisbt: paul * rb06b0108d7a3 /admin/ (install_functions.php schema.php): Reduce number of queries required for the data conversion | 22:47 |
| CIA-31 | Mantisbt: paul * rbe5750575399 /core/database_api.php: We only need to check db type once. | 22:47 |
| CIA-31 | Mantisbt: paul * rdff6ab48f48d /core/user_pref_api.php: TODO: move this to somewhere sensible. | 22:47 |
| CIA-31 | Mantisbt: paul * ref9df166bc01 / (5 files in 2 dirs): tweak how we handle user preferences | 22:47 |
| CIA-31 | Mantisbt: paul * r52102cd35fb6 /core/helper_api.php: user_pref_get should be used outside of userpref api. By default if prefreneces do not exist, a new object is returned. | 22:47 |
| CIA-31 | Mantisbt: paul * r4f0fd58c900d /core/logging_api.php: Add support for logging to Firebug ( http://www.firephp.org/ ) as logging method. | 22:47 |
| CIA-31 | Mantisbt: paul * r009313dc9da6 /account_prefs_inc.php: move timezone dropdown to correct location | 22:48 |
| CIA-31 | Mantisbt: paul * r6b0c8062e02c /core/email_api.php: Only load phpmailer if we are sending email. This saves memory + cpu for every page hit | 22:48 |
| CIA-31 | Mantisbt: paul * r656e3c31ef49 /core/database_api.php: Dont allow plugins disabled to be redefined. | 22:48 |
| CIA-31 | Mantisbt: paul * r3de25c823c34 /core/summary_api.php: strtotime is no longer needed | 22:48 |
| CIA-31 | Mantisbt: paul * r13fc9fb106a2 /core/database_api.php: We do not need to set $t_core_dir in database api | 22:48 |
| CIA-31 | Mantisbt: paul * r09cd078f4c5c /core/email_api.php: Only load disposable.php if we call email_is_disposable. This saves memory + cpu for every page hit | 22:48 |
| CIA-31 | Mantisbt: paul * r40b52adf18c8 /admin/schema.php: Fix: Missing schema update in datetime->int conversion | 22:48 |
| CIA-31 | Mantisbt: paul * r6412a921eccf /core/bugnote_api.php: typo | 22:48 |
| CIA-31 | Mantisbt: paul * rf046b0ffda0c /core/logging_api.php: Update firephp logging change for giallu's change defining library path | 22:48 |
| CIA-31 | Mantisbt: paul * r2ef2f58e19be /core/ (constant_inc.php ldap_api.php logging_api.php): Add initial logging for ldap | 22:48 |
| CIA-31 | Mantisbt: paul * r77d6bf4ab711 /core.php: DIRECTORY_SEPARATOR should be used over / or \ | 22:48 |
| CIA-31 | Mantisbt: paul * rcbcefe330ccb /library/README.libs: Add upstream library details for disposable email checker | 22:48 |
| CIA-31 | Mantisbt: paul * rad372b45fcbc / (6 files in 4 dirs): DIRECTORY_SEPARATOR should be used instead of / \ | 22:48 |
| CIA-31 | Mantisbt: paul * r20ba0ea17877 / (335 files in 27 dirs): ADODB is 3rd party library. Added upstream details to README.libs | 22:48 |
| CIA-31 | Mantisbt: paul * r946df7dcf6b1 /core/database_api.php: use DIRECTORY_SEPARATOR over / | 22:48 |
| CIA-31 | Mantisbt: paul * r59c531232d84 /lang/strings_english.txt: implement dhx_m suggestion (Time zone is two words) | 22:48 |
| CIA-31 | Mantisbt: paul * r3fbc4a38aba3 /core/filter_api.php: make date filters work. Note: we still need to deal with the offset between the stored data (gmt/utc) and the localtimezone for queries like this. | 22:48 |
| CIA-31 | Mantisbt: paul * r054b678f0216 /admin/schema.php: date_order also needs to be converted from datetime | 22:49 |
| CIA-31 | Mantisbt: paul * rafb392ec9eff /admin/schema.php: Fix order of parameters | 22:49 |
| CIA-31 | Mantisbt: paul * r6b3982600fdf /core.php: DIRECTORY_SEPERATOR should be used in path names over / | 22:49 |
| * nuclear_eclipse vomits at the set of commits involved..... | 22:49 | |
| paulr | well, I wanted to keep history | 22:49 |
| paulr | and the problem is where i've merged in other stuff | 22:50 |
| nuclear_eclipse | right | 22:50 |
| nuclear_eclipse | I'm not complaining, just mentioning that it's a bit overwhelming :P | 22:50 |
| paulr | :) | 22:50 |
| paulr | I've still got work todo | 22:50 |
| paulr | e.g. i've added | 22:50 |
| paulr | $t_where_params[] = strtotime( $t_start_string ); | 22:50 |
| paulr | strtotime() to fix date filters which dhx said were broken | 22:51 |
| paulr | which is fine but | 22:51 |
| paulr | db = utc/gmt | 22:51 |
| paulr | strtotime() will return local timezone | 22:51 |
| paulr | so I now need to go through and check what I need to localise and what I dont | 22:51 |
| paulr | but it's half term in uk schols in a week | 22:52 |
| paulr | and bankholiday weekend in uk next weekend i believe | 22:52 |
| paulr | also before I go to bed | 22:53 |
| paulr | how come moving files in git doesn't move history? | 22:54 |
| nuclear_eclipse | it does | 22:54 |
| paulr | nope | 22:54 |
| paulr | ssee http://git.mantisbt.org/?p=mantisbt.git;a=tree;f=library;h=2aff265240e5d60a6237b60dc8a70f2ac7c45c6a;hb=HEAD | 22:54 |
| nuclear_eclipse | what about thatL | 22:55 |
| nuclear_eclipse | it's just a tree view | 22:55 |
| nuclear_eclipse | besides, git only ever stores history at the file level; directories are just where files go as far as Git cares... | 22:56 |
| paulr | the history link | 22:56 |
| paulr | http://git.mantisbt.org/?p=mantisbt.git;a=history;f=library/phpmailer/class.phpmailer.php;h=38adc46e763356614c2d020712b5e324d410690e;hb=HEAD | 22:56 |
| paulr | anyway | 22:57 |
| paulr | now that giallu has modified default include path to include core dir | 22:57 |
| paulr | presumably | 22:57 |
| paulr | $t_core_dir = dirname( __FILE__ ) . DIRECTORY_SEPARATOR; | 22:57 |
| paulr | require_once( $t_core_dir . 'current_user_api.php' ); | 22:57 |
| nuclear_eclipse | I assume that's likely an artifact of how gitweb works; it may not traverse the history tree the same way `git log` does | 22:57 |
| paulr | can become just: | 22:57 |
| paulr | require_once( 'current_user_api.php' ); | 22:57 |
| nuclear_eclipse | agreed | 22:58 |
| nuclear_eclipse | except I think that doesn't work :P | 22:58 |
| paulr | why? | 22:58 |
| nuclear_eclipse | or at least, I was having trouble doing sometihng very similar with a plugin | 22:59 |
| paulr | should do if include path is right? | 22:59 |
| nuclear_eclipse | I think either Mantis or PHP doesn't keep a proper include path when inside included files, or something | 22:59 |
| paulr | that's relative stuff though right? | 22:59 |
| paulr | here | 23:00 |
| paulr | we've used some php function set_include_path | 23:00 |
| paulr | to modify the default include path | 23:00 |
| nuclear_eclipse | right, it should be, but it seems that including from a file in a subdirectory doesn't seem to work correctly, at lleast in mantis... | 23:00 |
| paulr | when does it break? | 23:00 |
| nuclear_eclipse | I know for sure it broke in a plugin when I tried to include an API file in the same directory without prefixing $g_plugin_path/plugin_name/ | 23:01 |
| paulr | anyway | 23:01 |
| paulr | I'm quite surprised at the commit from giallu | 23:02 |
| nuclear_eclipse | haven't had the tim to look it oer yet | 23:02 |
| paulr | I think it must break debian/fedora packages | 23:02 |
| paulr | anywa,y I need sleep | 23:04 |
| paulr | if you think my comment about trunk might break stuff atm was too hidden, feel freee to send a mail | 23:04 |
| paulr | function wiki_enabled() { return( config_get_global( 'wiki_enable' ) == ON ); | 23:08 |
| paulr | } | 23:08 |
| * paulr wants to soo remove functions like that | 23:09 | |
| nuclear_eclipse | +1 | 23:09 |
| paulr | $ git rebase master | 23:10 |
| paulr | First, rewinding head to replay your work on top of it... | 23:10 |
| paulr | fatal: cannot create directory at library/disposable | 23:10 |
| paulr | could not detach HEAD | 23:10 |
| paulr | huh? | 23:10 |
| nuclear_eclipse | do `git st`, see if there's anything changed in your working copy | 23:16 |
Generated by irclog2html.py