| ../irclogs/#mantishelp.2009-06-16.log | ||
| --- scribe started --- | 00:00 | |
| anon39845 | nuclear_eclipse: here now :) | 06:05 |
|---|---|---|
| [KK]Kirill | paul_: I test jpGraph. in current git - not supported even replace EVENT to MENU | 07:23 |
| dhx_m | paul_: 300 comments on a single bug! WHOOA! | 08:45 |
| [KK]Kirill | dhx_m: lo | 09:54 |
| dhx_m | [KK]Kirill: hey | 09:54 |
| paul_ | [KK]Kirill: try my branch | 10:03 |
| paul_ | dhx_m: ? :) | 10:03 |
| paul_ | so like, I sent a mail to dev list last night | 10:03 |
| paul_ | no replies yet ;/ | 10:03 |
| dhx_m | paul_: was reading your mailing list email :) | 10:03 |
| paul_ | dhx_m: you probably see why I dont send many mails now ;p | 10:03 |
| dhx_m | hah | 10:03 |
| dhx_m | my only comment is that it'd be easier to see all these changes in individual branches | 10:12 |
| dhx_m | but then I guess you can't resolve conflicts between all the different branches | 10:12 |
| paul_ | well, bugobjects was an individual branch | 10:13 |
| paul_ | as was graphs | 10:13 |
| dhx_m | yep | 10:13 |
| paul_ | your argument is true for graphs | 10:13 |
| paul_ | and probably the later phpdoc stuff | 10:13 |
| paul_ | the earlier stuff - well I was told push bugobjects one day then mail list the next | 10:13 |
| dhx_m | it probably also works a bit like congress/parliament... try and attach bills to other ones :p | 10:14 |
| paul_ | so branch got collapsed between those two events | 10:14 |
| dhx_m | yep | 10:14 |
| [KK]Kirill | paul_: lo | 10:20 |
| [KK]Kirill | paul_: where you push your modify to master? | 10:40 |
| [KK]Kirill | when? | 10:40 |
| mantisbot | New bug: Bug 10593 - jonathh - open - new | 10:44 |
| mantisbot | New bug: Wrong category used when old one deleted. - http://www.mantisbt.org/bugs/view.php?id=10593 | 10:44 |
| [KK]Kirill | any around? | 11:07 |
| dhx_m | [KK]Kirill: yep, a little busy at the moment though (hence the delayed replies) | 12:30 |
| [KK]Kirill | dhx_m: I forget what I want :( | 12:56 |
| dhx_m | paul_: I noticed your email mentioned RC release... wouldn't it be beta instead? | 13:03 |
| CIA-61 | Mantisbt: jreese * rd16476468234 /doc/CREDITS: Added dhx to the list of developers. | 13:11 |
| dhx_m | I'm itching to commit something now haha | 13:12 |
| nuclear_eclipse | dhx_m: commit paul's branch -- he'll be friends with you forever :P | 13:12 |
| dhx_m | lol | 13:12 |
| dhx_m | I didn't realise there were ads on mantisbt.org until I just checked the mantis-web.git tree | 13:20 |
| dhx_m | too many years of using Adblock Plus... :) | 13:20 |
| dhx_m | I was wondering if it'd be possible to put the config_inc.php and custom_* files into mantis-web.git? | 13:21 |
| dhx_m | sensitive details like passwords, directory structures, etc can be included at the top from another php file outside the web root | 13:22 |
| dhx_m | it'd then be quite nice to have a stable and nightly demo site | 13:22 |
| killefiz | dhx_m: use config_defaults.inc.php? | 13:23 |
| dhx_m | config_defaults_inc.php isn't meant to be edited though | 13:24 |
| killefiz | dhx_m: are you talking about http://www.mantisbt.org/bugs/ or about http://www.mantisbt.org ? | 13:24 |
| dhx_m | (btw I'm not sure if you're aware that I'm talking about the bug tracker and demos on mantisbt.org?) | 13:24 |
| dhx_m | yep /bugs and /demo | 13:25 |
| killefiz | ok - I thought you were talking about the site itself | 13:25 |
| killefiz | just ignore me then ;) | 13:25 |
| dhx_m | well I guess I sort of was... :) | 13:26 |
| nuclear_eclipse | dhx_m: I guess I'm not seeing the point of putting config_inc.php under git for the website... | 13:28 |
| dhx_m | nuclear_eclipse: I guess it just lets everyone know when settings have been changed on the main tracker (and demo site) | 13:29 |
| nuclear_eclipse | ah | 13:29 |
| nuclear_eclipse | well, we coudl of course move more stuff out of config_inc.php and make sure it's all kept in config_defaults... | 13:30 |
| nuclear_eclipse | but I think adding yet another layer of indirection for that data is not the best course of action =/ | 13:30 |
| dhx_m | maybe this is some confusion over naming.. but isn't config_defaults_inc.php meant to be left untouched? | 13:31 |
| dhx_m | and all user config is meant to be in config_inc.php? | 13:31 |
| nuclear_eclipse | yes, but config_inc is not meant to be in version control either :P | 13:32 |
| dhx_m | well I guess I'm not asking for a full copy of the Mantis source code in mantis-web.git | 13:33 |
| dhx_m | just the parts which are changed from the base source code (configuration, custom functions, etc) | 13:33 |
| dhx_m | that way mantis-web.git is a better representation of what is actually on the server | 13:34 |
| dhx_m | and I guess it'd be a good example for people to follow? | 13:34 |
| nuclear_eclipse | well, for /bugs, that's just a raw clone of the 'live' branch, with no custom_* stuff; the main site is just a checkout of mantisbt-web with a config_inc that overwrites values... | 13:35 |
| dhx_m | I guess it'd be fairly default as-is | 13:35 |
| [KK]Kirill | I remeber | 13:36 |
| [KK]Kirill | dhx_m: did you have mantis on linux? | 13:36 |
| dhx_m | so if it is only a few lines of config (~20 or whatever) it isn't really worth putting it in mantis-web.git | 13:36 |
| dhx_m | [KK]Kirill: yes, multiple instances on Gentoo and one on RHEL | 13:36 |
| [KK]Kirill | What's about 2 project with diff patch? | 13:37 |
| [KK]Kirill | path* | 13:37 |
| dhx_m | yep I do that too | 13:38 |
| [KK]Kirill | upload in one issue in project 1 | 13:38 |
| [KK]Kirill | than move issue to project2 | 13:38 |
| [KK]Kirill | what with attach? | 13:38 |
| [KK]Kirill | happend? | 13:39 |
| dhx_m | well I run an instance of Mantis with 5 projects - is that what you're talking about? | 13:39 |
| dhx_m | or are you talking about two different front-ends for the same database? | 13:39 |
| paul_ | nuclear_eclipse: I dont see point of mailing list | 13:47 |
| paul_ | no one replies | 13:47 |
| dhx_m | to be honest, I agree | 13:48 |
| dhx_m | the reason being that I think the bug tracker actually takes place of a mailing list | 13:48 |
| dhx_m | it is much easier to find information in one place | 13:49 |
| dhx_m | at the moment people can make suggestions in any of the following ways: mailing list, wiki, bug tracker, IRC | 13:49 |
| killefiz | paul_: your emai was three ours ago and had a subject of (no subject) | 13:50 |
| dhx_m | with the exception of the bug tracker, most of those other mediums will quickly be forgotten | 13:50 |
| paul_ | 3 ? | 13:50 |
| paul_ | i sent it last night | 13:50 |
| paul_ | so 15 | 13:50 |
| mantisbot | New bug: Bug 10594 - eunice - open - new | 13:50 |
| mantisbot | New bug: Create field: Date, Type: date, no set "Possible Values " and "Default Value ", why cannot enter date to update issue - http://www.mantisbt.org/bugs/view.php?id=10594 | 13:50 |
| killefiz | paul_: right - I got confused by thunderbird showing 12:31 - missed the AM | 13:51 |
| nuclear_eclipse | dhx_m: biggest problem is that bug tracker cann't replace the mailing list as a centralized method of discussion | 13:51 |
| dhx_m | there must have been a big delay, I only received it 2hrs ago, even though it is timestamped ~16hrs ago | 13:51 |
| dhx_m | nuclear_eclipse: but could it... if we change email notification for new bugnote messages to behave more like emails? | 13:51 |
| dhx_m | nuclear_eclipse: and have some sort of method of adding bugnotes via email? | 13:52 |
| nuclear_eclipse | reporting a bug basically guarantees that nobody will see it except for people your send to it, or looking for it; with a mailing list, everyone gets informed of the discussion without needing to look for anything | 13:52 |
| dhx_m | true | 13:52 |
| [KK]Kirill | dhx_m: I'm about one mantis installation and 2 project in one mantis | 13:52 |
| dhx_m | [KK]Kirill: yep, I do that with 5 projects... works well :) | 13:53 |
| nuclear_eclipse | on the outside, the two seem like similar, swapple components, but the semantics or how each is used are completely different and complementary | 13:53 |
| [KK]Kirill | project has equal folders? | 13:53 |
| dhx_m | [KK]Kirill: when you copy an issue between projects I've found it is OK except the category remains the same as it was in the source project | 13:53 |
| [KK]Kirill | projects has equal folders? | 13:53 |
| dhx_m | [KK]Kirill: no, different | 13:54 |
| [KK]Kirill | strange | 13:54 |
| [KK]Kirill | I move issue from one project to other | 13:54 |
| dhx_m | nuclear_eclipse: so is it fair to say that changes should be made in a Linux kernel method of sending an email to the mailing list? | 13:54 |
| [KK]Kirill | and I see attached missed | 13:54 |
| dhx_m | nuclear_eclipse: instead of having people attach things to bugnotes, etc | 13:54 |
| dhx_m | nuclear_eclipse: basically I just have concerns about information being in more than one place (and the chance of it being in each place is random) | 13:55 |
| nuclear_eclipse | dhx_m: isn't that how it already works? that was the whole point of having `git format-patch` and `git am` :P | 13:55 |
| dhx_m | nuclear_eclipse: I actually thought patches should be attached to bugs on the tracker :o | 13:56 |
| nuclear_eclipse | I would actually agree with you on that | 13:56 |
| dhx_m | nuclear_eclipse: and for communication about a feature request/etc, the discussion happens in bugnotes on the tracker | 13:57 |
| dhx_m | that way everything is in a central location | 13:57 |
| dhx_m | [KK]Kirill: oh, that sounds bad | 13:57 |
| dhx_m | [KK]Kirill: is there a bug ID for this? | 13:57 |
| nuclear_eclipse | the problem here is that a) we tend to rarely open issues for features, and b) in the case of new features/modifications, you need more eyes on it than what a bug attachment can offer | 13:58 |
| dhx_m | [KK]Kirill: I can try replicating this when I get a bit of time | 13:58 |
| [KK]Kirill | dhx_m: I don't create yet | 13:58 |
| [KK]Kirill | dhx_m: I don't understand it's only for me or not | 13:59 |
| dhx_m | nuclear_eclipse: I'd generally say that major features should have a separate bug ID just for the purpose of keeping track of progress in one central place (list commits, comments from people that have tested it, etc) | 14:00 |
| dhx_m | nuclear_eclipse: but maybe I'm just thinking of a different style of development than what most people here are used to | 14:01 |
| nuclear_eclipse | once again, I agree with you completely :P | 14:01 |
| dhx_m | nuclear_eclipse: in a project I'm working on at the moment we use custom statuses in Mantis to denote if a bug has been reviewed before committing, etc | 14:01 |
| nuclear_eclipse | it's a matter of organization and process, with the team has lacked as long as I've been here, probably for the side effects of org/process requiring time, which is the one thing that our team does not have enough of... | 14:02 |
| dhx_m | nuclear_eclipse: so it becomes very easy to find things that need reviewing, etc... whereas a mailing list makes this hard (you lose track of patches that were never committed) | 14:02 |
| dhx_m | I dislike using a web browser interface to comment on bugs (would much prefer to use an email client) | 14:03 |
| dhx_m | which is why I was suggesting some sort of interface that allows people to discuss bugs via email (with attachments that are automatically attached to the bug) | 14:04 |
| nuclear_eclipse | dhx_m: prod giallu on that; he's been working on a python app to interface between mail and mantis via the soap interface | 14:05 |
| dhx_m | nuclear_eclipse: oh nice, I'd be interested in that feature :) | 14:05 |
| nuclear_eclipse | dhx_m: I think the biggest problem with using the bug tracker as the point of discussion is the pure flood of issues reported | 14:05 |
| dhx_m | high signal to noise? | 14:06 |
| dhx_m | I mean... low | 14:06 |
| nuclear_eclipse | high noise to signal :P | 14:06 |
| dhx_m | yeah haha | 14:06 |
| dhx_m | that is a good point... I guess they have the same problem with the kernel ML | 14:06 |
| dhx_m | I use it as an example as it is the largest (?) open source project | 14:07 |
| dhx_m | and I'm trying to imagine what would happen if they wanted to use Mantis | 14:07 |
| paul_ | when I decide to housekeep | 14:11 |
| paul_ | some things dont really require abug id | 14:11 |
| paul_ | e.g. i've been gradually doing phpdoc/querybound changes for months | 14:11 |
| paul_ | as it's *so* boring | 14:11 |
| dhx_m | yep | 14:12 |
| paul_ | hence why you'll find you get | 14:12 |
| paul_ | phpdoc | 14:12 |
| paul_ | some random fix | 14:12 |
| paul_ | work on feature i've been working on | 14:12 |
| nuclear_eclipse | paul_: I'd agree on that, but some things (like bugobjects) really could stand to have an associated issue in the tracker... | 14:12 |
| paul_ | query bound fixes | 14:12 |
| paul_ | random fix | 14:12 |
| paul_ | nuclear_eclipse: it does (kinda) | 14:12 |
| dhx_m | on my tracker we have the custom statuses New => Triaged => Assigned => Implementing => Implemented => Reviewing => Reviewed => Committed | 14:14 |
| dhx_m | (or close to that) | 14:14 |
| dhx_m | that would be the typical workflow | 14:14 |
| dhx_m | I recon this project could benefit from a workflow similar to: | 14:16 |
| dhx_m | New => Triaged => Implementing => Implemented => Reviewing => Reviewed => Committed | 14:17 |
| dhx_m | with branches: | 14:17 |
| dhx_m | New => Feedback Needed | 14:17 |
| dhx_m | etc | 14:18 |
| dhx_m | the main problem I see is that keeping track of which bug IDs have outstanding patches | 14:18 |
| dhx_m | and which patches need review | 14:18 |
| dhx_m | at the moment it seems that is all done on IRC? | 14:18 |
| dhx_m | or some are using the tag system to add a "patch" tag | 14:19 |
| dhx_m | but there isn't a standard as such (at least from what I can see)? | 14:19 |
| nuclear_eclipse | dhx_m: correct, we could benefit from some sort of well-defined development process; it's rather ad-hoc atm... | 14:20 |
| nuclear_eclipse | if you can get paul and victor on board with any sort of defined process, that's probablp 95% of your opposition right there :) | 14:21 |
| dhx_m | well I guess the first thing to do is come up with a proposal document :) | 14:22 |
| nuclear_eclipse | yep | 14:23 |
| dhx_m | I can understand why this would be a huge change | 14:24 |
| dhx_m | open source projects traditionally just "go with the flow" and don't have formal development processes | 14:24 |
| dhx_m | in reality little changes... it's mostly just changing documentation | 14:24 |
| nuclear_eclipse | especially small ones with only a handful of developers | 14:25 |
| dhx_m | yep | 14:25 |
| dhx_m | Mantis already has a bit of a development process | 14:25 |
| dhx_m | ie. the documentation on how to write patches, submit them, etc | 14:25 |
| nuclear_eclipse | right, wwell, it's more a defined process for how external developers should contribute fixes/features, but a) it's not complete, b) it doesn't define a process for the project/developers themselves, and c) is still part of the unreleased development guide for 1.2, which most people haven't yet done anything with... | 14:28 |
| dhx_m | yep | 14:30 |
| daryn | \back | 14:32 |
| dhx_m | I'm getting a division by 0 error in the latest version of Mantis | 14:44 |
| dhx_m | let me debug ;) | 14:44 |
| nuclear_eclipse | hooray! | 14:44 |
| paul_ | dhx_m: my version? | 14:46 |
| dhx_m | nah master | 14:47 |
| paul_ | try my branch | 14:47 |
| dhx_m | might be my bad config, checking now | 14:47 |
| paul_ | there's probably an outside chance it's fixed | 14:47 |
| paul_ | i'd be interested to know if it is a bad config | 14:47 |
| [KK]Kirill | Why in db stored record with Excel header, but in issue show Text icon? | 14:48 |
| dhx_m | ah actually it seems to be the "percentage complete by status" bar at the bottom of view_all_bug_page | 14:48 |
| dhx_m | when you don't have any bugs in the system | 14:48 |
| paul_ | dhx_m: I thought that was fixed in master already? | 14:49 |
| dhx_m | I'm having a guess ;) | 14:49 |
| paul_ | either that or | 14:49 |
| dhx_m | it isn't showing in my php_error.log file either | 14:49 |
| paul_ | it's more complicated then it looks | 14:49 |
| paul_ | :) | 14:49 |
| dhx_m | oh my bad | 14:50 |
| dhx_m | I'll reset my config to defaults | 14:50 |
| dhx_m | just to be safe | 14:50 |
| paul_ | dont | 14:51 |
| paul_ | we want to know what's wrong | 14:51 |
| dhx_m | nah my config had custom enum levels | 14:51 |
| dhx_m | that have since changed in master | 14:51 |
| dhx_m | after my patches were merged | 14:51 |
| dhx_m | actually | 14:51 |
| dhx_m | I'll try fixing it instead of starting fresh | 14:52 |
| [KK]Kirill | - Doctor, help me, all peoples ignored me... | 14:55 |
| [KK]Kirill | - Next | 14:55 |
| dhx_m | is there some way to turn off internal error handling in Mantis so that I can see the raw PHP/MySQL errors? | 14:56 |
| dhx_m | ie. line numbers | 14:56 |
| nuclear_eclipse | core/error_api | 14:56 |
| nuclear_eclipse | comment out the set_error_handller call at the top of the api | 14:56 |
| dhx_m | thanks :) | 14:56 |
| dhx_m | ok it seems that if you comment out the access levels in core/constant_inc.php and redefine it in custom_constant_inc.php | 15:04 |
| dhx_m | at custom_field_api.php:836 $t_private_access = config_get( 'private_project_threshold' ); | 15:05 |
| dhx_m | the value returned is 'ADMINISTRATOR' | 15:05 |
| dhx_m | instead of the integer 90? | 15:06 |
| dhx_m | defining ADMINISTRATOR in constant_inc.php solves the issue | 15:06 |
| dhx_m | although I don't see why commenting out constants in constant_inc.php (which have been defined in custom_constant_inc.php) should cause problems | 15:07 |
| dhx_m | ohhh I see | 15:09 |
| dhx_m | lots of hardcoded uses of ADMINISTRATOR :( | 15:09 |
| nuclear_eclipse | yes, unfortunately | 15:10 |
| dhx_m | I'll fix that | 15:10 |
| dhx_m | $g_admin_site_threshold ? | 15:10 |
| dhx_m | that is the most likely match I've found for an existing configuration option that means "superuser access" | 15:11 |
| nuclear_eclipse | I dunno | 15:12 |
| dhx_m | yep seems like it according to manage_overview_page.php:29 that uses this setting for that purpose | 15:12 |
| dhx_m | no other uses of this setting so far | 15:12 |
| paul_ | nuclear_eclipse: so | 15:47 |
| paul_ | am I pushing branch tonight? | 15:47 |
| paul_ | dhx_m: by 'administrator' you mean the code? | 15:47 |
| dhx_m | well the problem I'm currently fixing is the use of the ADMINISTRATOR constant within the code | 15:48 |
| nuclear_eclipse | paul_: I have no clue | 15:48 |
| dhx_m | when it really should be checking config_get_global( 'admin_site_threshold' ) | 15:48 |
| dhx_m | in all cases I've seen so far the use of the ADMINISTRATOR constant is on a global site level, hence config_get_global | 15:48 |
| paul_ | imo, having an admin_site_threshold is dangerous / pointless | 15:49 |
| paul_ | there's some stuff e.g. upgrades that should require an 'admin' | 15:49 |
| nuclear_eclipse | paul_: the point being that some sites may want to use a different set of user access levels... | 15:50 |
| dhx_m | i see what you're getting at | 15:50 |
| nuclear_eclipse | not that somebody would want to set admin threshhold to reporter level... | 15:50 |
| dhx_m | ADMINISTRATOR is really something that can't be redefined | 15:50 |
| dhx_m | and at the moment it doesn't make sense to have multiple levels of ADMINISTRATOR | 15:51 |
| paul_ | you've kinda hit my point between the two of you | 15:51 |
| paul_ | if we define an 'admin_site_threshold' | 15:51 |
| dhx_m | well it already is defined | 15:51 |
| dhx_m | so is manage_site_threshold | 15:51 |
| paul_ | I'd be inclined to add a check to our 'admin checks' | 15:51 |
| paul_ | that ensures that only admin's can access the admin_site and not reporters | 15:51 |
| dhx_m | we have user_is_administrator(userid) | 15:51 |
| paul_ | out of interest | 15:51 |
| paul_ | did I define admin_site_threshold? | 15:51 |
| dhx_m | not sure, it is only used once | 15:52 |
| dhx_m | I guess there is no real point in having admin_site_threshold | 15:53 |
| dhx_m | anyone at that threshold can just change all other thresholds to give themselves access | 15:53 |
| paul_ | where's it used atm? | 15:53 |
| nuclear_eclipse | lunchtime | 15:54 |
| nuclear_eclipse | cheers | 15:54 |
| dhx_m | manage_overview_page.php:29 | 15:56 |
| paul_ | dhx_m: did you review my branch yet? :P | 16:07 |
| dhx_m | not yet, won't have time until Friday | 16:08 |
| dhx_m | ~48hrs | 16:08 |
| dhx_m | but I will :) | 16:08 |
| paul_ | that'll be too late :P | 16:10 |
| dhx_m | oh, well I don't mind fixing bugs afterwards :p | 16:10 |
| dhx_m | so would it be ok for me to remove $g_admin_site_threshold? | 16:16 |
| dhx_m | I've fixed the only instance of its use to use access_has_global_level or whatever that function is | 16:17 |
| dhx_m | essentially ADMINISTRATOR is treated as "root" | 16:17 |
| dhx_m | and nothing is higher? | 16:17 |
| dhx_m | therefore there is no need to ever define a threshold, because nothing will be higher? | 16:18 |
| dhx_m | ahh actually | 16:21 |
| dhx_m | maybe it could be useful if you want to have multiple levels of "administrator" for cosmetic reasons | 16:21 |
| kenguest | interesting: http://code.google.com/p/baetle/ | 16:31 |
| dhx_m | indeed | 16:34 |
| dhx_m | although their current chart seems a little simple | 16:34 |
| dhx_m | Repository and Committing aren't linked for example | 16:36 |
| kenguest | it seems we're now using it in the RSS feed for the pear bug tracker | 16:36 |
| dhx_m | link? | 16:37 |
| dhx_m | can't find an RSS icon on their tracker :) | 16:38 |
| kenguest | looking for one too | 16:40 |
| phl4kx | hola a todos | 17:29 |
| phl4kx | hi all | 17:29 |
| phl4kx | the TIME when I report a incident is not correct, where I set the time in mantis? | 17:31 |
| nuclear_eclipse | phl4kx: what version of mantis are you using? | 17:31 |
| phl4kx | 1.1.8 | 17:33 |
| phl4kx | the stable | 17:34 |
| nuclear_eclipse | phl4kx: then you'll need to configure your server to use the appropriate timezone -- mantis just gets the time from the server itself, with no other method of handling it | 17:34 |
| phl4kx | i use apache server | 17:35 |
| phl4kx | I have to change in the PHP.INI or in the HTTPD.CONF? | 17:38 |
| nuclear_eclipse | phl4kx: it's probably not apache/php that you need to change, but the timezone used by the operating system... | 17:41 |
| phl4kx | nuclear_eclipse | 17:50 |
| phl4kx | :D | 17:50 |
| phl4kx | now is Ok | 17:50 |
| phl4kx | I live in Lima Peru..I change in my PHP.ini | 17:50 |
| phl4kx | dateTimeZone = America/Lima | 17:50 |
| phl4kx | now is ok :)....thanks | 17:50 |
| phl4kx | correct..not dateTimeZone...is TimeZone | 17:50 |
| dhx_m | admin/check.php doesn't work... is that intentional? | 17:59 |
| dhx_m | it includes a missing file: obsolete.php | 17:59 |
| dhx_m | but more to the point, it is not reading constants :) | 18:00 |
| nuclear_eclipse | dhx_m: yell at paul_ | 18:02 |
| dhx_m | ok :p | 18:10 |
| dhx_m | under what conditions would config_get return the name of a constant rather than the value of it? | 18:33 |
| dhx_m | this one has me confused | 18:34 |
| nuclear_eclipse | dhx_m: I can only imagine that something in config_* is set wrong... =\ | 18:35 |
| dhx_m | the odd thing is that | 18:37 |
| dhx_m | config_get( 'manage_project_threshold' ) returns the name of the constant | 18:37 |
| dhx_m | and config_get( 'view_configuration_threshold' ) returns the actual integer value | 18:38 |
| nuclear_eclipse | are you sure your local configuration is correct? | 18:38 |
| dhx_m | yep might be my code changes, I'm narrowing it down | 18:39 |
| nuclear_eclipse | btw, Eclipse + PDT + Firefox + Firebug = Fan-freakin-tastic for debugging Mantis | 18:43 |
| nuclear_eclipse | I always use Vim for my editor, but Eclipse has excellent integration with Xdebug/ZendDebugger | 18:44 |
| dhx_m | yep I like Firebug too | 18:47 |
| dhx_m | and of course, vim :) | 18:47 |
| dhx_m | echo config_get( 'manage_project_threshold' ); | 18:47 |
| dhx_m | returns the name of the constant | 18:47 |
| dhx_m | grrr | 18:47 |
| nuclear_eclipse | I seriously wish there was something like ViEmu available for Eclipse | 18:47 |
| paul_ | dhx_m: obsolete.php exists | 18:47 |
| paul_ | can i merge branch | 18:48 |
| dhx_m | paul_: ah ok | 18:48 |
| paul_ | cool! | 18:48 |
| nuclear_eclipse | paul_: jfdi | 18:48 |
| nuclear_eclipse | no-one ever said an RC had to be perfectly stable, it just needs to be feature complete, amiright? :P | 18:49 |
| dhx_m | lol | 18:51 |
| dhx_m | I should be careful where I place my "ah ok" comments lol | 18:51 |
| dhx_m | was referring to obsolete.php :p | 18:51 |
| dhx_m | OHHHHHHHHHHHHHHHH | 18:53 |
| dhx_m | it is custom_constant_inc.php and not custom_constants_inc.php | 18:54 |
| dhx_m | shouldn't it pluralised? | 18:54 |
| nuclear_eclipse | yeah, I just recently figured that out, and it's very confusing | 18:54 |
| dhx_m | ok I vote we check for both? :) | 18:54 |
| dhx_m | with a look to deprecate use of the non pluralised version? | 18:54 |
| nuclear_eclipse | +1 from me... | 18:55 |
| dhx_m | what I don't know is where we're keeping a record of things that are deprecated | 18:55 |
| nuclear_eclipse | good question :P | 18:56 |
| dhx_m | btw have we always had to enter an upload path when creating a new project? | 18:57 |
| nuclear_eclipse | the box has been there *at least* in 1.2 for about a year now, but it's not mandatory | 18:59 |
| dhx_m | it was for me...? | 18:59 |
| nuclear_eclipse | maybe it's only mandatory if you're not storing attachments in the database... | 19:00 |
| [KK]Kirill | nuclear_eclipse: you are using Eclipse? | 19:01 |
| nuclear_eclipse | only for debugging | 19:01 |
| [KK]Kirill | :( | 19:01 |
| nuclear_eclipse | I'm a Vim guy :P | 19:01 |
| [KK]Kirill | ) | 19:01 |
| [KK]Kirill | I use vim, but only for quick server edit | 19:02 |
| [KK]Kirill | I use your package and sftp for sync | 19:02 |
| dhx_m | oh I see the bug... it tries to add a directory separator to the blank upload path | 19:02 |
| dhx_m | and THEN it checks if the upload path is blank (it isn't anymore) | 19:02 |
| * nuclear_eclipse has been using vim for years, and has it highly customised to do a *lot* of nifty stuff that you can't ever get with standard text editors like what's in Eclipse | 19:02 | |
| nuclear_eclipse | [KK]Kirill: I even went so far as to make my own color scheme for Vim because all the light background schemes available are ugly or not useful | 19:04 |
| [KK]Kirill | I think too. But I don't have lot of time to config Eclipse.. I config Delphi for dark (classic) theme | 19:05 |
| paul_ | nuclear_eclipse: well | 19:09 |
| paul_ | wasn't point to get some feedback? | 19:09 |
| * paul_ is confused | 19:09 | |
| paul_ | i'm going to eat | 19:09 |
| paul_ | just tell me in 10 mintues what I'm doing | 19:09 |
| dhx_m | nuclear_eclipse: I was confused because I saw your recent change to gitignore which removed the ignore for custom_constant_inc.php | 19:13 |
| nuclear_eclipse | dhx_m: yeah, that was mistaken | 19:15 |
| dhx_m | I like it though :) | 19:15 |
| nuclear_eclipse | I'd prefer it that way, for sure | 19:15 |
| nuclear_eclipse | I made the commit because git wasn't ignoring my custom_constants_inc so I assumed the mistake was in .gitignore, not in how I nomed my file =\ | 19:16 |
| nuclear_eclipse | then I later realized that I was wrong on both counts, and never got around to fixing my "fix"... :( | 19:16 |
| CIA-61 | Mantisbt: hickseydr * r1317d03ba014 /core/project_api.php: Make project upload path non-optional again | 19:19 |
| dhx_m | that should fix it | 19:19 |
| dhx_m | :) | 19:19 |
| nuclear_eclipse | your commit disagrees with your summary... ;) | 19:23 |
| dhx_m | lol | 19:31 |
| dhx_m | good point | 19:31 |
| dhx_m | fixed | 19:33 |
| dhx_m | or not | 19:33 |
| nuclear_eclipse | nope, don't fix it | 19:33 |
| dhx_m | doesn't like git commit --amend | 19:33 |
| dhx_m | ok | 19:33 |
| nuclear_eclipse | fixing the summary would rewrite history, which would break anything that's already pulled from master since you made your commit | 19:34 |
| dhx_m | yep good point | 19:34 |
| nuclear_eclipse | generally, rewriting commit history is perfectly fine if it's private history that you're touching -- once it's public, you shouldn't be changing it ever, because it will cause a *lot* of headaches | 19:35 |
| dhx_m | yep | 19:35 |
| nuclear_eclipse | we went through that once already when we ripped out the rpxnow stuff from master branch and force pushed the new master branch, and it caused way too many problems -- anyone following master had to reset/rebase onto the new history, and any branches based on it, etc | 19:38 |
| dhx_m | ugly | 19:42 |
| nuclear_eclipse | yep | 19:42 |
| paul_ | so | 19:44 |
| paul_ | am I fixing | 19:44 |
| * paul_ pokes nuclear_eclipse hard | 19:45 | |
| nuclear_eclipse | paul_: just commit it; I'm sick of pushing off the release | 19:45 |
| paul_ | yay | 19:45 |
| paul_ | I think i'll copy my working dir first | 19:45 |
| nuclear_eclipse | if noone wants to respond, then they can't complain :P | 19:45 |
| paul_ | yea | 19:46 |
| dhx_m | :) | 19:46 |
| nuclear_eclipse | paul_: just branch from your current point to handle the merge | 19:46 |
| CIA-61 | Mantisbt: hickseydr * r1ae2c4fb0870 / (.gitignore core.php): Rename custom_constant_inc to custom_constants_inc | 19:46 |
| dhx_m | wait for me to break some stuff first please :p | 19:46 |
| paul_ | they've had no | 19:46 |
| paul_ | dhx_m: want to die? | 19:46 |
| Reapazor2 | so heres a fun little factoid ... iwas running last nights build :) just copied over the most recent git version | 19:46 |
| dhx_m | lol | 19:46 |
| Reapazor2 | and all i get ... is a white screen :) | 19:46 |
| Reapazor2 | working on pulling some logs :) | 19:46 |
| dhx_m | interesting... I just reinstalled the latest git trunk with no problems | 19:47 |
| Reapazor2 | serves me right :) | 19:47 |
| paul_ | nuclear_eclipse: I agree - it's been 76423 seconds since I sent mail | 19:48 |
| paul_ | nuclear_eclipse: that's a large number | 19:48 |
| nuclear_eclipse | lol | 19:48 |
| dhx_m | haha | 19:48 |
| paul_ | so erm | 19:48 |
| paul_ | when you say | 19:48 |
| paul_ | branch from my current point | 19:48 |
| paul_ | what | 19:48 |
| nuclear_eclipse | it's been 12345670000000000 picoseconds since you last complained, therefore you *never* complain, amiright? | 19:48 |
| nuclear_eclipse | `git checkout -b <new_branch_name>` | 19:49 |
| dhx_m | does anyone want to review my changes to remove hardcoded uses of the ADMINISTRATOR constant? | 19:49 |
| nuclear_eclipse | dhx_m: pop it on mantisforge, I'll try to get to it today or tomorrow before I roll the release | 19:49 |
| paul_ | nuclear_eclipse: i've complained in the last 3.4 hours | 19:49 |
| dhx_m | nuclear_eclipse: great :) | 19:49 |
| Reapazor2 | tis dying in the core init :) | 19:49 |
| Reapazor2 | ---still digging :D | 19:50 |
| paul_ | nuclear_eclipse: then what | 19:50 |
| nuclear_eclipse | Reapazor2: good luck ;) | 19:50 |
| dhx_m | nuclear_eclipse: I'll put it in a 'dhx-staging' branch on the official tracker for you? | 19:50 |
| paul_ | no | 19:50 |
| paul_ | on mantisforge | 19:50 |
| nuclear_eclipse | paul_: then do `git merge master` and fix the conflicts, then do `git add` on all conflicted files, and then `git commit` to finish the merge | 19:50 |
| dhx_m | ok | 19:50 |
| paul_ | wait | 19:51 |
| paul_ | atm, i have stuff in a branch | 19:51 |
| paul_ | am i making new master | 19:51 |
| paul_ | then pulling? | 19:51 |
| Reapazor2 | and we find out it doesntlike my config file :) | 19:52 |
| nuclear_eclipse | paul_: you're making a non-master branch with your latest development stuff, then you're updating your master branch to be identical to upstream (origin/master), then pulling that into your topic branch as a merge to put it all together | 19:52 |
| paul_ | I have my development stuff in a non-master branch | 19:52 |
| dhx_m | I have my changes applied to the master branch (not committed yet) and would like to move those working changes to a new branch... is there an easy way? | 19:53 |
| nuclear_eclipse | paul_: right, by making the second branch, you can pull master in, and if you bork the merge, you still have the old branch untouched | 19:53 |
| paul_ | i've made a second branch | 19:53 |
| paul_ | tried doing git fetch | 19:53 |
| paul_ | and git rebase origin/master | 19:53 |
| paul_ | and get errors | 19:53 |
| nuclear_eclipse | dhx_m: `git co -b <new branch>; git co master; git reset --hard origin/master` | 19:53 |
| nuclear_eclipse | paul_: what error? | 19:54 |
| paul_ | CONFLICT (content): Merge conflict in core/relationship_api.php | 19:54 |
| dhx_m | nuclear_eclipse: thanks | 19:54 |
| paul_ | but surely | 19:54 |
| paul_ | it shouldn't be merging yet | 19:54 |
| nuclear_eclipse | paul_: so fix the conflict, `git add` the file when you're done, and then do `git rebase --continue` | 19:55 |
| paul_ | hang on | 19:55 |
| paul_ | i've aborted that merge | 19:55 |
| paul_ | let me rebase master | 19:55 |
| nuclear_eclipse | it should be the same result | 19:55 |
| paul_ | $ git rebase origin/master | 19:55 |
| paul_ | It seems that I cannot create a rebase-apply directory, and | 19:55 |
| paul_ | I wonder if you are in the middle of patch application or another | 19:55 |
| paul_ | rebase. If that is not the case, please rm -fr c:/mantis/git/mantisbt/.git/rebase-apply | 19:55 |
| paul_ | hmm | 19:55 |
| nuclear_eclipse | do `git rebase --abort` | 19:55 |
| paul_ | 'master' branch is now up to date | 19:56 |
| paul_ | I have my code in 'branch' | 19:56 |
| paul_ | so now when in master | 19:56 |
| paul_ | I do git merge branch ? | 19:56 |
| nuclear_eclipse | yeah, that will work too | 19:56 |
| paul_ | then fix conflicts? | 19:59 |
| dhx_m | nuclear_eclipse: pushed it to mantisforge :) | 20:00 |
| Reapazor2 | classy :) i didnt notice the escape sequence in the smtp password string :) serves me right ...100characters long | 20:01 |
| paul_ | GRRRRRRRRRRRR | 20:01 |
| dhx_m | did I break something? :p | 20:01 |
| nuclear_eclipse | no, paul just has no clue how to merge anything :P | 20:02 |
| paul_ | i think i'll cheat | 20:02 |
| nuclear_eclipse | uh oh | 20:02 |
| nuclear_eclipse | paul_: I'd rather handle the merge for you than do any "cheating" | 20:02 |
| paul_ | it'll be fine! | 20:02 |
| nuclear_eclipse | depends on what "cheating" you're doing... | 20:03 |
| Reapazor2 | famous last words : it'll be fine! | 20:03 |
| paul_ | it'll be fine | 20:05 |
| dhx_m | is now a really bad time to commit a very minor documentation update? | 20:05 |
| nuclear_eclipse | lol | 20:06 |
| dhx_m | custom_constant_inc => custom_constants_inc | 20:06 |
| paul_ | dhx_m: YES | 20:06 |
| dhx_m | ah it's just 4 bytes added to one doc file :p | 20:06 |
| * paul_ finds axe | 20:06 | |
| dhx_m | I'll take my chances :p | 20:07 |
| dhx_m | btw it won't break your stuff ;) | 20:07 |
| CIA-61 | Mantisbt: hickseydr * rba06d06ad6cf /docbook/adminguide/en/customizing_mantis.sgml: Docbook updates for rename of custom_constant_inc | 20:07 |
| paul_ | yea ok | 20:07 |
| paul_ | i've not changed manual to .xml yet :p | 20:08 |
| dhx_m | I didn't think so :p | 20:08 |
| dhx_m | you didn't stike me as someone who reads and writes manuals :p | 20:08 |
| paul_ | well, I can't find an editor that'll open .sgml and deal with closing tags etc | 20:09 |
| paul_ | as they either require .xml | 20:09 |
| paul_ | or whinge about the format of the existing stuff | 20:09 |
| nuclear_eclipse | no, he just complains about it constantly that he "can't" edit it because he doesn't want to write SGML by hand | 20:09 |
| dhx_m | yep | 20:09 |
| dhx_m | nuclear_eclipse: I take it you're an admin at mantisbt.org... can you see the wiki docs OK? (if so... bug 6354 can be closed) | 20:12 |
| mantisbot | Bug 6354 - mstolar - open - acknowledged | 20:12 |
| mantisbot | project documentatnion not visible for manager and administrator - http://www.mantisbt.org/bugs/view.php?id=6354 | 20:12 |
| nuclear_eclipse | that's not talking about the wiki | 20:13 |
| dhx_m | ah ok | 20:13 |
| dhx_m | it's so old that terminology has most likely changed since | 20:14 |
| nuclear_eclipse | last I knew we were wanting to pull the docs feature into a non-core plugin... | 20:14 |
| nuclear_eclipse | but I doubt that will happen anytime soon... | 20:14 |
| dhx_m | :) | 20:14 |
| dhx_m | the other thing I noticed is that developer access on mantisbt.org doesn't let you link commits to bug IDs? | 20:16 |
| nuclear_eclipse | hmm, that's actually an unexpected consequence of how I designed the feature... :P | 20:18 |
| nuclear_eclipse | it checks the user's global access level, not their project levels | 20:18 |
| dhx_m | ah I see :) | 20:18 |
| nuclear_eclipse | and in your case, I only gave you dev access to the project itself, and left your global access as reporter | 20:19 |
| dhx_m | yep, makes sense now :) | 20:19 |
| nuclear_eclipse | I'll just up your global access | 20:19 |
| nuclear_eclipse | done | 20:19 |
| dhx_m | ok I'll try it out, thanks | 20:20 |
| dhx_m | btw do I use "Fixes #12345" in commit messages to auto link? | 20:28 |
| nuclear_eclipse | as long as it matches this regex: | 20:29 |
| nuclear_eclipse | /(?:bugs?|issues?|reports?|fixe?s?)+\s+(?:#?(?:\d+)[,\.\s]*)+/i | 20:29 |
| paul_ | AKJFDSAJKFLDSAJKF | 20:29 |
| dhx_m | ok thanks :) | 20:30 |
| [KK]Kirill | dhx_m: where fix for gitignore? ;) | 20:35 |
| dhx_m | [KK]Kirill: sorry? | 20:36 |
| dhx_m | [KK]Kirill: I don't quite understand :) | 20:36 |
| [KK]Kirill | oh. It's I'm sorry | 20:36 |
| [KK]Kirill | I don't understand diff | 20:36 |
| [KK]Kirill | All right | 20:36 |
| [KK]Kirill | brr | 20:37 |
| [KK]Kirill | I don't understand | 20:37 |
| [KK]Kirill | 3 custom_constants_inc.php | 20:37 |
| [KK]Kirill | 9 custom_constant_inc.php | 20:37 |
| [KK]Kirill | ? | 20:37 |
| [KK]Kirill | How file mast named? | 20:38 |
| [KK]Kirill | must* | 20:38 |
| [KK]Kirill | siebrand: lo | 20:39 |
| [KK]Kirill | can you push last translate? | 20:39 |
| dhx_m | call it custom_constants_inc.php | 20:42 |
| dhx_m | you *could* maintain the custom_constant_inc.php name until 1.3 though | 20:42 |
| [KK]Kirill | oh.. I forgot this.. | 20:43 |
| dhx_m | it is essentially a deprecation happening, so during this time you can use either the old or new approach | 20:43 |
| dhx_m | to give you time to upgrade :) | 20:43 |
| paul_ | DHXXXXXXXXXXXXXXXXXXXXXX | 20:44 |
| [KK]Kirill | I more time use last git and forgot what be in stable branch | 20:44 |
| [KK]Kirill | paul_: where you push? | 20:44 |
| [KK]Kirill | with new evens | 20:44 |
| dhx_m | paul_: what? :p | 20:44 |
| paul_ | wat's happened ;/ | 20:45 |
| dhx_m | where? | 20:45 |
| [KK]Kirill | paul_: nothing. and this bad | 20:46 |
| [KK]Kirill | :) | 20:46 |
| paul_ | john ;( | 20:47 |
| phl4kx | I Love mantis :D | 20:47 |
| paul_ | maybe I typed the wrong command | 20:47 |
| paul_ | let me just try git push and see if it works | 20:47 |
| * paul_ wonders if git push master would work | 20:48 | |
| paul_ | dhx_m: whats a refspec? :) | 20:50 |
| dhx_m | this is going to be fun :p | 20:50 |
| paul_ | well | 20:51 |
| paul_ | tyour docbook updates commit | 20:51 |
| paul_ | looks strange | 20:51 |
| dhx_m | http://blog.endpoint.com/2008/07/git-push-know-your-refspecs.html | 20:51 |
| paul_ | right | 20:52 |
| dhx_m | ? | 20:52 |
| paul_ | so just git push master? | 20:52 |
| dhx_m | git push origin master | 20:52 |
| dhx_m | if you want to be more paranoid :) | 20:52 |
| paul_ | error | 20:52 |
| paul_ | let me try git push master on it's own | 20:53 |
| paul_ | ok | 20:53 |
| paul_ | it's doing something | 20:53 |
| dhx_m | :) | 20:53 |
| CIA-61 | Mantisbt: paul * reba305694fcf /core/ (bugnote_api.php email_api.php relationship_api.php): Adjust how we cache loaded bugnotes | 20:54 |
| CIA-61 | Mantisbt: paul * rb39854a24240 /core/classes/MantisEnum.class.php: is_blank() | 20:54 |
| CIA-61 | Mantisbt: paul * r97b67e4bbb2f / (23 files in 4 dirs): Changes to bug object | 20:54 |
| CIA-61 | Mantisbt: paul * rb47f9245291c / (9 files in 3 dirs): split->explode | 20:54 |
| paul_ | warning: too many files, skipping inexact rename detection | 20:54 |
| CIA-61 | Mantisbt: paul * r172c77f1de21 /core/ (16 files): Whitespace found at end of line | 20:54 |
| paul_ | what does that mean | 20:54 |
| dhx_m | hah wait for it :) | 20:54 |
| CIA-61 | Mantisbt: paul * r0f47458541f7 /core/utility_api.php: Whitespace found at end of line | 20:54 |
| CIA-61 | Mantisbt: paul * rdb5eb5ef8323 /library/adodb/drivers/ (21 files): fix php5.3 deprecation warnings in php5.3 - reported upstream. | 20:54 |
| CIA-61 | Mantisbt: paul * r745719001c89 / (admin/check.php core/constant_inc.php): Add WARN to constant_inc. | 20:54 |
| CIA-61 | Mantisbt: paul * ra7449b0d03bc /core/ (authentication_api.php file_api.php): md5 hashes are 32chars so no need to substr | 20:54 |
| dhx_m | this will be PAGES :p | 20:54 |
| CIA-61 | Mantisbt: paul * r9e256cc99d29 / (6 files in 4 dirs): Move projax into library dirs | 20:54 |
| CIA-61 | Mantisbt: paul * r3fedeedd034d /tag_view_page.php: remove extra html tag | 20:54 |
| paul_ | :P | 20:54 |
| CIA-61 | Mantisbt: paul * r7b2c3817ad98 / (8 files in 2 dirs): php codesniffer validation fixes | 20:54 |
| CIA-61 | Mantisbt: paul * r4dd10795c716 /core/tag_api.php: html validation | 20:54 |
| CIA-61 | Mantisbt: paul * r96635571acfe /core/utility_api.php: php5.3 support - remove use of spliti | 20:54 |
| CIA-61 | Mantisbt: paul * r19ab0cd8c3c3 / (9 files in 3 dirs): more db_query_bound updates | 20:54 |
| CIA-61 | Mantisbt: paul * r2b38a584ef8a / (50 files in 13 dirs): misc tidy up - add a readme_mantis.txt for changes in each library (this is the approach moodle use) | 20:54 |
| paul_ | i'd still like to know what warning: too many files, skipping inexact rename detection means :) | 20:54 |
| CIA-61 | Mantisbt: paul * r442c7fa73aa9 /library/ezc/ (150 files in 24 dirs): Add library for graphs | 20:54 |
| CIA-61 | Mantisbt: paul * r157048eb5318 / (14 files in 8 dirs): Update graph plugin. | 20:54 |
| CIA-61 | Mantisbt: paul * r27213a2080fe / (7 files in 3 dirs): Misc. fixes for my bugobjects/duedate work | 20:54 |
| CIA-61 | Mantisbt: paul * r4ef6665da5fb /core/html_api.php: check if empty | 20:54 |
| CIA-61 | Mantisbt: paul * rf496f44b662d / (4 files in 3 dirs): Validate email on windows also. | 20:54 |
| CIA-61 | Mantisbt: paul * rde3b3035ce36 /core/ (email_api.php user_pref_api.php): Fixes towards Issue #0008561 | 20:54 |
| CIA-61 | Mantisbt: paul * rc72a2e88b91f /core/graphviz_api.php: PHPdoc for graphviz_api | 20:54 |
| CIA-61 | Mantisbt: paul * rc83691f745f5 /core/filter_api.php: Filter api should just call utf8_strlen | 20:54 |
| CIA-61 | Mantisbt: paul * r25595427939c /library/README.libs: update readme.libs | 20:55 |
| CIA-61 | Mantisbt: paul * r42fc9d877638 /admin/test_langs.php: If include()ing language file returns data, display data to aid fixing | 20:55 |
| CIA-61 | Mantisbt: paul * rc6080232b85c /core/ (6 files): db_query_bound changes | 20:55 |
| CIA-61 | Mantisbt: paul * rdb05f6a95405 / (19 files in 7 dirs): Update gitignore to exclude jpgraph/FirePHPCore library | 20:55 |
| CIA-61 | Mantisbt: paul * r8921e1f5cf15 /core/string_api.php: php codesniffer validation fixes | 20:55 |
| CIA-61 | Mantisbt: paul * r748d601afe73 /docbook/adminguide/en/customizing_mantis.sgml: Merge branch 'master' of git@mantisbt.org:mantisbt | 20:55 |
| * paul_ goes to get a drink ;/ | 20:55 | |
| dhx_m | lol | 20:55 |
| CIA-61 | Mantisbt: paul * r68f34164347a / (63 files in 14 dirs): Support use of compressed jscript files. raw files go into javascript/dev, minimised files go into javascript/min | 20:55 |
| CIA-61 | Mantisbt: paul * rac5f3072035a /admin/test_langs.php: update test_langs.php | 20:55 |
| CIA-61 | Mantisbt: paul * r5e12dc69bf80 /core/email_api.php: Reduce number of database calls with large emails: Issue #0008561: THIS INSTALLATION: timeout on adding bugnote to issue4286 | 20:55 |
| dhx_m | see you in 10 minutes once the spam stops? | 20:55 |
| CIA-61 | Mantisbt: paul * r632d590ea8df /core/string_api.php: Fix string_prepare_header | 20:55 |
| CIA-61 | Mantisbt: paul * rba1949ee7c4e / (admin/email_queue.php core/email_api.php): 1) Add ability to clear email queue to admin/email_queue | 20:55 |
| CIA-61 | Mantisbt: paul * r112d3c6ab2e5 / (core/date_api.php css/calendar-blue.css): move calendar css to /css | 20:55 |
| CIA-61 | Mantisbt: paul * rde8cb41d009a /core/freemind_api.php: Remove freemind API - no need to phpdoc this - the functionality moved to a plugin | 20:55 |
| CIA-61 | Mantisbt: paul * r0bbee26ac331 /core/ (html_api.php print_api.php): stop_on_errors is a global only configuration | 20:55 |
| CIA-61 | Mantisbt: paul * r8a555e2c8097 /core/print_api.php: only cache project id's that user has accessible | 20:55 |
| CIA-61 | Mantisbt: paul * rb34c2d3d5673 /core/error_api.php: oops | 20:55 |
| CIA-61 | Mantisbt: paul * r0d17ca917494 / (54 files in 6 dirs): graphplugin (in progress) | 20:56 |
| CIA-61 | Mantisbt: paul * re52d1a9aa3ae / (6 files in 2 dirs): split->explode, remove eregi | 20:56 |
| CIA-61 | Mantisbt: paul * r4dcf7534bd18 /plugins/XmlImportExport/pages/ (import.php import_action.php): Fix: 0010585: string not found manage_import_issues_link | 20:56 |
| CIA-61 | Mantisbt: paul * raa618485eaa3 /core/email_api.php: PHPmailer should throw exceptions + catch exception adding email addresses. | 20:56 |
| nuclear_eclipse | paul_: it means that Git is not even trying to look through all the changed content looking for implicit renames -- it would take too long -- so it's just ignoring that step of the process | 20:56 |
| CIA-61 | Mantisbt: paul * rb4cc29dcc07b /manage_tags_page.php: Fix php undefined variable warnings | 20:56 |
| CIA-61 | Mantisbt: paul * r385f071ebd40 /core/email_api.php: PHPDoc email api | 20:56 |
| CIA-61 | Mantisbt: paul * r166250e5b959 /core/ (44 files in 2 dirs): PHPdoc changes | 20:56 |
| CIA-61 | Mantisbt: paul * re4fad0e09934 /core/ (33 files in 2 dirs): Php codesniffer formatting changes | 20:56 |
| CIA-61 | Mantisbt: paul * r41a4ea5dcccc /admin/test_langs.php: Update test_langs to detect strings that are no longer defined in english, defined in translations | 20:56 |
| CIA-61 | Mantisbt: paul * ra5bf55de3485 / (10 files in 2 dirs): merge | 20:56 |
| CIA-61 | Mantisbt: paul * r08f36d719ae5 / (459 files in 69 dirs): Merge branch 'graph' | 20:56 |
| CIA-61 | Mantisbt: paul * ra07e32d369dd /library/utf8/ (60 files in 8 dirs): add readme_mantis.txt to utf8 lib + tidy up | 20:56 |
| CIA-61 | Mantisbt: paul * radfb2d24630f / (7 files in 4 dirs): Remove db_prepare_string from db_query_bound calls | 20:56 |
| dhx_m | nice work haha | 20:56 |
| dhx_m | that was huge | 20:56 |
| dhx_m | instant front page @ cia.vc? :) | 20:57 |
| paul_ | lol | 20:57 |
| dhx_m | you're currently 3rd | 20:57 |
| paul_ | 9 | 20:57 |
| dhx_m | http://cia.vc/stats/author/paul | 20:58 |
| * paul_ spell checks mantis source | 20:58 | |
| dhx_m | lol | 20:58 |
| dhx_m | let's see if it still works :) | 20:59 |
| * nuclear_eclipse is afraid to pull atm... | 20:59 | |
| paul_ | now | 21:00 |
| paul_ | I want to fix sponsorship api | 21:00 |
| nuclear_eclipse | paul_: in the future, please keep your commit queue a) broken up into smaller topic branches, and b) not gigantic to the point where no-one wants to review or have a "big-bang" type of merge... | 21:01 |
| [KK]Kirill | nice.. I think CIA go down after take this informations :) | 21:01 |
| paul_ | nuclear_eclipse: Id o :) | 21:01 |
| paul_ | bugobjects was a small topic branch :P | 21:01 |
| paul_ | as was graphs :P | 21:01 |
| paul_ | I just started merging them together to push then got told not to | 21:02 |
| nuclear_eclipse | paul_: they should have stayed small topic branches then until you had gotten the OK to merge them to master... | 21:02 |
| dhx_m | nuclear_eclipse: so if a project file upload path is left blank and no default is specified in config_inc, are attachments stored in the database instead? | 21:02 |
| paul_ | and family were on holiday at weekend | 21:02 |
| paul_ | nuclear_eclipse: I did get the 'ok' :) | 21:02 |
| paul_ | then 24 hours later got told 'wait' | 21:02 |
| paul_ | so carried did stuff whilst waiting ;p | 21:02 |
| nuclear_eclipse | dhx_m: no, there's an explicit option to store them as files or in the db | 21:02 |
| dhx_m | nuclear_eclipse: ok thanks, that's all I needed to know :) | 21:03 |
| nuclear_eclipse | if storing as files and no project path added, I dunno | 21:03 |
| paul_ | now to find 9 things to fix | 21:04 |
| nuclear_eclipse | 9 ? | 21:04 |
| paul_ | yep | 21:04 |
| * nuclear_eclipse cries | 21:04 | |
| paul_ | ? | 21:05 |
| paul_ | nuclear_eclipse: what have i broken? ;/ | 21:06 |
| nuclear_eclipse | I don't know yet, but the fact that you're *looking* for nine things to fix just makes me want to cry for the stability of this release.... | 21:06 |
| paul_ | it should be fine ;p | 21:06 |
| paul_ | hopefully ;p | 21:07 |
| nuclear_eclipse | paul_: two things -- a) bug 10565 is fixed now? b) are you ever going to finish timezone stuff? | 21:08 |
| mantisbot | Bug 10565 - jreese - open - assigned | 21:08 |
| mantisbot | User input date strings are munged with new schema - http://www.mantisbt.org/bugs/view.php?id=10565 | 21:08 |
| paul_ | I think A - yes | 21:09 |
| paul_ | B - remind what what's left to do? | 21:09 |
| * paul_ needs to update notepad | 21:09 | |
| nuclear_eclipse | actually handle the user's timezone prefs | 21:09 |
| paul_ | in terms of display or? | 21:10 |
| paul_ | I know off hand I was looking at email last | 21:10 |
| nuclear_eclipse | and then everywhere that we output a date, localize the date to the user's timezone, and convert from the user's timezone whenever taking user input | 21:10 |
| paul_ | dates *should* be localised already | 21:10 |
| mantisbot | New bug: Bug 10595 - jreese - open - assigned | 21:13 |
| mantisbot | New bug: Allow plugins to define and add new filters - http://www.mantisbt.org/bugs/view.php?id=10595 | 21:13 |
| CIA-61 | Mantisbt: hickseydr * r7871f6cf2b94 / (manage_proj_create.php manage_proj_create_page.php): Show default upload path when creating project | 21:14 |
| nuclear_eclipse | time to head home | 21:16 |
| nuclear_eclipse | cheers all | 21:16 |
| dhx_m | thanks for all the help :) | 21:17 |
| dhx_m | I'm off too | 21:17 |
| dhx_m | cya! | 21:17 |
| dhx_m | paul_: user_pref_api.php:133 and 144 are screwed ;) | 21:29 |
| dhx_m | paul_: missing entry in $g_default_mapping | 21:31 |
| dhx_m | paul_: I'll work out which one | 21:31 |
| paul_ | hmm/ | 21:33 |
| dhx_m | paul_: when $p_string is null you're checking a config option with a null name | 21:34 |
| paul_ | no, if the result is null | 21:34 |
| dhx_m | paul_: I'm not sure what you were trying to do there :) | 21:34 |
| paul_ | that's old code | 21:35 |
| paul_ | but | 21:35 |
| paul_ | if( is_null( $this->{$p_string} ) ) { | 21:35 |
| paul_ | i.e. | 21:35 |
| paul_ | if the value stored in class is still null | 21:35 |
| paul_ | i.e. hasn't been set | 21:35 |
| dhx_m | ah in that case something must be calling __get/Get with a null argument | 21:35 |
| paul_ | well you can't call __get with null can you? ;/ | 21:36 |
| CIA-61 | Mantisbt: paul * re80c06caa6c0 /core/sponsorship_api.php: Fixes towards issue #0008561 | 21:36 |
| CIA-61 | Mantisbt: paul * r79f5bc2b87f6 / (manage_proj_create.php manage_proj_create_page.php): Merge branch 'master' of git@mantisbt.org:mantisbt | 21:36 |
| dhx_m | paul_: you can call it with a blank string | 21:36 |
| paul_ | Get() yes | 21:36 |
| dhx_m | well I'll do a backtrace to find it | 21:37 |
| dhx_m | #0 config_get_global(, ) called at [/var/www/localhost/htdocs/mantis-git/core/config_api.php:167] | 21:38 |
| dhx_m | #1 config_get(, , 1, 0) called at [/var/www/localhost/htdocs/mantis-git/core/user_pref_api.php:133] | 21:38 |
| dhx_m | #2 UserPreferences->__get() called at [/var/www/localhost/htdocs/mantis-git/core/user_pref_api.php:135] | 21:38 |
| dhx_m | #3 UserPreferences->__get(language) called at [/var/www/localhost/htdocs/mantis-git/core/user_pref_api.php:488] | 21:38 |
| dhx_m | #4 user_pref_get_language(1) called at [/var/www/localhost/htdocs/mantis-git/core/lang_api.php:104] | 21:38 |
| dhx_m | #5 lang_get_default() called at [/var/www/localhost/htdocs/mantis-git/core/error_api.php:83] | 21:38 |
| paul_ | when'd you generate that | 21:39 |
| dhx_m | user_pref_api.php:488 should be $t_lang = $t_prefs->Get( 'language' ); | 21:42 |
| dhx_m | ? | 21:42 |
| paul_ | no doesn't matter | 21:43 |
| paul_ | or shouldn't | 21:43 |
| paul_ | __get gets called | 21:43 |
| dhx_m | well what is ->language | 21:43 |
| dhx_m | language = function? | 21:43 |
| paul_ | __get('language'); | 21:43 |
| dhx_m | but it is just $t_prefs->language | 21:44 |
| paul_ | i.e. 4 chars or something shorter then ->Get('language'); | 21:44 |
| paul_ | __get is a special overloaded function thingy in php | 21:44 |
| paul_ | hence the backtrace | 21:44 |
| dhx_m | the bug is fixed when I change it to Get(..) | 21:44 |
| paul_ | i.e. 2/3/ | 21:44 |
| dhx_m | the backtrace came from just before config_api.php:187 | 21:45 |
| paul_ | from doing what | 21:45 |
| dhx_m | going to the main page of my test bug tracker after your big merge :) | 21:45 |
| dhx_m | I notice that you use Get() at user_pref_api.php:474 as well | 21:46 |
| dhx_m | and in every other place, it seems to just use the direct $t_prefs->$t_pref_name approach | 21:47 |
| paul_ | it should be irrelevant which we use | 21:47 |
| dhx_m | well the backtrace shows that config_get is being called with the first two arguments being null | 21:48 |
| dhx_m | and that matches the error messages I'm seeing at config_api.php:187 | 21:49 |
| dhx_m | not too sure why | 21:49 |
| * paul_ just sighs | 21:55 | |
| dhx_m | I'm not too familiar with OO PHP | 21:56 |
| dhx_m | a backtrace within __get returns: | 21:56 |
| dhx_m | #0 UserPreferences->__get(language) called at [/var/www/localhost/htdocs/mantis-git/core/user_pref_api.php:489] | 21:56 |
| dhx_m | #1 user_pref_get_language(1) called at [/var/www/localhost/htdocs/mantis-git/core/lang_api.php:104] | 21:57 |
| dhx_m | #2 lang_get_default() called at [/var/www/localhost/htdocs/mantis-git/core/error_api.php:83] | 21:57 |
| dhx_m | echoing the argument to __get returns null | 21:57 |
| paul_ | globals dont work in the auto type functions | 22:02 |
| dhx_m | not too sure what that means :) | 22:04 |
| dhx_m | account_prefs_page.php generates a ton of the same errors | 22:05 |
| dhx_m | is it ok for you? | 22:05 |
| dhx_m | maybe this is a PHP 5.3 thing where I use PHP 5.2.9? | 22:06 |
| paul_ | I think i've fixed it | 22:07 |
| dhx_m | I'll test for you if needed :) | 22:09 |
| paul_ | there | 22:11 |
| CIA-61 | Mantisbt: paul * r2f4565846186 /core/user_pref_api.php: Fix: global variables can't be used within overloaded functions | 22:11 |
| CIA-61 | Mantisbt: hickseydr * r229a6848f6eb / (bug_stick.php core/html_api.php lang/strings_english.txt): Add Stick/Unstick button to html_buttons_view_bug_page | 22:15 |
| CIA-61 | Mantisbt: hickseydr * re55c7c8c0ddd / (512 files in 27 dirs): Merge branch 'master' into 10268 | 22:15 |
| dhx_m | that fixed it, thanks :) | 22:16 |
| CIA-61 | Mantisbt: hickseydr * rd7d911b0a3af /bug_stick.php: Remove trailing white space | 22:16 |
| CIA-61 | Mantisbt: hickseydr * r1a96b94b7d5d /bug_stick.php: No need to specify core path anymore | 22:16 |
| CIA-61 | Mantisbt: hickseydr * r8a246a481e6b / (bug_stick.php core/html_api.php lang/strings_english.txt): Merge branch '10268' | 22:16 |
| CIA-61 | Mantisbt: hickseydr * rcf7e430979a3 /core/user_pref_api.php: Merge branch 'master' of git@mantisbt.org:mantisbt | 22:16 |
| paul_ | wow | 22:16 |
| paul_ | bugstick? | 22:16 |
| dhx_m | uh 512 files?! | 22:16 |
| dhx_m | something went wrong | 22:16 |
| dhx_m | or maybe that is ok | 22:17 |
| paul_ | yep | 22:17 |
| dhx_m | just looks scary :) | 22:17 |
| dhx_m | it'd probably be better to rebase those small branches instead | 22:18 |
| * paul_ thinking about bugstick | 22:18 | |
| paul_ | anyway | 22:18 |
| dhx_m | that's a new stick/unstick button | 22:18 |
| dhx_m | next to monitor/unmonitor | 22:18 |
| paul_ | yea | 22:18 |
| paul_ | i'm thinking bout that :P | 22:18 |
| paul_ | incidently | 22:18 |
| paul_ | # helper_ensure_post(); | 22:19 |
| * paul_ tuts | 22:19 | |
| paul_ | pls commit fixed code :P | 22:19 |
| dhx_m | it is a direct copy of bug_monitor.php | 22:19 |
| dhx_m | not sure whether it is safe to remove that | 22:20 |
| dhx_m | if so, it needs to be done in both files :) | 22:20 |
| dhx_m | it was victor's fault :p | 22:20 |
| paul_ | we're supposed to be using some new api :P | 22:20 |
| dhx_m | so are there upgrades to make to use your new API? | 22:21 |
| paul_ | not my new api | 22:21 |
| paul_ | :P | 22:22 |
| dhx_m | :) | 22:26 |
| * paul_ carries on testing utf8 api's | 22:33 | |
| dhx_m | we should really replace images/* with new icons | 22:35 |
| dhx_m | a lot of those icons aren't free | 22:35 |
| paul_ | I was thinking of moving to png | 22:35 |
| dhx_m | and they're all .gif! :o | 22:35 |
| dhx_m | yep | 22:35 |
| dhx_m | I guess we don't currently use mime types for file uploads | 22:36 |
| mantisbot | New bug: Bug 10596 - jreese - open - assigned | 22:54 |
| mantisbot | New bug: Allow plugins to define new column typess - http://www.mantisbt.org/bugs/view.php?id=10596 | 22:54 |
| mantisbot | New bug: Bug 10597 - dhx - open - assigned | 22:54 |
| mantisbot | New bug: Remove hardcoded use of ADMINISTRATOR constant - http://www.mantisbt.org/bugs/view.php?id=10597 | 22:54 |
| mantisbot | New bug: Bug 10598 - dhx - open - assigned | 22:59 |
| mantisbot | New bug: Shorten HTML button strings shown when viewing/updating a bug - http://www.mantisbt.org/bugs/view.php?id=10598 | 22:59 |
Generated by irclog2html.py