| ../irclogs/#mantishelp.2009-07-05.log | ||
| --- scribe started --- | 00:00 | |
| * paul_ slaps vb123 | 00:48 | |
| vb123 | paul_: why? | 00:49 |
|---|---|---|
| paul_ | 18:52 < CIA-17> Mantisbt: vboctor master-1.2.x * rbc945ed9eb4c /file_download.php: Fixes #10135: Downloading large attachments results in Internal Server Error - 500. | 00:52 |
| paul_ | you miss the point | 00:52 |
| paul_ | and potentially break stuff with that commit ;/ | 00:52 |
| paul_ | the problem is an out of memory error | 00:53 |
| paul_ | so isn't affected by ob_end_flush | 00:53 |
| vb123 | why would it break stuff? | 00:53 |
| paul_ | calling ob_end_flush at that point potentially breaks stuff as we start >1 ob handler | 00:53 |
| paul_ | one of which handles gzip | 00:53 |
| paul_ | anyway, gonna try and fix completely | 00:54 |
| vb123 | thanks. | 01:04 |
| CIA-17 | Mantisbt: vboctor * rf94f4df5f621 / (10 files in 3 dirs): Fixes #10681: Print issue page is not consistent with View Issue page relating to version handling. | 02:28 |
| vb123 | dhx_m: I just checked in bug #10681 which has some cleanup for versions display across several page + refactoring on show dates logic. Have a look at the changes when you get a chance. | 02:37 |
| mantisbot | Bug 10681 - vboctor - fixed - resolved | 02:37 |
| mantisbot | Print issue page is not consistent with View Issue page relating to version handling - http://www.mantisbt.org/bugs/view.php?id=10681 | 02:38 |
| * vb123 wondering what inherit_global flag on the projects is used for. | 04:03 | |
| dhx_m | vb123: thanks, your version cleanup is good :) | 07:21 |
| vb123 | dhx_m, I did some more changes to use ids instead. | 07:26 |
| dhx_m | what would be nice is converting the version rows array into an associative array | 07:33 |
| dhx_m | so it becomes O(n) lookup for a version | 07:33 |
| dhx_m | although I imagine it'd have to be in the format: | 07:34 |
| dhx_m | versions[project_id][version_string] | 07:34 |
| dhx_m | but I guess that could come later as part of a change to store versions as IDs in the database as opposed to strings | 07:35 |
| dhx_m | or is that what you also fixed? | 07:35 |
| dhx_m | nooo, bad time for mantisbt.org to die | 07:44 |
| paul_ | moo | 10:21 |
| paul_ | dhx_m: ? | 10:22 |
| dhx_m | paul_: hey | 10:54 |
| paul_ | lo | 10:54 |
| paul_ | you know your previous commit | 10:55 |
| paul_ | could you try just using rawurlencode insted | 10:55 |
| dhx_m | well not entirely, no | 10:55 |
| dhx_m | I put a URL in the comments in the code that explains it better | 10:56 |
| paul_ | well, other projects just use rawurlencode for IE | 10:56 |
| dhx_m | I gather it is incorrect for browsers to use urlencoded filename attributes? | 10:59 |
| dhx_m | see http://greenbytes.de/tech/tc2231/#attwithfnrawpctenclong | 11:01 |
| dhx_m | and the one above that, http://greenbytes.de/tech/tc2231/#attwithfnrawpctenca | 11:01 |
| paul_ | hmmmm | 11:26 |
| paul_ | dhx_m: I've found something to break :) | 11:28 |
| dhx_m | paul_: woohoo! :) | 11:29 |
| dhx_m | what's breaking then :p | 11:29 |
| paul_ | well | 11:30 |
| paul_ | compressapi | 11:30 |
| paul_ | :) | 11:30 |
| paul_ | although it's confusing | 11:35 |
| paul_ | in theory | 11:35 |
| paul_ | we can replace compress_api with 1 line | 11:35 |
| paul_ | aka | 11:35 |
| paul_ | ini_set('zlib.output_compression', true); | 11:35 |
| dhx_m | lol | 11:35 |
| dhx_m | I haven't looked at compress_api yet but by the sounds of things it doesn't appear to be overly useful | 11:36 |
| dhx_m | IMO compression is the job of the web server or disk filesystem | 11:36 |
| paul_ | now to read php source code ;( | 11:36 |
| paul_ | MF53: - Fixed bug #45202 (zlib.output_compression can not be set with ini_set() | 11:38 |
| paul_ | # This is fixed in HEAD already. :) | 11:38 |
| paul_ | ahh | 11:38 |
| paul_ | so from http://cvs.php.net/viewvc.cgi/php-src/ext/zlib/zlib.c?r1=1.183.2.6.2.11&r2=1.183.2.6.2.12 | 11:38 |
| paul_ | if php >= 5.2.10 || php >= 5.3.0 | 11:39 |
| paul_ | if php >= 5.2.10 || php >= 5.3.0 || php >= 6.0 | 11:39 |
| paul_ | we can call ini_set | 11:39 |
| paul_ | else | 11:39 |
| paul_ | we fallback to the old (slower) behaviour | 11:39 |
| dhx_m | ah ha :) | 11:42 |
| dhx_m | does safe mode prevent people from using ini_set though? | 11:42 |
| paul_ | safemode is removed in php6 | 11:43 |
| dhx_m | hooray! :) | 11:48 |
| paul_ | but yea | 11:52 |
| paul_ | by supporting old php versions | 11:52 |
| paul_ | we end up with multiple code paths ;/ | 11:52 |
| dhx_m | yeah :( | 11:52 |
| dhx_m | any thoughts on when PHP 6 may be expected>? | 11:52 |
| paul_ | never? :) | 11:52 |
| dhx_m | are we talking this year... next year...? | 11:52 |
| dhx_m | lol ok my 3rd option was "when Perl 6 is released" :p | 11:53 |
| paul_ | php6 was unicode | 11:53 |
| paul_ | unicode status of php has been 70% for about 2 years | 11:53 |
| paul_ | and stuck around there | 11:53 |
| dhx_m | hmmm | 11:53 |
| dhx_m | people still develop PHP6? | 11:53 |
| paul_ | and new features have been put into 5.3 etc :) | 11:53 |
| dhx_m | or is it looking rather dead? | 11:53 |
| paul_ | well, the zlib ini_Set thing was a backport from 6... | 11:54 |
| dhx_m | do they use git? | 11:55 |
| paul_ | no | 11:55 |
| paul_ | cvs | 11:55 |
| dhx_m | AHHHHHHHHHHH CVS?!?!? | 11:55 |
| paul_ | they are planning on moving from cvs to svn | 11:55 |
| dhx_m | PHP 6 won't be out until 2020 at that rate | 11:55 |
| paul_ | however | 11:55 |
| dhx_m | lol | 11:55 |
| dhx_m | ... to SVN? | 11:55 |
| paul_ | the php5.3 release manager | 11:55 |
| paul_ | sync's a git repo against cvs | 11:55 |
| dhx_m | still... what sort of programmers would want to help a project that still uses CVS | 11:58 |
| paul_ | any? | 11:58 |
| dhx_m | fairly frustrating to use if you ask me | 11:58 |
| dhx_m | IMO it is usually a sign of an unhealthy project | 11:58 |
| paul_ | remember | 11:59 |
| dhx_m | same for projects that don't have an issue tracker, etc | 11:59 |
| paul_ | they've got a fair chunk of stuff using it | 11:59 |
| paul_ | i.e. converting from cvs->svn is apparently a 3day task for the conversion iirc | 11:59 |
| dhx_m | yeah that's not too bad | 11:59 |
| dhx_m | future investment :) | 11:59 |
| dhx_m | although I have no idea why they'd pick SVN | 12:00 |
| dhx_m | unless their development community all has commit access | 12:00 |
| paul_ | http://git.chinstrap.eu/ | 12:00 |
| dhx_m | and they all commit in real time | 12:00 |
| dhx_m | I like one commit I see there with the description: "This is PHP 6 - if this ... ever gets out | 12:04 |
| dhx_m | " :p | 12:04 |
| dhx_m | I'm not seeing much activity in their repo? | 12:08 |
| dhx_m | unless php-src is not where I should be looking | 12:08 |
| paul_ | dhx_m: http://git.chinstrap.eu/php/php-tsrm-ze2.git/ | 12:09 |
| Chris1- | I want mantis to send a email if there is a new entrey. | 12:09 |
| paul_ | you want that one | 12:09 |
| dhx_m | hmm that's easier to read than viewcvs :) | 12:11 |
| dhx_m | now if only comments weren't "Update" or "Fix" | 12:11 |
| dhx_m | (one thing that really gets to me is non-descriptive titles for emails, bugs or commits :p) | 12:12 |
| paul_ | right | 12:14 |
| paul_ | wanna review a patch? ;p | 12:14 |
| dhx_m | hell yeah! :p | 12:14 |
| paul_ | http://mantisbt.pastebin.com/m5f151170 | 12:16 |
| paul_ | from core.php/compress_api.php | 12:17 |
| dhx_m | ok | 12:19 |
| dhx_m | malformed patch? | 12:22 |
| dhx_m | what command do I use to apply it? | 12:23 |
| paul_ | I expected you to just read it | 12:23 |
| dhx_m | oh ok | 12:23 |
| dhx_m | looks good then :) | 12:23 |
| * paul_ is making a mess though ;( | 12:23 | |
| dhx_m | at least there isn't 400 expressions on the same line in your patch :p | 12:24 |
| dhx_m | my only comment is that you've used // to comment on some lines and # on others | 12:24 |
| dhx_m | my other question is more related to the entire Mantis codebase... and why we seem to invert expressions | 12:25 |
| dhx_m | so... if (OFF = ... ) instead of if ( ... = OFF ) | 12:25 |
| dhx_m | of course, == :) | 12:25 |
| dhx_m | also core.php:145 calls ob_start( 'compress_handler' ) so that'd need to change too | 12:27 |
| dhx_m | oops | 12:27 |
| dhx_m | I should read better, you already fixed that :p | 12:27 |
| paul_ | seems i need to define a COMPRESSION_DSIABLED varaible :( | 12:31 |
| dhx_m | why? | 12:32 |
| paul_ | or a global | 12:32 |
| paul_ | so I can turn it off ;/ | 12:32 |
| dhx_m | g_compress_html? | 12:33 |
| paul_ | constant would be better then a global? | 12:33 |
| dhx_m | not in this case, because you'd want the user to customize it? | 12:33 |
| paul_ | i'm trying to fix my version of download | 12:34 |
| dhx_m | but use config_get_global | 12:34 |
| paul_ | which needs it disabled :) | 12:34 |
| dhx_m | not config_get? | 12:34 |
| paul_ | no | 12:34 |
| dhx_m | well this doesn't make sense to be on a per-project basis? | 12:34 |
| paul_ | different issue :) | 12:34 |
| paul_ | i'm trying to do chunked downloads | 12:34 |
| paul_ | to fix memory limit with large downloads | 12:35 |
| paul_ | but you can't call ob_flush if zlib.output_compression is on | 12:35 |
| paul_ | in addition, other projects turn that off for IE as a 'bugfix' | 12:35 |
| paul_ | and it seems you can't do | 12:35 |
| paul_ | ini_set(on); | 12:35 |
| paul_ | ini_set(off); | 12:35 |
| paul_ | header(); | 12:35 |
| paul_ | as when you turn it on it sets itself up permanently | 12:35 |
| dhx_m | ah | 12:37 |
| dhx_m | you could ini_set a new script timeout? | 12:37 |
| paul_ | spot something strange with http://mantisbt.pastebin.com/m119787cf | 12:38 |
| dhx_m | and instead of sending a new chunk... increase the timeout as required? | 12:38 |
| dhx_m | strlen() on binary data... = bad? | 12:39 |
| dhx_m | that's the first thing I notice | 12:39 |
| dhx_m | who is to say that binary files don't include string termination chars (0x00) :p | 12:39 |
| dhx_m | another idea I had was to allow the user to specify a writeable public folder where Mantis can dump files for the user to read? | 12:40 |
| dhx_m | but I guess if you wanted that, you'd just set that up in Mantis anyway (instead of storing attachments in the database) | 12:41 |
| paul_ | cool | 12:52 |
| paul_ | I just made a file that hangs my av | 12:52 |
| dhx_m | haha | 12:53 |
| paul_ | or not | 12:53 |
| paul_ | hmm | 12:53 |
| paul_ | do we want to support download accelerators? | 13:01 |
| dhx_m | hmmm | 13:34 |
| dhx_m | we'd want to support resuming | 13:34 |
| dhx_m | multi-threaded downloads less so | 13:34 |
| dhx_m | although I guess it'd be nice to support that too :) | 13:34 |
| paul_ | ;P | 13:37 |
| dhx_m | I just think the ideas floating around about using the new zip extension to PHP to compress files as they're uploaded to the server is stupid | 13:45 |
| dhx_m | (no offence) | 13:45 |
| dhx_m | makes no sense to me | 13:46 |
| paul_ | hmm? | 13:53 |
| dhx_m | well there was a ticket/mailing list post about the possibility of zipping all attachments as they arrive on the server | 14:01 |
| paul_ | when? | 14:07 |
| paul_ | a while ago? | 14:09 |
| dhx_m | a week or two ago | 14:09 |
| dhx_m | I'd ignore it :p | 14:09 |
| dhx_m | your idea is much better :p | 14:10 |
| dhx_m | the limiting factor is always going to be CPU cycles or bandwidth rather than disk space | 14:10 |
| [KK]Kirill | hi all | 14:20 |
| [KK]Kirill | git.mantisbt.org not work again | 14:21 |
| dhx_m | yeah I wouldn't say mantisbt.org is the most stable server I'd seen :p | 14:22 |
| [KK]Kirill | ^) | 14:23 |
| [KK]Kirill | :) | 14:23 |
| [KK]Kirill | John not exists? | 14:23 |
| paul_ | well | 14:25 |
| paul_ | dhx_m: people keep rebooting the box when it dies | 14:25 |
| paul_ | making it hard to diagnose | 14:25 |
| dhx_m | paul_: is it some runaway processes using 100% CPU? | 14:26 |
| paul_ | apache ;p | 14:26 |
| dhx_m | paul_: it sounds to me like it could be a problem with memory usage? | 14:26 |
| dhx_m | maybe some bot is coming along and hitting the server too hard at once? | 14:26 |
| paul_ | yea | 14:27 |
| paul_ | it's called msn | 14:27 |
| dhx_m | bing? :) | 14:27 |
| paul_ | ping | 14:27 |
| [KK]Kirill | ^) | 14:27 |
| paul_ | pong | 14:27 |
| [KK]Kirill | :) | 14:27 |
| dhx_m | msn => live search => bing => failure? :p | 14:27 |
| paul_ | Content-Description: Download Data' | 14:42 |
| paul_ | whats that? | 14:42 |
| dhx_m | that doesn't look good | 14:44 |
| dhx_m | where did that come from? | 14:44 |
| paul_ | i mean | 14:44 |
| paul_ | whats that header | 14:44 |
| dhx_m | doesn't look legit to me? | 14:44 |
| dhx_m | oh | 14:44 |
| dhx_m | I'm thinking of Content-Disposition | 14:44 |
| dhx_m | The ability to associate some descriptive information with a given | 14:46 |
| dhx_m | body is often desirable. For example, it may be useful to mark an | 14:46 |
| dhx_m | "image" body as "a picture of the Space Shuttle Endeavor." Such text | 14:46 |
| dhx_m | may be placed in the Content-Description header field. This header | 14:46 |
| dhx_m | field is always optional. | 14:46 |
| dhx_m | description := "Content-Description" ":" *text | 14:46 |
| dhx_m | The description is presumed to be given in the US-ASCII character | 14:46 |
| dhx_m | set, although the mechanism specified in RFC 2047 may be used for | 14:46 |
| dhx_m | non-US-ASCII Content-Description values. | 14:46 |
| dhx_m | most likely it only supports ASCII | 14:46 |
| dhx_m | given that most browsers don't support the RFC extensions for Unicode text properly | 14:47 |
| [KK]Kirill | I talk John, that I want events for work with attachments | 14:48 |
| [KK]Kirill | (rename, revoke to story, etc) | 14:49 |
| [KK]Kirill | plugin's events | 14:49 |
| paul_ | dhx_m: so drop that header? | 15:18 |
| dhx_m | paul_: it's not bad | 15:20 |
| dhx_m | paul_: but if all we're doing is saying it is "Download Data" we're not really making any use of it | 15:20 |
| paul_ | testing time :) | 15:21 |
| dhx_m | actually I think it can be dropped | 15:21 |
| dhx_m | we don't have attachment descriptions anyway | 15:21 |
| paul_ | if ( in_array( utf8_strtolower( file_get_extension($t_filename) ), $t_inline_files ) ) { | 15:21 |
| paul_ | $t_disposition = ''; //'inline;'; | 15:21 |
| paul_ | whats with that | 15:21 |
| paul_ | } else { | 15:22 |
| paul_ | inline commented out? | 15:22 |
| paul_ | also | 15:22 |
| dhx_m | no need for inline, it's the default | 15:22 |
| dhx_m | used for display images? | 15:22 |
| dhx_m | ie. inline display of attachments from the database | 15:22 |
| paul_ | dhx_m: you have some download accelerators? | 17:43 |
| * paul_ prods dhx_m | 19:59 | |
| CIA-17 | Mantisbt: vboctor * re68de4159cae /core/bug_api.php: Fixes #10685: Undefined variable: t_bug_id on bug creation. | 21:00 |
| CIA-17 | Mantisbt: vboctor master-1.2.x * rd95b85d139be /core/bug_api.php: Fixes #10685: Undefined variable: t_bug_id on bug creation. | 21:00 |
| Tuxman | Hi can any provide help ? | 23:59 |
| Tuxman | SYSTEM WARNING: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /var/www/vhosts/.../config_inc.php:8) | 23:59 |
Generated by irclog2html.py