| ../irclogs/#mantishelp.2009-12-19.log | ||
| --- scribe started --- | 00:00 | |
| dhx_m | yeah that's fine... just so long as there is an easy way to keep track of patches made | 00:00 |
|---|---|---|
| dhx_m | so it is easy to upgrade to newer versions in the future | 00:00 |
| paul__ | function RowLock($tables,$where,$flds='1 as ignore') | 00:01 |
| * paul__ wponders wtf '1 as ignore' means | 00:01 | |
| dhx_m | lol | 00:04 |
| dhx_m | aren't we scrapping ADOdb anyway? | 00:04 |
| paul__ | oh yes | 00:04 |
| dhx_m | please :p | 00:04 |
| paul__ | if ($this->_connectionID && isset($schema)) $this->Execute("SET SCHEMA=$schema"); | 00:09 |
| paul__ | we need a copy of db2 | 00:11 |
| paul__ | I need to check | 00:14 |
| paul__ | but i think 5.10 might actually add a performance optimisation to adodb for us | 00:14 |
| paul__ | in terms of ram usage | 00:14 |
| CIA-27 | Mantisbt: paul * rcf8c0d5d6b9d /library/adodb/drivers/ (8 files): Revert "Apply PHP 5.3 compatibility patch to ADOdb 5.10" | 00:16 |
| CIA-27 | Mantisbt: paul * r73ce41d66a02 /library/adodb/drivers/ (8 files): Revert "Revert "Apply PHP 5.3 compatibility patch to ADOdb 5.10"" | 00:16 |
| CIA-27 | Mantisbt: paul * r6a8991c79724 /library/ (169 files in 18 dirs): Revert "Update PHPMailer to v5.1 and ADOdb to v5.10" | 00:16 |
| CIA-27 | Mantisbt: paul * r7f2fba967c3f /library/phpmailer/ (5 files in 2 dirs): Update phpmailer to 5.1 | 00:16 |
| CIA-27 | Mantisbt: paul * r1e42a4de7e37 /library/ (169 files in 18 dirs): Revert "Revert "Update PHPMailer to v5.1 and ADOdb to v5.10"" | 00:16 |
| CIA-27 | Mantisbt: paul * r69aa96a3a347 /library/adodb/ (89 files in 6 dirs): adodb 5.10 | 00:16 |
| paul__ | there | 00:16 |
| dhx_m | ummm | 00:17 |
| dhx_m | how come there are 2 reverts for each? | 00:17 |
| paul__ | cause git sucks | 00:17 |
| paul__ | :P | 00:17 |
| dhx_m | pffft noob :) | 00:18 |
| dhx_m | still using CVS? :p | 00:18 |
| paul__ | now lets see | 00:18 |
| dhx_m | ohhh I see | 00:19 |
| dhx_m | you reverted a revert :p | 00:19 |
| dhx_m | so it's not actually 2 | 00:19 |
| dhx_m | makes sense | 00:20 |
| CIA-27 | Mantisbt: paul * rfb8383a2e7c6 /core/compress_api.php: | 00:25 |
| CIA-27 | Mantisbt: Fix whitespace introduced on 20th September by commit | 00:25 |
| CIA-27 | Mantisbt: http://git.mantisforge.org/w/mantisbt.git?a=blobdiff;f=core/compress_api.php;fp=core/compress_api.php;hb=61804a9da622dd0519fea853924bdab5bddbd933;hpb=f657c277db6b00cd2f63cb43a4c506acc4095482 | 00:25 |
| CIA-27 | Mantisbt: paul * r3ab636f75fc7 /core/plugin_api.php: We automatically load classes now so no need to require. | 00:25 |
| CIA-27 | Mantisbt: paul * r4a99d8ae8542 / (5 files in 2 dirs): Rename and move constants for filter api - Neither John/myself believe this is something that a user would customise. | 00:25 |
| CIA-27 | Mantisbt: paul * r3b4c2f866b1e /core/html_api.php: HTML Formatting | 00:25 |
| CIA-27 | Mantisbt: paul * r6f36367ebed2 / (core.php core/database_api.php): Move db connection out of database api to core.php | 00:25 |
| CIA-27 | Mantisbt: paul * ra87a5c5e8308 /tests/test.php: Remove old/pointless test (doesn't just visiting /admin do this) | 00:26 |
| CIA-27 | Mantisbt: paul * raf56c8d9b4e3 /core/ldap_api.php: Update ldap escape string - according to MS docs we should escape / and \x00 | 00:26 |
| CIA-27 | Mantisbt: paul * r13ce69e4587f /core/install_helper_functions_api.php: Add a function to allow 'null' schema updates | 00:26 |
| dhx_m | NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO :p | 00:26 |
| paul__ | ? | 00:26 |
| dhx_m | ah I thought this was your years worth of commits all at once lol :D | 00:26 |
| paul__ | no | 00:26 |
| paul__ | heh | 00:26 |
| paul__ | year? | 00:26 |
| dhx_m | do you use git CLI? | 00:26 |
| paul__ | mm? | 00:26 |
| dhx_m | ie. from the command line | 00:27 |
| paul__ | ya | 00:27 |
| dhx_m | and use vim for typing commit messages? | 00:27 |
| paul__ | erm | 00:27 |
| paul__ | dunno | 00:27 |
| paul__ | maybe | 00:27 |
| dhx_m | git commit -a | 00:27 |
| dhx_m | is that roughly what you'd use? | 00:27 |
| paul__ | probably | 00:27 |
| paul__ | well not -a | 00:27 |
| dhx_m | the reason I ask is that all your commit messages are single lines | 00:28 |
| dhx_m | and git treats the first line as a subject | 00:28 |
| dhx_m | rather than a message | 00:28 |
| paul__ | ahh | 00:28 |
| paul__ | windows probably | 00:28 |
| dhx_m | the ideal format for a commit message (as typed into vim/whatever when git asks you for a commit message) is: | 00:28 |
| dhx_m | Subject | 00:28 |
| dhx_m | {blank line} | 00:28 |
| dhx_m | Your message here. | 00:28 |
| dhx_m | Blah | 00:28 |
| dhx_m | Blah | 00:28 |
| dhx_m | etc | 00:28 |
| dhx_m | and the subject usually has to be short or git will complain (via vim) that the first line is too long | 00:29 |
| paul__ | ahh | 00:33 |
| paul__ | actually | 00:36 |
| paul__ | i use mysqgit | 00:36 |
| paul__ | which as it's own thing | 00:36 |
| dhx_m | ah ok | 00:39 |
| CIA-27 | Mantisbt: paul * rc6109d3df715 /admin/check.php: Update check.php to reflect that adodb 5.1 is now the current version | 00:41 |
| CIA-27 | Mantisbt: paul * rc3338d341fdf /library/adodb/adodb.inc.php: Indicate mantisbt version of adodb in version string | 00:41 |
| paul__ | how come plugins dont run? ;/ | 00:41 |
| dhx_m | hmm? | 00:41 |
| paul__ | in 1.3.0dev | 00:41 |
| dhx_m | "dont' run"? | 00:41 |
| paul__ | $this->requires = array( | 00:42 |
| paul__ | 'MantisCore' => '1.2.0', | 00:42 |
| paul__ | ); | 00:42 |
| paul__ | well | 00:42 |
| dhx_m | they worked for me yesterday :) | 00:42 |
| paul__ | we dont meed that requirement ;/ | 00:42 |
| dhx_m | afaik it should work | 00:42 |
| dhx_m | it means 1.2.0 or higher | 00:42 |
| paul__ | I get a red against the requirements tbh | 00:43 |
| dhx_m | you are probably missing dependencies? | 00:45 |
| paul__ | 1.2.0 :P | 00:45 |
| paul__ | MantisCore 1.2.0 | 00:45 |
| paul__ | are you on 1.3.0dev? | 00:45 |
| dhx_m | yes | 00:45 |
| paul__ | hmm | 00:54 |
| dhx_m | oh | 00:54 |
| dhx_m | you can't remove MantisCoreFormatting anymore | 00:54 |
| dhx_m | it is a compulsory plugin | 00:54 |
| paul__ | cool | 00:55 |
| dhx_m | so if you upgraded Mantis | 00:55 |
| dhx_m | and you previously had it disabled | 00:55 |
| dhx_m | it may be disabled forever? | 00:55 |
| paul__ | it's not in a previous release | 00:55 |
| paul__ | :P | 00:55 |
| dhx_m | wait "Mantis Formatting" isn't compulsory | 00:55 |
| paul__ | but i can't enable graph | 00:55 |
| dhx_m | Mantis Core is | 00:55 |
| dhx_m | I can :p | 00:55 |
| paul__ | ahh | 00:55 |
| paul__ | mantis core isn't installed | 00:56 |
| paul__ | hmmmmmmmm | 00:56 |
| dhx_m | do you have Mantis Core installed? | 00:56 |
| paul__ | no :P | 00:56 |
| nuclear_eclipse | MantisCore is a fake plugin initialized by plugin API to allow dependencies againt core of Mantis -- it's not a real plugin, and there's no file anywhere in Git for it | 01:22 |
| nuclear_eclipse | so if there's no MantisCore entry in Manage Plugins, you've seriously borked the plugin system or something... | 01:23 |
| paul__ | :) | 01:23 |
| paul__ | there is | 01:23 |
| paul__ | it's not installed atm :P | 01:23 |
| nuclear_eclipse | that shouldn't be possible... | 01:23 |
| paul__ | i might have fiddled with something | 01:23 |
| nuclear_eclipse | arg | 01:24 |
| nuclear_eclipse | tell me why it seems like every time you get a weekend to work on Mantis, I'm afraid to make a stable release | 01:24 |
| paul__ | I mean | 01:25 |
| paul__ | in the db | 01:25 |
| nuclear_eclipse | there shouldnt be a db row for MantisCore | 01:25 |
| paul__ | I thought you put in mantiscore as a plugin? | 01:26 |
| nuclear_eclipse | no, it's just a fake entry in the plugin API that serves no purpose other than to be a placeholder for plugin dependencies | 01:27 |
| paul__ | hmm | 01:27 |
| paul__ | atm, on my dev box | 01:28 |
| paul__ | formatting shows as installed | 01:28 |
| paul__ | everything else aka 1.3.0dev as available | 01:28 |
| paul__ | and graph plugin doesn't show install action as it doesn't meet dependency of '1.2.0' apparently | 01:28 |
| nuclear_eclipse | paul__: I'll try to take a look when I get home | 01:30 |
| paul__ | i'm fairly sure I broke something in mysql | 01:31 |
| nuclear_eclipse | that's exactly why this whole patch-revert-revertrevert-revert thing makes me really nervous... | 01:34 |
| paul__ | it's been like this for 2-3 weeks now | 01:34 |
| paul__ | for me | 01:35 |
| paul__ | I first noticed it when we changed to 1.3.0dev | 01:35 |
| paul__ | as version string in trunk | 01:35 |
| paul__ | http://www.mantisbt.org/bugs/view_all_bug_page.php shows an error for me | 01:36 |
| nuclear_eclipse | paul__: no errors when I view it | 01:39 |
| paul__ | I suspect due to http://git.mantisbt.org/?p=mantisbt.git;a=commitdiff;h=60a4d24a794a81e98dc044ce42a9e4b8fa754111 | 01:39 |
| paul__ | or maybe not | 01:39 |
| paul__ | mmm | 01:39 |
| paul__ | my query ends with: | 01:40 |
| paul__ | AND ( ) | 01:40 |
| nuclear_eclipse | hmm | 01:40 |
| paul__ | but as i was just trying to navigate to the bugtracker | 01:40 |
| paul__ | I don't know what it's doing :P | 01:40 |
| paul__ | SELECT Count( DISTINCT mantis_bug_table.id ) as idcnt FROM mantis_bug_text_table, mantis_project_table, mantis_bug_table LEFT JOIN mantis_bugnote_table ON mantis_bug_table.id = mantis_bugnote_table.bug_id LEFT JOIN mantis_bugnote_text_table ON mantis_bugnote_table.bugnote_text_id = mantis_bugnote_text_table.id WHERE mantis_project_table.enabled = ? AND mantis_project_table.id = mantis_bug_table.project_id AND ( mantis_bug_table | 01:40 |
| paul__ | it ends AND ( ) . | 01:40 |
| paul__ | if you get all of spam | 01:40 |
| nuclear_eclipse | pastebin the error? | 01:41 |
| paul__ | if( is_numeric( $t_search_term ) ) { | 01:41 |
| paul__ | can $t_search_term be non-numeric i.e. '',null or some string? | 01:41 |
| paul__ | in fact too late for me | 01:41 |
| paul__ | http://mantis.pastebin.com/m31af722b | 01:42 |
| nuclear_eclipse | can you permalink that to see what the search gpc params are? | 01:43 |
| paul__ | how? :P | 01:43 |
| nuclear_eclipse | nvm | 01:43 |
| nuclear_eclipse | I think I know how to solve that | 01:43 |
| paul__ | i must say though | 01:44 |
| paul__ | i'm really looking forward to see what features people back port from turnk to 1.2 | 01:45 |
| paul__ | right back in 10 hours | 01:50 |
| paul__ | nn | 01:50 |
| nuclear_eclipse | paul__ | 01:50 |
| nuclear_eclipse | http://mantis.pastebin.com/d713aab62 | 01:50 |
| nuclear_eclipse | I think that fixes the issue you had | 01:50 |
| nuclear_eclipse | does that seem reasonable? I cant test atm | 01:51 |
| kirillka | paul__: around? | 08:45 |
| kirillka | giallu: ? | 08:45 |
| giallu | can we please freeze the damn 1.2 branch? I propose a "get 2 other +1 to push the change" rule on it... | 08:59 |
| kirillka | giallu: lo | 09:00 |
| giallu | lo | 09:01 |
| kirillka | giallu: did you have test installation of mantis? | 09:01 |
| kirillka | giallu: I have notice in admin | 09:02 |
| kirillka | SYSTEM NOTICE | 09:02 |
| kirillka | Undefined variable: t_version_suffix | 09:02 |
| kirillka | Full path: /mantis/admin/index.php | 09:02 |
| kirillka | Line: 60 | 09:02 |
| giallu | I have but it's following the 1.2 branch | 09:05 |
| kirillka | I use last git | 09:06 |
| kirillka | and /admin/check.php?showall=1 | 09:12 |
| kirillka | SYSTEM NOTICE | 09:12 |
| kirillka | Undefined offset: 1 | 09:12 |
| kirillka | Full path: /mantis/admin/check.php | 09:12 |
| kirillka | Line: 73 | 09:12 |
| kirillka | VariableValueType | 09:13 |
| kirillka | p_descriptionChecking Config File Existsstring | 09:13 |
| kirillka | p_pass1boolean | 09:13 |
| kirillka | f_showall1integer | 09:13 |
| kirillka | VariableValueType | 09:13 |
| kirillka | 0Please use install.php to perform initial installation <a href="install.php">Click here</a>string | 09:13 |
| giallu | kirillka, I just swtiched to master and pulled, I can't see anything like that | 09:28 |
| kirillka | giallu: did you enabled system notice? | 09:29 |
| kirillka | $g_display_errors = array(E_NOTICE => 'halt',) | 09:29 |
| giallu | let's see | 09:30 |
| giallu | I have default values | 09:32 |
| giallu | for $g_display_errors | 09:32 |
| kirillka | and $g_show_detailed_errors= ON; fro dateled | 09:32 |
| kirillka | for detailed* | 09:33 |
| kirillka | I create patch, but I don't sure it's right | 09:36 |
| kirillka | giallu: Can you see my patch bug 11294 | 09:39 |
| kirillka | bot not work again http://www.mantisbt.org/bugs/view.php?id=11294 | 09:53 |
| mantisbot | Bug 11294 - Kirill - open - new | 10:56 |
| mantisbot | System notice in checking - http://www.mantisbt.org/bugs/view.php?id=11294 | 10:56 |
| paul__ | dhx_m: there? | 17:47 |
| paul__ | giallu_: moo | 18:52 |
| paul__ | nuclear_eclipse: did you managed to fix the sql error? :) | 19:41 |
| nuclear_eclipse | paul__: check backlog | 19:42 |
| paul__ | or more | 19:42 |
| paul__ | is it applied yet to mantisbt.org :P | 19:43 |
| nuclear_eclipse | I pasted a possible solution last night, but wanted you to doublecheck | 19:43 |
| paul__ | (i know the answer) :P | 19:43 |
| paul__ | well | 19:43 |
| paul__ | mm | 19:44 |
| paul__ | try applying that patch to mantisbt.org | 19:45 |
| paul__ | and i'll try logging in :P | 19:45 |
| nuclear_eclipse | paul__: applied | 19:46 |
| paul__ | well | 19:48 |
| paul__ | I get a page up now :) | 19:48 |
| paul__ | nuclear_eclipse: can we set up the mantis instance on mantisbt.org to require a user to reopen a resolved issue | 19:48 |
| paul__ | before commenting on it | 19:48 |
| nuclear_eclipse | I don't se why you're so bugged by that... | 19:49 |
| paul__ | because users might report a fix doesn't work | 19:49 |
| paul__ | that we might not see | 19:49 |
| nuclear_eclipse | well, the handler should get an email for it.. | 19:49 |
| nuclear_eclipse | if it's still an issue, the user should reopen it, if they don't it's their fault | 19:50 |
| paul__ | well | 19:50 |
| nuclear_eclipse | otherwise, there are plenty of useful cases where the user would want to post a comment without reopening the issue | 19:50 |
| paul__ | I have 1121 unread emails from mantis tracker :P | 19:50 |
| paul__ | I guess it's not a problem though | 19:50 |
| nuclear_eclipse | so a) reduce the amount of notifications you get, or b) read your email more often... | 19:51 |
| paul__ | as when we do a release whoever does release notes/closes issues should probably go through tracker anyway | 19:51 |
| paul__ | er | 19:56 |
| paul__ | did you look at whether you get the same issue as I do with pluigins? | 19:57 |
| nuclear_eclipse | not yet | 19:58 |
| nuclear_eclipse | what's the deal with the 1.2 branch now? | 20:00 |
| paul__ | ? | 20:00 |
| nuclear_eclipse | after all the garbage you two did last night? what's the status of the 1.2 branch? | 20:00 |
| paul__ | I was fixing adodb in turnk | 20:02 |
| paul__ | the adodb author has yet again proved he fails | 20:03 |
| paul__ | so there's a new feature in adodb 5.1 | 20:03 |
| paul__ | sqlite datadict | 20:03 |
| nuclear_eclipse | right, but adodb stuff got ported to 1.2, and I want to know where that leaves 1.2 | 20:03 |
| paul__ | is the sqlite data file in adodb? Ans: ofc not! | 20:03 |
| paul__ | well, I guess for 1.2 we just need to merge the lib changes in | 20:04 |
| paul__ | then the fix for version | 20:04 |
| nuclear_eclipse | can you please take care of that since I have no clue what needs to be done? | 20:04 |
| paul__ | I have no clue how we merge stuff to 1.2 | 20:04 |
| paul__ | or backport | 20:04 |
| nuclear_eclipse | either cherry-pick from master, or manually duplicate the commits | 20:05 |
| nuclear_eclipse | either that, or decide that we don't want the new adodb in 1.2 and revert it | 20:05 |
| nuclear_eclipse | either way, I need you to focus long enough to make sure that we have a solid/stable version of adodb in 1.2 so that I can coocdinate a release | 20:06 |
| paul__ | whats in trunk for lib/adodb should be fine to just copy/paste into 1.2 then | 20:07 |
| paul__ | then just cherry pick in | 20:07 |
| paul__ | http://git.mantisbt.org/?p=mantisbt.git;a=commitdiff;h=c3338d341fdfae9d8dbaf4670766abb96dc9739c | 20:07 |
| nuclear_eclipse | can you just please take care of it for me? | 20:07 |
| paul__ | http://git.mantisbt.org/?p=mantisbt.git;a=commitdiff;h=c6109d3df715c4e0e47ef057eedd9eca48efdafd | 20:07 |
| paul__ | ok | 20:08 |
| nuclear_eclipse | thank you Paul | 20:08 |
| nuclear_eclipse | I'll look into the plugin issue | 20:08 |
| paul__ | I assume 1.2master and trunk are quite different atm? | 20:09 |
| nuclear_eclipse | different enough I assume | 20:09 |
| paul__ | why have people merged every thing to 1.2 :( | 20:11 |
| paul__ | does dhx still check out on saturdays? | 20:43 |
| nuclear_eclipse | I dunno | 20:44 |
| paul__ | i'm still not happy with some of things that have been done in trunk since last rc | 20:45 |
| paul__ | and then backported to 1.2 :( | 20:45 |
| nuclear_eclipse | so hurry up and fix them :P | 20:45 |
| paul__ | you know i'm off work until 4th January from mid next week? :P | 20:47 |
| nuclear_eclipse | no I didn't | 20:47 |
| paul__ | schoo hols :P | 20:47 |
| paul__ | september->nov is always busy | 20:47 |
| dhx_m | paul__: there are always reasons for backporting (mostly due to requiring compatibility across versions for things like string translation) | 22:31 |
| paul__ | lo | 22:31 |
| nuclear_eclipse | hi dhx_m | 22:31 |
| dhx_m | nuclear_eclipse: hi | 22:31 |
| paul__ | hmm | 22:34 |
| paul__ | why does nigly build chage a config defaults inc.php.bak file? | 22:35 |
| dhx_m | .bak? | 22:35 |
| nuclear_eclipse | paul__: it shouldn't? | 22:46 |
| nuclear_eclipse | I've never seen it do that | 22:46 |
| paul__ | well I seem to have a file called | 22:52 |
| paul__ | config_Defaults_inc.php=bak | 22:52 |
| paul__ | in windows | 22:52 |
| nuclear_eclipse | no clue | 22:53 |
| paul__ | oh ffs | 23:33 |
Generated by irclog2html.py