| ../irclogs/#mantishelp.2010-01-08.log | ||
| --- scribe started --- | 00:00 | |
| dhx_m | paul_____ & nuclear_eclipse: I've optimised view_all_bug_page.php to reach 14.5-15 requests/second (dual core) | 03:35 |
|---|---|---|
| dhx_m | just by redoing the way we handle file inclusions | 03:35 |
| dhx_m | for comparison, I was getting 4 requests/second (dual core) before changes | 03:36 |
| nuclear_eclipse | dhx_m: with or without something like php-apc? | 04:28 |
| dhx_m | nuclear_eclipse: with xcache (before and after) | 04:28 |
| nuclear_eclipse | what's xcache? :P | 04:29 |
| dhx_m | nuclear_eclipse: not sure what would happen with xcache off, I'll try :) | 04:29 |
| dhx_m | it's another PHP optimiser written by the lighttpd people | 04:29 |
| nuclear_eclipse | ok | 04:29 |
| nuclear_eclipse | I already get pretty good results with php-apc on my vps install | 04:29 |
| nuclear_eclipse | dhx_m: how are you benchmarking? | 04:31 |
| dhx_m | ab2 (comes with apache2) | 04:31 |
| dhx_m | seeing how many times per second I can load some MantisBT pages | 04:32 |
| dhx_m | to see if my changes are good/bad :) | 04:32 |
| nuclear_eclipse | mind running that against my install at leetcode.net/mantis? | 04:32 |
| dhx_m | I don't have ab2 on my server, so it'll be bandwidth bound (not CPU bound) | 04:32 |
| dhx_m | as my home connection is slooow | 04:32 |
| nuclear_eclipse | ok, can you paste your ab2 command? | 04:32 |
| dhx_m | ab2 -n 100 -c 2 http://localhost/mantis/view_all_bug_page.php | 04:33 |
| dhx_m | change -c 2 to match the number of cores (or CPU threads, if you have an Intel CPU) | 04:33 |
| dhx_m | -n 100 is how many times to request the page | 04:33 |
| dhx_m | run it a few times to get an average IMO | 04:34 |
| dhx_m | the first one will be skewed as your PHP accelerator starts caching things | 04:34 |
| nuclear_eclipse | I'm getting about 25 req/s, with 4 cores on a small vps | 04:35 |
| dhx_m | sounds about right, that's ~6 requests/second/CPU | 04:37 |
| nuclear_eclipse | I'm actually topping 30 req/s on my other install at bugs.steelwow.com, which only uses one plugin, so that's probably a big difference | 04:37 |
| dhx_m | hmm :) | 04:37 |
| nuclear_eclipse | leetcode.net uses quite a few plugins for vcs, irc, etc | 04:38 |
| dhx_m | yeah that'd slow things down a bit | 04:38 |
| nuclear_eclipse | still performs reasonably well, considering memory and cpu constraints of running on a virtualised system | 04:39 |
| nuclear_eclipse | anywho | 04:40 |
| nuclear_eclipse | I gotta get some sleep | 04:40 |
| nuclear_eclipse | cheers | 04:40 |
| dhx_m | ok cya later :) | 04:41 |
| dhx_m | hmmm so there is no performance improvement | 10:58 |
| dhx_m | it's about a 40-50ms hit from what I'm seeing | 10:59 |
| dhx_m | but the upshot is that it puts us in a position to make decoupling easier (and the results much faster to see) | 10:59 |
| paul_____ | dhx_m: so slower? | 13:08 |
| paul_____ | i'm confused:P | 13:08 |
| paul_____ | is it faster or slow with require_api? | 13:08 |
| dhx_m | slower for me | 13:09 |
| dhx_m | but my OS caches stat() calls | 13:09 |
| dhx_m | however given that Mantis isn't going to run any more than 50 times per second or so | 13:09 |
| dhx_m | a few stat() calls won't hurt I don't think ;) | 13:10 |
| dhx_m | I'm sticking with require_api for now though | 13:10 |
| dhx_m | actually correction... | 13:10 |
| dhx_m | require_api is faster than require_once in a benchmark (10000 iterations) | 13:10 |
| dhx_m | but there really isn't anything in it | 13:10 |
| dhx_m | I suspect that benchmark is flawed like all others though ;) | 13:11 |
| dhx_m | I'll see if I can fix it | 13:11 |
| paul_____ | patch file ready soon? | 13:23 |
| paul_____ | bbiab | 13:23 |
| dhx_m | committing now ;) | 13:27 |
| dhx_m | just writing a message | 13:27 |
| dhx_m | 263 files changed, 6778 insertions(+), 3138 deletions(-) | 13:32 |
| dhx_m | paul_____: do you use APC... if so, I suspect lazy loading could have a large benefit? | 13:36 |
| CIA-22 | Mantisbt: hickseydr * r3ffc2fa4b174 / (202 files in 2 dirs): require_api/require_lib | 13:37 |
| dhx_m | DAMNIT | 13:37 |
| dhx_m | so it commits the wrong thing :( | 13:37 |
| CIA-22 | Mantisbt: hickseydr * rcf559e0d009b / (202 files in 2 dirs): Revert "require_api/require_lib" | 13:40 |
| dhx_m | that's better now | 13:40 |
| CIA-22 | Mantisbt: hickseydr * r2d5455cce290 / (263 files in 2 dirs): Use require_api/require_lib to pull in dependencies | 13:40 |
| CIA-22 | Mantisbt: hickseydr * r77f2e2ae91b8 / (348 files in 17 dirs): Fix capitalisation in header license comment | 13:48 |
| paul_____ | dhx_m: I thought you was gonna show me patch :P | 13:51 |
| paul_____ | as if i need to merge in comments stuff ;/ | 13:52 |
| dhx_m | I just did :p | 13:52 |
| paul_____ | :( | 13:52 |
| dhx_m | cherry-pick? | 13:52 |
| paul_____ | i.e. my approach last night was to revert your patch | 13:52 |
| paul_____ | run patch < | 13:52 |
| paul_____ | fix comments | 13:52 |
| dhx_m | comments don't need fixing | 13:52 |
| paul_____ | depends if phpdoc whinges | 13:53 |
| dhx_m | commenting every require_once is stupid | 13:53 |
| paul_____ | if phpdoc whinges, comments get fixed | 13:53 |
| dhx_m | I don't even think that is what phpdoc was complaining about | 13:53 |
| dhx_m | ? | 13:53 |
| paul_____ | nah it is ;p | 13:53 |
| paul_____ | as i've had this before :P | 13:53 |
| paul_____ | on a different note | 13:53 |
| paul_____ | -# MantisBT - a php based bugtracking system | 13:53 |
| paul_____ | +# MantisBT - A PHP based bugtracking system | 13:53 |
| paul_____ | I think we should replace 'bugtracking' with 'issue tracking' | 13:54 |
| dhx_m | I thought it was complaining about not knowing whether the master file comment belonged to the file or to the first line of code (in this case, require_once) | 13:54 |
| dhx_m | in time, I agree | 13:55 |
| dhx_m | we're not really ready to call MantisBT a proper "issue tracker" though IMO | 13:55 |
| paul_____ | we changed source from bug to issue ages ago | 13:56 |
| paul_____ | for whats visible to users ;p | 13:56 |
| paul_____ | MantisIT.org | 13:56 |
| paul_____ | heh | 13:56 |
| paul_____ | mm | 13:56 |
| paul_____ | hmmm | 13:56 |
| dhx_m | :) | 13:58 |
| CIA-22 | Mantisbt: hickseydr * rffb2a55f27f9 /proj_doc_page.php: Fix #11361: Allow 'bytes' to be localised on proj_doc_page.php | 14:00 |
| CIA-22 | Mantisbt: hickseydr master-1.2.x * r7b27c02aa7d2 /proj_doc_page.php: Fix #11361: Allow 'bytes' to be localised on proj_doc_page.php | 14:00 |
| CIA-22 | Mantisbt: hickseydr * rb9396c147802 /core/string_api.php: Fix #11358: Sort by dropdown in view filters shows column IDs, not names | 14:24 |
| CIA-22 | Mantisbt: hickseydr master-1.2.x * r6e8d2751ae30 /core/string_api.php: Fix #11358: Sort by dropdown in view filters shows column IDs, not names | 14:25 |
| paul_____ | so | 15:49 |
| paul_____ | dhx_m: *Sigh* | 15:57 |
| paul_____ | dhx_m: we need to call set_include_path.... | 15:57 |
Generated by irclog2html.py