Tuesday, 2010-01-26

../irclogs/#mantishelp.2010-01-26.log
--- scribe started ---00:00
dhx_mvb123: hi :)04:16
vb123hi dhx_m04:23
dawitayaon helper_api.php on line 188 on mantis-1.2.x that have the pt07:11
alemayohi07:23
alemayodhx_m: what do you think about this feature? http://git.mantisforge.org/w/mantisbt/gtz-et.git?a=shortlog;h=refs/heads/sub-categories  (gives you sub-category functionality, you just have to create categories with names of the form "master > sub")07:24
dhx_malemayo: hi07:27
dhx_malemayo: am I right in saying that your patch tries to allow the grouping of categories together?07:28
dhx_malemayo: why the need for json_enable()? Are you using AJAX to retrieve the category list?07:29
dhx_msorry, json_encode()07:29
dhx_mand I don't like: window.alert("not yet loaded");07:30
dhx_mis there another way of doing that?07:30
dhx_messentially Mantis needs to operate fine without Javascript07:30
dhx_mso every time you want to use Javascript, you've got to check if the use_javascript option is one07:30
dhx_m*ON07:30
alemayoyes, it tries to group categories07:38
alemayoI will fix that alert :)07:39
alemayoit's just debug code07:39
alemayothat patch does rely on javascript -- so maybe I should check the use_javascript flag and trigger an error that this option is not working without javascript ?07:40
dhx_mwhy is Javascript needed?07:41
dhx_mdo we have it in place already?07:41
dhx_mor are you adding it for performance reasons (don't load a huge category list unless really needed)?07:41
alemayoit is just a matter of usability07:42
alemayowe have a lot of categories, so we provide two comboboxes, first the master category is choosen, then -- via javascript --- the category box is filtered to just display that subcategories07:42
dhx_mah07:45
dhx_min that case, are you familiar with the xhtml AJAX stuff already built into Mantis?07:46
dhx_mit's best to use the same technique throughout the code instead of introducing different techniques at different points in the codebase07:46
dhx_mif that means we need to fix the existing AJAX implementation, then I'd be happy to do that :)07:46
dhx_mbut AFAIK the current AJAX implementation has to be concerned with things like security (ensuring a valid user is requesting information, etc)07:47
dhx_mso it can get complex07:47
CIA-22Mantisbt: alexander.menk master-1.2.x * rd1a69cd21e62 /core/html_api.php: Fix #11417: Allow EVENT_MENU_MAIN plugin events to return null08:02
CIA-22Mantisbt: alexander.menk * r321ac71de73e /core/html_api.php: Fix #11417: Allow EVENT_MENU_MAIN plugin events to return null08:02
dhx_malemayo: I've just had a look at issue-make-description-hideable and those changes will break quite a few areas of Mantis that will expect each issue to have a summary08:20
dhx_m(at least I imagine that'll be the case)08:20
alemayobrb ... have some presentation08:20
dhx_mok08:22
alemayore11:11
alemayodhx_m: concerning the AJAX stuff: I do not use ajax :) it just looks like that. josn_encode is used for the on-time transmission of the full category information that would otherwise appear in the category_id selectbox . there should not be any security implications11:13
dhx_mnuclear_eclipse: I'm working on a new HgWeb plugin for SourceIntegration... even though I'll never use it :p11:13
dhx_mnuclear_eclipse: HgWeb is for Mercurial BTW11:13
alemayodhx_m: concerning issue-make-description-hideable: most of the stuff looks ugly because there is no summary anymore --- but we did not notice anything really breaking (i.e. crashing ..) so far11:14
dhx_malemayo: yep I was concerned with things like email titles, CSV/print/Excel/etc exporting, relationship graphs, etc11:15
dhx_mthere are so many places we use the summary field11:15
alemayodhx_m: maybe we should just rename the summary field for our purpose :)11:15
alemayodhx_m: actually we start to use mantis to track everything in here ... all but not bugs :-)11:16
dhx_mI can't see why you wouldn't have a summary field :p11:16
alemayoit's none of my business :-)11:16
dhx_munless maybe everything you're tracking is done via IDs11:16
dhx_mie. you're using Mantis to track orders?11:16
dhx_mso all you care about is the order ID, customer, value, order date, shipment date, etc11:17
dhx_mnuclear_eclipse: there are a few differences to gitweb, such as no list of files added/removed/modified (you have to work it out from the diff itself (kind of ugly)11:20
alemayodhx_m: yes, one of our units that will use mantis is logistics, they will basically track orders11:29
dhx_myep, I see where you're coming from11:32
dhx_mideally we'd have a function (customisable?) to return a summary line on an issue11:32
dhx_mand that'd be used in emails, issue list page, twitter output, etc11:32
alemayoyes ...11:39
alemayogood idea so far :)11:40
alemayowith customizable function you mean function that calls an event :) ?11:40
dhx_mmaybe not for what I suggested11:43
dhx_mit'd be a little tricky11:43
dhx_mplugins overwriting each other, etc11:43
alemayonext question is, how to hide the bug_id :-)11:48
dhx_mnow that sounds like a fun task :p11:51
dhx_mit won't be possible to completely hide it11:51
dhx_mie. it has to be used in URLs11:51
dhx_mthere needs to be some way to uniquely identify each issue11:52
alemayoyes of course... the URLs are okay11:53
alemayoanyway ... there is already EVENT_DISPLAY_BUG_ID :)11:53
alemayoI can just make this one to return "" ... or a custom field or whatever11:54
alemayoshould work .. let's see11:54
* alemayo see's the next plugin comming .. "ReplaceBugIDByWhateverYouLike"11:55
alemayosoon we'll be dominating mantisforge :-)11:55
dhx_mhaha11:56
alemayohm11:59
alemayoanyway ... I told my boss half a year ago, that we should use mantis instead of excel sheets .. that's my gain now :)11:59
alemayonow mantis has to be as flexible as excel sheets *gg*12:00
alemayohttp://en.wikipedia.org/wiki/Eierlegende_Wollmilchsau :-)12:01
dhx_mlol12:06
dhx_mExcel12:06
dhx_mEierlegende Wollmilchsau: interesting term/link, particularly because of the complicated name :)12:07
dhx_mI'd say the ratio of valid uses of Excel to invalid uses is somewhere above 10,000,000:112:08
dhx_moops, 1:10,000,000 ;)12:08
alemayowow .. done :)12:13
alemayoconcerning excel: right ...12:14
alemayodhx_m: what is the best way to retrieve the project id of a bug? bug_get_field ?12:18
dhx_mdo you have a bug object at hand?12:19
dhx_mor just the ID?12:19
dhx_mI'd say use bug_get_field if you only need a single project ID12:19
dhx_mand only if you don't have a bug object already pulled from the database12:20
dhx_mactually12:20
dhx_mbug_get_field pulls the entire bug from the database12:20
dhx_mnot just the field you're interested in12:20
dhx_mso the overhead of creating a new bug object shouldn't be much more...12:21
alemayoI have just the ID :)12:21
dhx_mso use bug_get()12:21
dhx_mand you'll receive a bug object12:22
dhx_mto which you can just pull values out of using this sort of technique:12:22
dhx_m$t_the_bug->project_id12:22
alemayookay .. bug_get .. thanks12:22
alemayoby the way .. I call that in the EVENT_DISPLAY_BUG_ID ... not the best thing concerning performance, but computers are cheaper than programmers :-)12:29
dhx_mlol12:30
dhx_mbugs are cached btw12:30
dhx_mso if you get a bug once, it'll be fast next time12:30
alemayoyes I saw that caching stuff ...12:35
alemayoactually that whole mantis code reminded me of a project I did some years ago12:35
alemayofirst everything function based, then we introduced objects, and the project grew, then we introduced DB caching, very similar to that in mantis12:36
alemayobut somehow it would make sense to rewrite mantis completely using some modern ORM mapper or s.th. ?12:37
alemayoanyway, it's mature and proven to work .. so never touch a running system ?12:37
dhx_mwell we're slowly trying to move everything to OO12:43
dhx_maway from the old procedural programming style12:43
alemayoyes.. saw that13:00
dhx_mnuclear_eclipse: importing works, woohoo :)13:19
alemayojust another new plugin ... http://git.mantisforge.org/w/CustomID.git13:30
dhx_mit's good that you're making quite a few plugins, they're good examples for other people to look at13:39
dhx_mwhen they want to write their own Mantis plugin13:39
dawitayahow can I find out if a project is a child of another project?13:45
dhx_mprogramatically?13:46
dawitayayes13:46
dhx_mproject_hierarchy_inheritance13:48
dhx_m * Generate an array of project's the given project inherits from,13:48
dhx_m * including the original project in the result.13:48
dhx_m * @param int $p_project_id Project ID13:48
dhx_m * @param bool $p_show_disabled Whether or not to consider projects which are disabled13:48
dhx_m * @return array13:48
dawitayathanks a lot14:04
dawitayais there any reason that int(0) is included in that list returned ?14:04
dhx_mnot sure14:08
dhx_mcheck project_hierarchy_api.php to find out more :)14:09
dhx_malemayo: I read your comment http://www.mantisbt.org/bugs/view.php?id=10211#c24250 suggesting someone helps with ServiceLevel14:14
dhx_myet it isn't uploaded to MantisForge :)14:14
dhx_mI'd be interested in helping out because the plugin sounds quite useful :)14:15
alemayoso I would just add dhx to mantisforge ?14:19
dhx_mthat's up to you (I can otherwise just make a fork)14:20
alemayois the mantisbot keeping chatlogs ?14:20
dhx_mwhat I was trying to say though14:20
dhx_mis the ServiceLevel repo on there only has a few strings in a language file14:20
dhx_myes14:20
dhx_mI wasn't sure if that was intentional14:20
alemayooh no wait14:21
alemayoactually it is a bit dependend on our subcategory hacks :)14:22
dhx_mah ok14:22
dhx_mit might be best to try and decouple them if possible14:22
dhx_mbefore pushing it to mantisforge14:22
alemayoargh, my dual screen config is messed up ...14:23
alemayobrb14:23
alemayore14:25
alemayomaybe that was the reason why I did not push it yet I guess14:25
dhx_m:)14:25
alemayoI will push it ...14:29
alemayoit is also working without the subcategories14:29
alemayoit's just not very beautiful :)14:29
dhx_mnice :)14:29
dhx_mI'll check it out14:29
alemayoso it's up14:31
alemayohave fun :)14:31
alemayocurrently it is just a pimped summary page14:31
dhx_mbtw I noticed you let the "mob" user write to that repo14:32
alemayoyes14:32
dhx_mthe "mob" user is for public use, just in case you weren't aware14:32
alemayocan mob writer everywhere or only to a branch called mob ?14:32
dhx_mso anyone can commit14:32
dhx_manywhere I think14:32
alemayohm14:32
dhx_mpersonally I don't like the idea much14:33
alemayoI liked the idea :)14:33
dhx_mpeople should make their own fork instead, and request you to merge their branches/changes14:33
alemayoanyway .. your username is "dhx", isn't it >14:33
dhx_mthe thing is, someone can screw up your repository (by accident, or otherwise)14:33
dhx_mand there may not be any way of knowing14:34
dhx_myes, I'm dhx14:34
alemayoI was beliving git is smart enough to not allow screwing things up ... hm...14:34
alemayois that paul__ in that IRC the same paul that is hosting the mantisforge git ?14:34
dhx_mwell they could delete your branches and replace them with their own14:35
dhx_myep14:35
dhx_mat least I think the "mob" user can do that14:35
dhx_mit'd be fine if "mob" could only commit, and not delete branches14:35
dhx_mor actually14:35
dhx_mI don't really like that either, because people could make malicious commits14:36
dhx_mthat other people don't notice when they download a plugin14:36
alemayoI have read somewhere that mob only can access the mob branch...14:36
dhx_mah maybe that's right then14:36
alemayohttp://git.mantisforge.org/mob.html14:37
alemayoso added you14:37
dhx_mah, "mob" seems quite useful then :)14:38
dhx_malthough git format-patch does much the same thing14:38
dhx_mit might work with a larger/more active developer community14:39
alemayoyes .. so at least I see when somebody made a patch14:40
alemayobut anyway, I still like it14:41
* alemayo just adds the mob branch for all of his plugins14:41
dhx_myep14:42
alemayoshould we document the servicelevel plugin in some wiki ?14:43
dhx_msome comments:14:43
dhx_mif ($_GET["list"]) {14:43
dhx_mshould use the gpc_get_string_array() function call instead from gpc_api.php14:43
dhx_mUndefined index: submitted14:44
dhx_mFull path: /var/www/localhost/htdocs/mantis-git/plugins/ServiceLevel/pages/evaluation_api.php14:45
dhx_mLine: 38714:45
alemayojust fix it :-)14:45
alemayothis list stuff is anyways very very hacky ...14:45
dhx_malso same line:14:45
dhx_mUndefined index: closed14:45
dhx_myep, I guess a lot of bugs are found when different people use it14:45
dhx_mas everyone has different Mantis settings, etc14:45
alemayowere there any major changes in summary_page ?14:46
dhx_mUndefined variable: hide14:46
alemayobecause I just copied summary_page ... but from RC114:46
dhx_mFull path: /var/www/localhost/htdocs/mantis-git/plugins/ServiceLevel/pages/evaluation_api.php14:46
dhx_mLine: 4114:46
alemayoah you have warnings on? just switch them off *ggg*14:46
alemayomore interesting are the mysql views the plugin is creating14:46
dhx_mI always develop with the strictest warnings :p14:47
dhx_msee http://git.mantisbt.org/?p=mantisbt.git;a=history;f=summary_page.php;h=c7f1d9c9d9e5ffd5c7f2485e7bb7f4760826ac5a;hb=HEAD14:47
dhx_monly the commits from 2009 are relevant to the 1.2.x branch14:47
dhx_mthe 2010 commits are 1.3.x only14:47
dhx_mnothing too major14:48
dhx_mactually check here instead:14:48
dhx_mhttp://git.mantisbt.org/?p=mantisbt.git;a=history;f=summary_page.php;h=0ad8ca7488d75f93f6af262d80f62921004ecffa;hb=master-1.2.x14:48
dhx_mfor the 1.2.x branch14:48
nuclear_eclipsehi dhx_m14:49
dhx_mnuclear_eclipse: hi :)14:49
nuclear_eclipseit'll be nice to finally have hg integration to match git :P14:50
nuclear_eclipsenow you just need to make a plugin for bitbucket too :P14:50
dhx_mnuclear_eclipse: perhaps, if it's easy :)14:51
dhx_mnuclear_eclipse: I was actually surprised with how relatively simple it is to write a SourceIntegration plugin14:51
dhx_myou've done well! :)14:51
nuclear_eclipseyep14:51
nuclear_eclipsethank you14:51
nuclear_eclipsetbh, after looking at how I did the plugin columns and filters system, I wish I had done something like that for source integration instead14:52
nuclear_eclipsewould have saved a *lot* of if statements in functions...14:52
dhx_mmy current view on Mercurial/Bazaar is that it is a half-assed git :p14:52
dhx_myep14:53
nuclear_eclipseI'm tempted to rewrite the core of source integration framework to make it nicer, and call *that* 1.0...14:53
dhx_malthough to be fair, SCMs don't change that frequently and none really support custom fields (I wish they did)14:53
nuclear_eclipseI just meant the way the plugins integrate with the framework14:54
dhx_mah ok14:54
nuclear_eclipseeg, rather than the core firing events, the core fires a single event to register source integration classes, and then the core directly calls only the appropriate integration instance, rather than calling them all via events14:55
dhx_mbitbucket would be quite simple to write a plugin for, now I look at it ;)14:55
nuclear_eclipsewould be both more efficient and make writing a little more straightforward14:56
dhx_mgood point :)14:56
nuclear_eclipsejust requires me to stop being lazy and actually get some work done...14:56
darynyou have that problem too nuclear_eclipse?14:57
nuclear_eclipseI think all diehard programmers do :P14:57
dhx_mhaha yep14:58
darynthat's what makes us programmers, right?14:58
darynfiguring out ways to do less work14:58
nuclear_eclipseexactly14:58
dhx_malemayo: another bug (missing mantis_db_table() call or whatever function it is):14:58
dhx_mUndefined variable: t_mantis_bug_table14:58
dhx_mFull path: /var/www/localhost/htdocs/mantis-git/plugins/ServiceLevel/pages/evaluation_page.php14:58
dhx_mLine: 17814:58
dhx_m(line numbers may be off, I've made a few edits to fix the bugs I mentioned before)14:58
dhx_mUndefined index: 115:00
dhx_mFull path: /var/www/localhost/htdocs/mantis-git/plugins/ServiceLevel/pages/evaluation_api.php15:00
dhx_mLine: 27515:00
dhx_mif (!$statistics[$row["project_id"]]) $statistics[$row["project_id"]] = array("name" => $row["category_name"]);15:00
dhx_mthe pattern I'm seeing is that you're using if($array['key']) instead of if(isset($array['key']))15:02
nuclear_eclipsedhx_m: I think I'll work on source integration shortly, just gotta get out of windows and back to linux...15:13
nuclear_eclipsebeen starting to get into working on a mod team for a game, and Visual Studio really only works in windows...15:14
dhx_mI doubt there are many bug trackers out there that can let you write a quick plugin (2-3hrs tops) to integrate your bug tracker with whatever web based VCS you're using :)15:14
dhx_myep15:14
dhx_mso in that sense, SourceIntegration is quite solid15:14
nuclear_eclipseyeah, I've been using it on multiple projects quite successfully15:15
nuclear_eclipseand the integrations you see aren't even all of the ones I wrote :P15:15
nuclear_eclipsehad to write a couple proprietary integration plugins for my former employer15:15
dhx_mI quite like it how the diffs/etc are done with other web based repository viewing tools15:15
nuclear_eclipseyeah, that's more laziness/reuse :P15:16
dhx_mno wonder it's designed to be easy to extend then :)15:16
dhx_mwell it's better :p15:16
dhx_mno need to reinvent everything when it's not necessary to do so15:17
nuclear_eclipseexactly15:17
nuclear_eclipseI did have to write from-scratch viewers for one of the proprietary vcs plugins, but only because there is no existing web viewer for it15:17
dhx_myep15:18
dhx_mI guess Trac tries to go down the rewrite path15:18
nuclear_eclipseyep15:18
nuclear_eclipsemy biggest gripe with Trac is the repo-per-install paradigm15:19
dhx_myep15:19
nuclear_eclipseI have multiple repos on my own project tracker, and my old employer has even more, and they aren't all the same VCS type15:19
nuclear_eclipseand it's quite often that, esp with separate integrated products, you have commits from separate VCS repos for the same bug number15:20
dhx_myep15:20
dhx_mand another reason why using web interfaces is handy15:21
nuclear_eclipseyep15:21
dhx_myou can add repos for upstream projects15:21
dhx_mand link commits in those repos to bugs in your own (where upstream is blocking)15:21
dhx_mthe only real catch at the moment is the slooowness at which commits are imported15:22
dhx_mit wouldn't be so bad if it did 50 commits per page refresh15:22
dhx_mwith resume support15:22
nuclear_eclipsedhx_m: you could make it do that...15:25
dhx_mit'd be nice if it was built into the core though15:25
dhx_mas opposed to needing to be implemented in each plugin15:25
dhx_mI'm not sure if that's possible though15:25
nuclear_eclipsewell, it would just be a matter of "don't find all the commits this round" :P15:25
dhx_mI guess a page like Source/checkin.php15:26
nuclear_eclipsethere's already support for returning a subset at a time for memory reasons15:26
dhx_mcould generically call a plugin event for the relevant repository with a start and end index15:26
dhx_mthus it becomes integrated into the core :)15:27
nuclear_eclipseie, with large SVN repos, getting an 'svn log' of the ntire history blows out the PHP memory limit almost every time, so the core supports returning commits in batches15:27
dhx_myep15:27
dhx_mI should look into it a little further15:27
nuclear_eclipsehowever, the import still takes forever that way, it just no longer uses up all the memory :P15:28
nuclear_eclipseback in linux now15:28
nuclear_eclipseI should probably get around to all the other source integration bugs on my tracker, too...15:30
dhx_mdid you see my modtimestamp patch for Timecard (from last year)?15:30
dhx_mit probably needs some more work, but it may be of interest15:31
nuclear_eclipseyeah, I saw it :P15:31
dhx_mit allows (optionally) minute resolution15:31
nuclear_eclipseemployer didn't like the idea, so it never got inlined on their time, so it never got committed at all :P15:31
dhx_mand allows you to change the time tracked as well as the timestamp of it15:32
dhx_myep15:32
nuclear_eclipsemaybe because I never felt like working on mantis stuff that I had just spent 8 hours dealing with...15:32
nuclear_eclipses/maybe/mainly/15:32
dhx_mhaha understandable15:32
dhx_mI guess Timecard (with my changes) would make make it identical to the built in system in terms of features15:33
dhx_mthus leading to a possible removal of the built-in system15:33
nuclear_eclipseyeah, probably, not that it would be a bad thing...15:33
dhx_mpending a conversion script15:33
nuclear_eclipselol, I started working on this, and now I have to look at my docbook to figure out what some of the events in mantis are :P15:40
nuclear_eclipseapparently I wrote good documentation too :)15:42
dhx_mlol yep15:44
rolfkleefanyone "in charge" of the issue tracker at mantisbt around?16:27
rolfkleeflike to see if I can be of help in sorting out issues :-)16:28
nuclear_eclipserolfkleef: something like a "triage" type of role you mean?16:35
rolfkleefyes16:45
rolfkleefI've modestly tagged two issues with "close_me" so far,16:46
nuclear_eclipseI'm all for it16:46
nuclear_eclipseour tracker really needs some lovin :P16:46
rolfkleefand find myself browsing for info through issues quite a bit lately, often thinking "this could go to feedback" and then be closed if that doesn't come16:46
rolfkleefI know :-) 2200+ issues or so is a bit overwhelming :-)16:47
nuclear_eclipseif you're willing to put in the effort, I'll gladly give you developer access16:47
nuclear_eclipsejust need to know your username on our tracker16:47
rolfkleefI'm happy to try it out for a while, see if it works for everyone16:47
rolfkleeftake a guess :-)16:47
nuclear_eclipsehehe16:48
rolfkleefnot sure if there are sort of meetings sometimes to discuss tickets?16:48
nuclear_eclipsenot really16:48
nuclear_eclipsewe're a very adhoc development team, for better or worse16:49
rolfkleefI could use tags to flag stuff for review by someone with more indepth knowledge16:49
nuclear_eclipsemost we have is periodic design discussions on IRC or mantisbt-dev mailing list16:49
rolfkleefok - well, if there's no real policy yet, I'll try to introduce a few rules16:50
nuclear_eclipseare you subscribed to the dev list? it's low traffic, but would be a good place to post any ideas/plans for how you'd like to handle any sort of triage system16:50
nuclear_eclipse... *very* low traffic... =\16:50
rolfkleefyeah, I'm reading it via news.gmane.org16:51
nuclear_eclipseok16:51
nuclear_eclipseI've given you developer access to the main project16:51
rolfkleefok, cool16:52
nuclear_eclipseI'll drop a note on the dev list about it16:52
rolfkleefI'll send an intro myself as well then16:52
nuclear_eclipseI assume your first name is Rolf?16:52
rolfkleefit is16:53
rolfkleefbeen working with mantis for 4 years or so now, a few years ago tried to build a work flow system for a funding organisation out of it16:54
rolfkleef(have to log off here... back later. thanks!)16:56
nuclear_eclipsecheers16:57
nuclear_eclipselunchtime for me too16:58
* paul__ looks around21:20
paul__nuclear_eclipse: dhx_m21:20
nuclear_eclipsehi paul__21:36

Generated by irclog2html.py