| ../irclogs/#mantishelp.2010-02-07.log | ||
| --- scribe started --- | 00:00 | |
| CIA-24 | Mantisbt: hickseydr master-1.2.x * rb65591fd61a3 /core/bug_api.php: Fix #11449: Fix incorrect table name in db_get_table call | 12:02 |
|---|---|---|
| CIA-24 | Mantisbt: hickseydr * r83b89fcdec87 /core/bug_api.php: Issue #11375: Narrow down SQL SELECT to get minimum columns | 12:02 |
| CIA-24 | Mantisbt: hickseydr master-1.2.x * r185b4b26e981 /core/bug_api.php: Issue #11375: Narrow down SQL SELECT to get minimum columns | 12:02 |
| paul__ | moo | 12:03 |
| dhx_m | paul__: moo | 12:03 |
| paul__ | 1 of those only applies to master branch? | 12:04 |
| dhx_m | #11449 was because of a bad backport from 1.3.x to 1.2.x | 12:04 |
| dhx_m | db_get_table is different between versions | 12:04 |
| paul__ | ya | 12:05 |
| paul__ | dhx_m: do you have xdebug set up? | 12:09 |
| dhx_m | paul__: yep | 12:24 |
| paul__ | edo you use mysqli? | 12:25 |
| paul__ | i've got a local patch | 12:25 |
| paul__ | to db_fetch_array | 12:25 |
| paul__ | -if( $g_db_type == 'mysql' || $g_db_type == 'odbc_mssql' ) { | 12:25 |
| paul__ | +if( $g_db_type == 'mysql' || $g_db_type == 'mysqli' || $g_db_type == 'odbc_mssql' ) { | 12:25 |
| dhx_m | I just use normal MySQL | 12:25 |
| dhx_m | oh I see, it's an interface | 12:26 |
| dhx_m | in which case, I don't know :p | 12:26 |
| dhx_m | I normally use PostgreSQL | 12:26 |
| paul__ | dhx_m: oh didn't realise | 13:55 |
| paul__ | wonder if nuclear_eclipse is mysql expert then | 13:55 |
| nuclear_eclipse | yes paul__, mysql is the one I use :P | 14:05 |
| paul__ | mysqli ? | 14:19 |
| paul__ | or more | 14:19 |
| paul__ | shouldn't you be using mysqli over mysql? | 14:19 |
| paul__ | http://ca3.php.net/manual/en/mysqli.overview.php | 14:22 |
| nuclear_eclipse | mysqli suppprts fancy things like transactions, but for the purpose of wht mantis uses, there isnt much of a difference at all that i know of, other than using a diferrejt extension/api on the backend | 16:08 |
| nuclear_eclipse | i dont think there isanything significantly faster r "better" with mysqli. it just supports new features from mysql 5.0+ | 16:10 |
| paul__ | nuclear_eclipse: should we changing the default to mysqli i wonder? | 17:29 |
| paul__ | but more to the point, need to validate that: | 17:30 |
| paul__ | # mysql obeys FETCH_MODE_BOTH, hence ->fields works, other drivers do not support this | 17:30 |
| paul__ | -if( $g_db_type == 'mysql' || $g_db_type == 'odbc_mssql' ) { | 17:30 |
| paul__ | +if( $g_db_type == 'mysql' || $g_db_type == 'mysqli' || $g_db_type == 'odbc_mssql' ) { | 17:30 |
| paul__ | in db_fetch_array is correct+valid | 17:30 |
| nuclear_eclipse | yes, I think we should default to mysqli now | 17:44 |
| nuclear_eclipse | technically, we could probably drop mysql by itself anyways, since we require php5+ now | 17:45 |
| nuclear_eclipse | any php5 install (I think) should have mysqli by definition if mysql support is compiled in | 17:46 |
Generated by irclog2html.py