Friday, 2010-08-27

« Thursday, 2010-08-26 Index Saturday, 2010-08-28 »
../irclogs/#mantishelp.2010-08-27.log
--- scribe started ---00:00
CIA-100Mantisbt: daryn * r02aac88deba4 / (core/html_api.php css/default.css): Fix #12300 - Logout button hidden behind issue # box07:08
dhx_mdaryn: howdy09:01
darynyou just barely caught me...what's up?09:01
dhx_mdaryn: ah, good timing :)09:01
dhx_mdaryn: not much, just wanted to say hi :)09:01
dhx_mgood work with the UI changes lately09:01
dhx_mI noticed you were helping remove inline scripting and styling09:02
daryncool.  i'm treading a bit on some of your work09:02
dhx_mplease do :)09:02
daryni'm working on the rest of the header right now.  removing the tables, adding styles, removing js09:02
dhx_mjust a heads up that I was redoing MantisGraph's bug_graph page09:02
dhx_mthat is my only outstanding change09:02
dhx_mthat page is a bit of work unfortuantly09:03
darynok. i don't think i've touched that at all09:03
dhx_mafaik filters still use JS09:03
daryninline?09:03
dhx_mI almost didn't either :)09:03
dhx_minline = not included in an external .js file09:03
dhx_mgtg for 15min09:03
dhx_mI guess that means you'll be gone09:03
dhx_mso I'll catch you later09:03
darynk. yep. going to bed09:03
daryncya09:03
dhx_mttyl09:04
dhx_mcya09:04
Githubmantisbt: master Daryn Warriner * 02aac88 (2 files in 2 dirs): Fix #12300 - Logout button hidden behind issue # box - http://bit.ly/axC7DU16:30
CIA-100Mantisbt: daryn * r7ec1d497560c / (4 files in 4 dirs): Issue #11826 - Remove all inline JavaScript from MantisBT (use external scripts instead)17:02
darynnuclear_eclipse: I found a bug with plugin filters, what are the rules for committing bug fixes to 1.2.x now?18:16
CIA-100Mantisbt: daryn * rb30ca3b950ab /core/filter_api.php: Fix #12304 - If plugins set a params value for plugin filters the values18:26
darynso i went ahead and commited for trunk. just not sure if i should commit to 1.2.x too...18:26
CIA-100Mantisbt: daryn * rb729d5de971b /manage_columns_inc.php: Fix incorrectly named form.18:47
nuclear_eclipsedaryn: if it's not a breaking change, have at it18:50
darynit shouldn't be...it's actually breaking not to have it if someone attempts to assign params in a plugin filter.18:51
nuclear_eclipseif it's a breaking change, the question is how much does it break, and if the fix is really needed18:51
nuclear_eclipseI guess I should look at the commit :P18:51
darynwell, the work around is to just assign the values directly in the sql query18:51
DirtyAlhello, I just updated the Source integration with mantis18:52
DirtyAland18:52
DirtyAldb_param is returning ?18:52
darynwhich i think is what has been done in the existing plugins18:52
DirtyAlinstead ot he ID of the repo18:52
DirtyAlanu ideas?18:52
DirtyAlany ideias?18:52
darynbut they really should use query bound18:52
DirtyAlSource.API.php line 68718:52
DirtyAlfunction load18:53
nuclear_eclipsedaryn: yeah, that should be good to port back to 1.218:53
DirtyAlthe param passed it right, but the query is built usind the db_param that soulhd return the repo_ids18:53
DirtyAlbut it returns ?18:53
darynnuclear_eclipse: ok i'll push it18:53
DirtyAlany ideas on that?18:53
nuclear_eclipsedb_param() alsways returns ?18:54
nuclear_eclipseit's a placeholder for the value in the SQL query18:54
DirtyAl$t_query = "SELECT * FROM $t_repo_table WHERE id=" . db_param();18:54
nuclear_eclipseDirtyAl: db_query_bound() takes a list of parameters that get cleaned and inserted in place of those question marks18:54
CIA-100Mantisbt: daryn master-1.2.x * r9d56dad2c9fd /core/filter_api.php: Fix #12304 - If plugins set a params value for plugin filters the values18:58
DirtyAltks,19:07
DirtyAlbut the integration is not working19:07
DirtyAlverion 0.13 is working, the new 0.16 is not19:07
nuclear_eclipseDirtyAl: what version control system are you using?19:07
DirtyAlwebsvn19:07
nuclear_eclipseand what type of server? linux, windows??19:08
DirtyAlcentos 5, php 5.2;919:08
DirtyAlmysql19:08
DirtyAlsvn 1.419:08
nuclear_eclipseah, I think that's the problem, I think it uses some parameters that were added in svn 1.519:09
DirtyAlhummm...19:09
nuclear_eclipsein SourceSVN, there should be a function that defines the default svn binary parameters, you should look there to see for sure19:10
DirtyAlin the 0.1319:10
DirtyAlI had to chance that19:10
DirtyAlto be like this19:10
DirtyAl$s_call = 'svn --config-dir=/var/www/.subversion';19:10
DirtyAlI will do that in 0.16 to see19:10
nuclear_eclipseyou probably need to add that to the new version then too19:10
DirtyAlstrange ennough, after the upgrade, it worked all right19:11
DirtyAlit just stopped worlking an hour ago19:11
nuclear_eclipsealthough in the new version there should be a UI config option to add parametrs19:11
DirtyAlthat, setting the params in the UI did the trick19:14
DirtyAltks man, sorry for the lame question, should have checked the params first19:15
nuclear_eclipsenp19:16
DirtyAlI still have to patch the Soorce to set the fixed_in_version to the target_version when a ticket it resolved19:18
DirtyAlvia a SVN commit19:18
DirtyAlbut it this integration you wrote is very nice19:19
nuclear_eclipsethank you :)19:19
DirtyAlTill yesteraday I was using 1.3.0dev, I downgraded to 1.2.2 and upgrade all plugins19:20
DirtyAlso far, perfect.19:20
Githubmantisbt: master Daryn Warriner * 7ec1d49 (4 files in 4 dirs): Issue #11826 - Remove all inline JavaScript from MantisBT (use external scripts instead) ...22:30
Githubmantisbt: master Daryn Warriner * b30ca3b (1 files in 1 dirs): Fix #12304 - If plugins set a params value for plugin filters the values ...22:30
Githubmantisbt: master Daryn Warriner * b729d5d (1 files in 1 dirs): Fix incorrectly named form.22:30
Githubmantisbt: master commits 02aac88...b729d5d - http://bit.ly/bSpyuP22:30
Githubmantisbt: master-1.2.x Daryn Warriner * 9d56dad (1 files in 1 dirs): Fix #12304 - If plugins set a params value for plugin filters the values ... - http://bit.ly/b2tSYE22:30
« Thursday, 2010-08-26 Index Saturday, 2010-08-28 »

Generated by irclog2html.py